You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Sergei Ryzhov <s....@gmail.com> on 2021/12/22 09:08:46 UTC
Move the Zookeeper IP-finder to the ignite-extensions
Hi, igniters,
I've created an issue [1] to move the zookeeper IP-finder to the
ignite-extensions. The motivation is the same as with migration of
cloud-based IP-finders - to remove integration dependency of the
release cycle on Ignite releases. Also, the log4j dependency with
vulnerabilities (needed for Apache Curator) will be removed from the Ignite
release.
Any objections?
[1] https://issues.apache.org/jira/browse/IGNITE-16182
--
Best regards,
Sergei Ryzhov
Re: Move the Zookeeper IP-finder to the ignite-extensions
Posted by Ivan Daschinsky <iv...@gmail.com>.
Let's explain more thoroughly
Ignite module ignite-zookeeper contains 2 packages
1. org.apache.ignite.spi.discovery.tcp.ipfinder.zk;
It contains one class, TcpDiscoveryZookeeperIpFinder, that is just
implementation of TcpDiscoveryIpFinder, it uses Apache Curator
ServiceDiscovery recipe to
register and retrieve IP addresses of other nodes and use these addresses
in TcpDiscovery process. It is literally few hundred lines of code with
comments and imports.
2. org.apache.ignite.spi.discovery.zk
It contains full blown implementation of DiscoverySpi. Quite complex and a
lot of code.
These two packages have nothing common except substring "zookeeper". I
don't have any idea why they are present in one package.
ср, 22 дек. 2021 г. в 14:00, Ivan Daschinsky <iv...@gmail.com>:
> I am +1 for removing ZookeeperIpFinder from ignite-zookeeper module. It is
> not needed here.
>
> ср, 22 дек. 2021 г. в 14:00, Ivan Daschinsky <iv...@gmail.com>:
>
>> >> a lot of code in core code base is dedicated for enabling it.
>> It is simply not true. ZookeeperDiscovery has nothing common with
>> ZookeeperIpFinder.
>>
>> The last one is simply one class and similar to others IP finders.
>>
>> ср, 22 дек. 2021 г. в 13:25, Ilya Kasnacheev <il...@gmail.com>:
>>
>>> Hello!
>>>
>>> I think it might not be a good idea, since Zookeeper IP Finder is not
>>> stand-alone - a lot of code in core code base is dedicated for enabling
>>> it.
>>> This code may break unnoticed if Zookeeper IP Finder is not built/tested
>>> on
>>> every commit.
>>>
>>> Regards,
>>> --
>>> Ilya Kasnacheev
>>>
>>>
>>> ср, 22 дек. 2021 г. в 12:09, Sergei Ryzhov <s....@gmail.com>:
>>>
>>> > Hi, igniters,
>>> >
>>> > I've created an issue [1] to move the zookeeper IP-finder to the
>>> > ignite-extensions. The motivation is the same as with migration of
>>> > cloud-based IP-finders - to remove integration dependency of the
>>> > release cycle on Ignite releases. Also, the log4j dependency with
>>> > vulnerabilities (needed for Apache Curator) will be removed from the
>>> Ignite
>>> > release.
>>> >
>>> > Any objections?
>>> >
>>> > [1] https://issues.apache.org/jira/browse/IGNITE-16182
>>> > --
>>> > Best regards,
>>> > Sergei Ryzhov
>>> >
>>>
>>
>>
>> --
>> Sincerely yours, Ivan Daschinskiy
>>
>
>
> --
> Sincerely yours, Ivan Daschinskiy
>
--
Sincerely yours, Ivan Daschinskiy
Re: Move the Zookeeper IP-finder to the ignite-extensions
Posted by Ivan Daschinsky <iv...@gmail.com>.
I am +1 for removing ZookeeperIpFinder from ignite-zookeeper module. It is
not needed here.
ср, 22 дек. 2021 г. в 14:00, Ivan Daschinsky <iv...@gmail.com>:
> >> a lot of code in core code base is dedicated for enabling it.
> It is simply not true. ZookeeperDiscovery has nothing common with
> ZookeeperIpFinder.
>
> The last one is simply one class and similar to others IP finders.
>
> ср, 22 дек. 2021 г. в 13:25, Ilya Kasnacheev <il...@gmail.com>:
>
>> Hello!
>>
>> I think it might not be a good idea, since Zookeeper IP Finder is not
>> stand-alone - a lot of code in core code base is dedicated for enabling
>> it.
>> This code may break unnoticed if Zookeeper IP Finder is not built/tested
>> on
>> every commit.
>>
>> Regards,
>> --
>> Ilya Kasnacheev
>>
>>
>> ср, 22 дек. 2021 г. в 12:09, Sergei Ryzhov <s....@gmail.com>:
>>
>> > Hi, igniters,
>> >
>> > I've created an issue [1] to move the zookeeper IP-finder to the
>> > ignite-extensions. The motivation is the same as with migration of
>> > cloud-based IP-finders - to remove integration dependency of the
>> > release cycle on Ignite releases. Also, the log4j dependency with
>> > vulnerabilities (needed for Apache Curator) will be removed from the
>> Ignite
>> > release.
>> >
>> > Any objections?
>> >
>> > [1] https://issues.apache.org/jira/browse/IGNITE-16182
>> > --
>> > Best regards,
>> > Sergei Ryzhov
>> >
>>
>
>
> --
> Sincerely yours, Ivan Daschinskiy
>
--
Sincerely yours, Ivan Daschinskiy
Re: Move the Zookeeper IP-finder to the ignite-extensions
Posted by Ilya Kasnacheev <il...@gmail.com>.
Hello!
OK, I'm retracting my claim then. IP-finder may indeed be moved to
extensions.
Regards,
--
Ilya Kasnacheev
ср, 22 дек. 2021 г. в 14:00, Ivan Daschinsky <iv...@gmail.com>:
> >> a lot of code in core code base is dedicated for enabling it.
> It is simply not true. ZookeeperDiscovery has nothing common with
> ZookeeperIpFinder.
>
> The last one is simply one class and similar to others IP finders.
>
> ср, 22 дек. 2021 г. в 13:25, Ilya Kasnacheev <il...@gmail.com>:
>
> > Hello!
> >
> > I think it might not be a good idea, since Zookeeper IP Finder is not
> > stand-alone - a lot of code in core code base is dedicated for enabling
> it.
> > This code may break unnoticed if Zookeeper IP Finder is not built/tested
> on
> > every commit.
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > ср, 22 дек. 2021 г. в 12:09, Sergei Ryzhov <s....@gmail.com>:
> >
> > > Hi, igniters,
> > >
> > > I've created an issue [1] to move the zookeeper IP-finder to the
> > > ignite-extensions. The motivation is the same as with migration of
> > > cloud-based IP-finders - to remove integration dependency of the
> > > release cycle on Ignite releases. Also, the log4j dependency with
> > > vulnerabilities (needed for Apache Curator) will be removed from the
> > Ignite
> > > release.
> > >
> > > Any objections?
> > >
> > > [1] https://issues.apache.org/jira/browse/IGNITE-16182
> > > --
> > > Best regards,
> > > Sergei Ryzhov
> > >
> >
>
>
> --
> Sincerely yours, Ivan Daschinskiy
>
Re: Move the Zookeeper IP-finder to the ignite-extensions
Posted by Ivan Daschinsky <iv...@gmail.com>.
>> a lot of code in core code base is dedicated for enabling it.
It is simply not true. ZookeeperDiscovery has nothing common with
ZookeeperIpFinder.
The last one is simply one class and similar to others IP finders.
ср, 22 дек. 2021 г. в 13:25, Ilya Kasnacheev <il...@gmail.com>:
> Hello!
>
> I think it might not be a good idea, since Zookeeper IP Finder is not
> stand-alone - a lot of code in core code base is dedicated for enabling it.
> This code may break unnoticed if Zookeeper IP Finder is not built/tested on
> every commit.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> ср, 22 дек. 2021 г. в 12:09, Sergei Ryzhov <s....@gmail.com>:
>
> > Hi, igniters,
> >
> > I've created an issue [1] to move the zookeeper IP-finder to the
> > ignite-extensions. The motivation is the same as with migration of
> > cloud-based IP-finders - to remove integration dependency of the
> > release cycle on Ignite releases. Also, the log4j dependency with
> > vulnerabilities (needed for Apache Curator) will be removed from the
> Ignite
> > release.
> >
> > Any objections?
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-16182
> > --
> > Best regards,
> > Sergei Ryzhov
> >
>
--
Sincerely yours, Ivan Daschinskiy
Re: Move the Zookeeper IP-finder to the ignite-extensions
Posted by Ilya Kasnacheev <il...@gmail.com>.
Hello!
I think it might not be a good idea, since Zookeeper IP Finder is not
stand-alone - a lot of code in core code base is dedicated for enabling it.
This code may break unnoticed if Zookeeper IP Finder is not built/tested on
every commit.
Regards,
--
Ilya Kasnacheev
ср, 22 дек. 2021 г. в 12:09, Sergei Ryzhov <s....@gmail.com>:
> Hi, igniters,
>
> I've created an issue [1] to move the zookeeper IP-finder to the
> ignite-extensions. The motivation is the same as with migration of
> cloud-based IP-finders - to remove integration dependency of the
> release cycle on Ignite releases. Also, the log4j dependency with
> vulnerabilities (needed for Apache Curator) will be removed from the Ignite
> release.
>
> Any objections?
>
> [1] https://issues.apache.org/jira/browse/IGNITE-16182
> --
> Best regards,
> Sergei Ryzhov
>
Re: Move the Zookeeper IP-finder to the ignite-extensions
Posted by Anton Vinogradov <av...@apache.org>.
Sergei,
Please make sure this will not break the Ducktests.
AFAIK, we have zookeeper tests there.
On Wed, Dec 22, 2021 at 12:09 PM Sergei Ryzhov <s....@gmail.com>
wrote:
> Hi, igniters,
>
> I've created an issue [1] to move the zookeeper IP-finder to the
> ignite-extensions. The motivation is the same as with migration of
> cloud-based IP-finders - to remove integration dependency of the
> release cycle on Ignite releases. Also, the log4j dependency with
> vulnerabilities (needed for Apache Curator) will be removed from the Ignite
> release.
>
> Any objections?
>
> [1] https://issues.apache.org/jira/browse/IGNITE-16182
> --
> Best regards,
> Sergei Ryzhov
>