You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2026/06/22 22:13:01 UTC
[Impala-ASF-CR] PROTOTYPE: Packaging to ship multiple malloc implementations
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24500
Change subject: PROTOTYPE: Packaging to ship multiple malloc implementations
......................................................................
PROTOTYPE: Packaging to ship multiple malloc implementations
Currently, this ships multiple impalad binaries with
different malloc implementations. It has the following
structure:
- impalad: now a helper script to call the same binary name
in the malloc implementation directory (i.e. statestored
calls {malloc_impl}/statestore)
- (statestored,admissiond,catalogd) - symlink to impalad
- {malloc_impl}/impalad - the actual impala binary
- {malloc_impl}/(statestored,admissiond,catalogd) - symlink
to malloc-specific impalad
This modifies the docker image creation and the upstream
OS packaging logic (RPMs and DEBs).
TODO:
- Fix Breakpad test
- Add a way to turn this off
Testing:
- Ran builds locally
Change-Id: I53d3768b9d0df69c280ac3e9b478664830b93cc0
---
M be/CMakeLists.txt
M be/src/service/CMakeLists.txt
A be/src/service/impalad_helper.sh
M bin/run-binary.sh
M bin/run-jvm-binary.sh
M bin/start-impala-cluster.py
M docker/impala_base/Dockerfile
M docker/setup_build_context.py
8 files changed, 193 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/24500/1
--
To view, visit http://gerrit.cloudera.org:8080/24500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I53d3768b9d0df69c280ac3e9b478664830b93cc0
Gerrit-Change-Number: 24500
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] PROTOTYPE: Packaging to ship multiple malloc implementations
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24500 )
Change subject: PROTOTYPE: Packaging to ship multiple malloc implementations
......................................................................
Patch Set 1:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24500/1/docker/setup_build_context.py
File docker/setup_build_context.py:
http://gerrit.cloudera.org:8080/#/c/24500/1/docker/setup_build_context.py@135
PS1, Line 135: t
flake8: E501 line too long (91 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/24500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I53d3768b9d0df69c280ac3e9b478664830b93cc0
Gerrit-Change-Number: 24500
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jun 2026 22:15:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] PROTOTYPE: Packaging to ship multiple malloc implementations
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24500 )
Change subject: PROTOTYPE: Packaging to ship multiple malloc implementations
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22968/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I53d3768b9d0df69c280ac3e9b478664830b93cc0
Gerrit-Change-Number: 24500
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jun 2026 22:35:06 +0000
Gerrit-HasComments: No