You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/09/26 12:40:13 UTC
[GitHub] incubator-brooklyn pull request: fix BROOKLYN-70 , allowing the ne...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/190
fix BROOKLYN-70 , allowing the new-style chef community download links
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn chef-download-link
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #190
----
commit 9667fa8df33dc94099188f8c1228c0595a778876
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-09-26T10:39:30Z
fix BROOKLYN-70 , allowing the new-style chef community download links
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fix BROOKLYN-70 , allowing the ne...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/190#issuecomment-56953053
lgtm as is, minor nitpicking only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fix BROOKLYN-70 , allowing the ne...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/190#issuecomment-57496282
Thanks @ahgittin and @neykov - merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fix BROOKLYN-70 , allowing the ne...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/190#discussion_r18085711
--- Diff: software/base/src/main/java/brooklyn/entity/chef/ChefTasks.java ---
@@ -81,7 +87,13 @@ public void run() {
// // remove reference to 'force' below
// }
- tb.add(ArchiveTasks.deploy(null, cookbookArchiveUrl, EffectorTasks.findSshMachine(), privateTmpDirContainingUnpackedCookbook).newTask());
+ String destName = null;
+ if (ArchiveType.of(cookbookArchiveUrl)==ArchiveType.UNKNOWN) {
+ destName = cookbookName + ".tgz";
--- End diff --
yeah - but our scripts will break elsewhere in that case!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fix BROOKLYN-70 , allowing the ne...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/190#discussion_r18085473
--- Diff: software/base/src/main/java/brooklyn/entity/chef/ChefTasks.java ---
@@ -81,7 +87,13 @@ public void run() {
// // remove reference to 'force' below
// }
- tb.add(ArchiveTasks.deploy(null, cookbookArchiveUrl, EffectorTasks.findSshMachine(), privateTmpDirContainingUnpackedCookbook).newTask());
+ String destName = null;
+ if (ArchiveType.of(cookbookArchiveUrl)==ArchiveType.UNKNOWN) {
+ destName = cookbookName + ".tgz";
--- End diff --
Theoretically cookbookName could contain non-file-system-safe characters (though using such key names is asking for trouble).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fix BROOKLYN-70 , allowing the ne...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---