You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by shaoxuan-wang <gi...@git.apache.org> on 2017/02/24 04:04:26 UTC

[GitHub] flink pull request #3405: [FLINK-5899] [table] Fix the bug in EventTimeTumbl...

GitHub user shaoxuan-wang opened a pull request:

    https://github.com/apache/flink/pull/3405

    [FLINK-5899] [table] Fix the bug in EventTimeTumblingWindow for non-partialMerge aggregate

    I have changed the supportPartial to false for all built-in Aggregates, and run all the UTs. Luckily this is the only bug we have so far.
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [X] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [X] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shaoxuan-wang/flink F5899-submit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3405.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3405
    
----
commit bb233179d06325b481fe0e2a903a55c547529f06
Author: shaoxuan-wang <ws...@gmail.com>
Date:   2017-02-24T03:57:44Z

    [FLINK-5899] [table] Fix the bug in EventTimeTumblingWindow for non-partialMerge aggregate

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3405: [FLINK-5899] [table] Fix the bug in EventTimeTumbl...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3405


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3405: [FLINK-5899] [table] Fix the bug in EventTimeTumblingWind...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3405
  
    Thanks for the fix @shaoxuan-wang!
    Merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---