You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2015/04/27 20:00:43 UTC
Review Request 33590: Blueprint configuration validation fails for all
password properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33590/
-----------------------------------------------------------
Review request for Ambari and Robert Nettleton.
Bugs: AMBARI-10750
https://issues.apache.org/jira/browse/AMBARI-10750
Repository: ambari
Description
-------
After my merge of AMBARI-10750, blueprint configuration validation fails if any hostgroup contains a component for a service which has password properties in the stack.
This is because in one code path the config property type didn't have the ".xml" extension stripped off.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java 82d03fd
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/33590/diff/
Testing
-------
Functional Testing:
- tested blueprint validation with customer blueprint
- tested creating cluster via blueprint
Unit Tests
- added new unit test
- full unit tests in progress, will post results prior to merging
Thanks,
John Speidel
Re: Review Request 33590: Blueprint configuration validation fails
for all password properties
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33590/#review81700
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On April 27, 2015, 6 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33590/
> -----------------------------------------------------------
>
> (Updated April 27, 2015, 6 p.m.)
>
>
> Review request for Ambari and Robert Nettleton.
>
>
> Bugs: AMBARI-10750
> https://issues.apache.org/jira/browse/AMBARI-10750
>
>
> Repository: ambari
>
>
> Description
> -------
>
> After my merge of AMBARI-10750, blueprint configuration validation fails if any hostgroup contains a component for a service which has password properties in the stack.
> This is because in one code path the config property type didn't have the ".xml" extension stripped off.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java 82d03fd
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33590/diff/
>
>
> Testing
> -------
>
> Functional Testing:
> - tested blueprint validation with customer blueprint
> - tested creating cluster via blueprint
>
> Unit Tests
> - added new unit test
> - full unit tests in progress, will post results prior to merging
>
>
> Thanks,
>
> John Speidel
>
>