[GitHub] [inlong] healchow commented on a diff in pull request #6524: [INLONG-6517][Manager] Support delete stream sink when the inlong group was config_failed

[GitBox <gi...@apache.org>]

healchow commented on code in PR #6524:
URL: https://github.com/apache/inlong/pull/6524#discussion_r1021129804


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -435,7 +435,7 @@ public InlongGroupInfo doDeleteCheck(String groupId, String operator) {
 
         // If the status allowed logic delete, all associated info will be logically deleted.
         // In other status, you need to delete the related "inlong_stream" first.
-        if (!GroupStatus.allowedLogicDelete(curState)) {
+        if (!GroupStatus.notAllowedDelete(curState)) {
             int count = streamService.selectCountByGroupId(groupId);

Review Comment:
   When the inlong group supports the delete operate, we should check whether there are undeleted streams.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org