You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/01/10 14:22:52 UTC

[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20745: Optimize 'take' operator for CPU

bartekkuncer commented on a change in pull request #20745:
URL: https://github.com/apache/incubator-mxnet/pull/20745#discussion_r781233000



##########
File path: src/operator/tensor/indexing_op.h
##########
@@ -215,8 +215,9 @@ inline bool EmbeddingOpBackwardStorageType(const nnvm::NodeAttrs& attrs,
   return dispatched;
 }
 
-/*! \brief name the struct TakeNonzeroAxis for general take when
- *         axis is not zero, use TakeZeroAxisGPU or TakeZeroAxisCPU for axis zero
+/*! \brief TakeNonzeroAxis is desinated for general take when

Review comment:
       ```suggestion
   /*! \brief TakeNonzeroAxis is designated for general take when
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org