You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Sean Flatley (JIRA)" <ji...@apache.org> on 2010/09/09 22:17:33 UTC
[jira] Created: (HIVE-1625) Added implementation to
HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
Added implementation to HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
----------------------------------------------------------------------------------------
Key: HIVE-1625
URL: https://issues.apache.org/jira/browse/HIVE-1625
Project: Hadoop Hive
Issue Type: Improvement
Reporter: Sean Flatley
Assignee: Sean Flatley
We implemented several of the HivePreparedStatement set methods, such as setString(int, String) and the means to substitute place holders in the SQL with the values set.
HiveQueryResultSet and HiveBaseResultSet were enhanced so that getStatement() could be implemented.
See attached change log for details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1625) Added implementation to
HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910263#action_12910263 ]
HBase Review Board commented on HIVE-1625:
------------------------------------------
Message from: "John Sichi" <js...@facebook.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/827/#review1246
-----------------------------------------------------------
http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveParameterValue.java
<http://review.cloudera.org/r/827/#comment4208>
These data members should be private.
http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java
<http://review.cloudera.org/r/827/#comment4209>
What is the purpose of typeMatches?
- John
> Added implementation to HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
> ----------------------------------------------------------------------------------------
>
> Key: HIVE-1625
> URL: https://issues.apache.org/jira/browse/HIVE-1625
> Project: Hadoop Hive
> Issue Type: Improvement
> Reporter: Sean Flatley
> Assignee: Sean Flatley
> Attachments: changelog.txt, HIVE-1625.patch, testJdbcDriver.log
>
>
> We implemented several of the HivePreparedStatement set methods, such as setString(int, String) and the means to substitute place holders in the SQL with the values set.
> HiveQueryResultSet and HiveBaseResultSet were enhanced so that getStatement() could be implemented.
> See attached change log for details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1625) Added implementation to
HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909040#action_12909040 ]
John Sichi commented on HIVE-1625:
----------------------------------
Added some initial comments at
https://review.cloudera.org/r/827/
Will have more later.
> Added implementation to HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
> ----------------------------------------------------------------------------------------
>
> Key: HIVE-1625
> URL: https://issues.apache.org/jira/browse/HIVE-1625
> Project: Hadoop Hive
> Issue Type: Improvement
> Reporter: Sean Flatley
> Assignee: Sean Flatley
> Attachments: changelog.txt, HIVE-1625.patch, testJdbcDriver.log
>
>
> We implemented several of the HivePreparedStatement set methods, such as setString(int, String) and the means to substitute place holders in the SQL with the values set.
> HiveQueryResultSet and HiveBaseResultSet were enhanced so that getStatement() could be implemented.
> See attached change log for details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1625) Added implementation to
HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
Posted by "Sean Flatley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Flatley updated HIVE-1625:
-------------------------------
Status: Patch Available (was: Open)
Release Note:
We implemented several HivePreparedStatement methods for setting parameters. The class also builds sql based on the parameters. The classes' setNull methods have been implemented as well.
Requesting a contribution code review.
Our unit tests check to see if the "built" sql from the parameter values are correct. We have experienced problems with "where" clauses in prepared statements that are run against the standalone database used in the unit tests. We have not experience this problem when running the JDBC driver with our products against our development Hive server.
I will browse Jira for a case on this. If not found I will create a reproduction path and create an issue.
> Added implementation to HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
> ----------------------------------------------------------------------------------------
>
> Key: HIVE-1625
> URL: https://issues.apache.org/jira/browse/HIVE-1625
> Project: Hadoop Hive
> Issue Type: Improvement
> Reporter: Sean Flatley
> Assignee: Sean Flatley
> Attachments: changelog.txt, HIVE-1625.patch, testJdbcDriver.log
>
>
> We implemented several of the HivePreparedStatement set methods, such as setString(int, String) and the means to substitute place holders in the SQL with the values set.
> HiveQueryResultSet and HiveBaseResultSet were enhanced so that getStatement() could be implemented.
> See attached change log for details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1625) Added implementation to
HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-1625:
-----------------------------
Status: Open (was: Patch Available)
> Added implementation to HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
> ----------------------------------------------------------------------------------------
>
> Key: HIVE-1625
> URL: https://issues.apache.org/jira/browse/HIVE-1625
> Project: Hadoop Hive
> Issue Type: Improvement
> Reporter: Sean Flatley
> Assignee: Sean Flatley
> Attachments: changelog.txt, HIVE-1625.patch, testJdbcDriver.log
>
>
> We implemented several of the HivePreparedStatement set methods, such as setString(int, String) and the means to substitute place holders in the SQL with the values set.
> HiveQueryResultSet and HiveBaseResultSet were enhanced so that getStatement() could be implemented.
> See attached change log for details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1625) Added implementation to
HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
Posted by "Sean Flatley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Flatley updated HIVE-1625:
-------------------------------
Attachment: HIVE-1625.patch
Patch.
> Added implementation to HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
> ----------------------------------------------------------------------------------------
>
> Key: HIVE-1625
> URL: https://issues.apache.org/jira/browse/HIVE-1625
> Project: Hadoop Hive
> Issue Type: Improvement
> Reporter: Sean Flatley
> Assignee: Sean Flatley
> Attachments: changelog.txt, HIVE-1625.patch, testJdbcDriver.log
>
>
> We implemented several of the HivePreparedStatement set methods, such as setString(int, String) and the means to substitute place holders in the SQL with the values set.
> HiveQueryResultSet and HiveBaseResultSet were enhanced so that getStatement() could be implemented.
> See attached change log for details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1625) Added implementation to
HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909046#action_12909046 ]
HBase Review Board commented on HIVE-1625:
------------------------------------------
Message from: "John Sichi" <js...@facebook.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/827/
-----------------------------------------------------------
Review request for Hive Developers.
Summary
-------
review by JVS
This addresses bug HIVE-1625.
http://issues.apache.org/jira/browse/HIVE-1625
Diffs
-----
http://svn.apache.org/repos/asf/hadoop/hive/trunk/data/files/pstmt.txt PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java 995557
http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveCallableStatement.java 995557
http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDatabaseMetaData.java 995557
http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveParameterValue.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java 995557
http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java 995557
http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveStatement.java 995557
http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/MockHiveConnection.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/MockHivePreparedStatement.java PRE-CREATION
http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 995557
Diff: http://review.cloudera.org/r/827/diff
Testing
-------
Thanks,
John
> Added implementation to HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
> ----------------------------------------------------------------------------------------
>
> Key: HIVE-1625
> URL: https://issues.apache.org/jira/browse/HIVE-1625
> Project: Hadoop Hive
> Issue Type: Improvement
> Reporter: Sean Flatley
> Assignee: Sean Flatley
> Attachments: changelog.txt, HIVE-1625.patch, testJdbcDriver.log
>
>
> We implemented several of the HivePreparedStatement set methods, such as setString(int, String) and the means to substitute place holders in the SQL with the values set.
> HiveQueryResultSet and HiveBaseResultSet were enhanced so that getStatement() could be implemented.
> See attached change log for details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1625) Added implementation to
HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
Posted by "Sean Flatley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Flatley updated HIVE-1625:
-------------------------------
Attachment: changelog.txt
testJdbcDriver.log
Change log and test log file.
> Added implementation to HivePreparedStatement, HiveBaseResultSet and HiveQueryResultSet.
> ----------------------------------------------------------------------------------------
>
> Key: HIVE-1625
> URL: https://issues.apache.org/jira/browse/HIVE-1625
> Project: Hadoop Hive
> Issue Type: Improvement
> Reporter: Sean Flatley
> Assignee: Sean Flatley
> Attachments: changelog.txt, testJdbcDriver.log
>
>
> We implemented several of the HivePreparedStatement set methods, such as setString(int, String) and the means to substitute place holders in the SQL with the values set.
> HiveQueryResultSet and HiveBaseResultSet were enhanced so that getStatement() could be implemented.
> See attached change log for details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.