[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5425: feat: FlinkSink support dynamically changed schema

[GitBox <gi...@apache.org>]

stevenzwu commented on code in PR #5425:
URL: https://github.com/apache/iceberg/pull/5425#discussion_r940874312


##########
flink/v1.13/flink/src/main/java/org/apache/iceberg/flink/data/FlinkOrcWriters.java:
##########
@@ -303,6 +303,9 @@ static class RowDataWriter extends GenericOrcWriters.StructWriter<RowData> {
 
     @Override
     protected Object get(RowData struct, int index) {
+      if (index >= struct.getArity()) {

Review Comment:
   this assumes schema change only has new fields added in the end. There should be validation during schema refresh and only apply the refresh it satisfy the compatibility rules.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org