You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Zsombor Gegesy <gz...@gmail.com> on 2017/04/02 20:08:08 UTC
Re: Review Request 56887: [RANGER-1377] code cleanup in the security
admin module - fix string comparisons
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56887/
-----------------------------------------------------------
(Updated April 2, 2017, 8:08 p.m.)
Review request for ranger.
Changes
-------
Updated patch
Bugs: RANGER-1377
https://issues.apache.org/jira/browse/RANGER-1377
Repository: ranger
Description
-------
Fix code to use "xxx".equals(yyy) instead of yyy.equals("xxx")
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 9244cd6
security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java 924aaa9
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java cceb380
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 2a9c003
security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java f2b8f99
security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java 0122e6b
security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 3542da2
security-admin/src/main/java/org/apache/ranger/common/AppConstants.java 39d28a1
security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 22d4b89
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java c6be50e
security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java 00935f3
security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java 0723ee9
security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 7f471b0
security-admin/src/main/java/org/apache/ranger/common/StringUtil.java aab8669
security-admin/src/main/java/org/apache/ranger/db/RangerDaoManager.java e3b878b
security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java d718441
security-admin/src/main/java/org/apache/ranger/entity/XXAccessAuditBase.java 8efcfc3
security-admin/src/main/java/org/apache/ranger/entity/XXAsset.java 158c966
security-admin/src/main/java/org/apache/ranger/entity/XXAuditMap.java 95c2bf6
security-admin/src/main/java/org/apache/ranger/entity/XXAuthSession.java deedc87
security-admin/src/main/java/org/apache/ranger/entity/XXGroup.java 04aedbd
security-admin/src/main/java/org/apache/ranger/entity/XXPermMap.java 7c6b96c
security-admin/src/main/java/org/apache/ranger/entity/XXPortalUser.java f7df09e
security-admin/src/main/java/org/apache/ranger/entity/XXPortalUserRole.java 97f52c4
security-admin/src/main/java/org/apache/ranger/entity/XXResource.java e571a4f
security-admin/src/main/java/org/apache/ranger/entity/XXTrxLog.java ceea47b
security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 512c567
security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 1ddd367
security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 3fe34be
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 6176319
security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 3fdd5c2
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 8d9363a
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java 948d328
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java e7e5f5d
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java c8d22aa
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java dbf6248
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 7d8fdb2
security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 9a4aa3b
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 00c08db
security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java c666a1c
security-admin/src/main/java/org/apache/ranger/service/XAssetService.java 81c720d
security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java 1dfe19f
security-admin/src/main/java/org/apache/ranger/service/XGroupService.java c478dbc
security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 0d735da
security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java bc335cc
security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java bb12e3e
security-admin/src/main/java/org/apache/ranger/service/XResourceService.java fee7101
security-admin/src/main/java/org/apache/ranger/service/XUserService.java e8fef7a
security-admin/src/main/java/org/apache/ranger/service/filter/RangerRESTAPIFilter.java 5b78925
security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java 3f7935e
security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 85f420d
security-admin/src/main/java/org/apache/ranger/util/RestUtil.java b50d161
Diff: https://reviews.apache.org/r/56887/diff/2/
Changes: https://reviews.apache.org/r/56887/diff/1-2/
Testing
-------
Thanks,
Zsombor Gegesy
Re: Review Request 56887: [RANGER-1377] code cleanup in the security
admin module - fix string comparisons
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56887/#review172327
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 2, 2017, 8:08 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56887/
> -----------------------------------------------------------
>
> (Updated April 2, 2017, 8:08 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1377
> https://issues.apache.org/jira/browse/RANGER-1377
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fix code to use "xxx".equals(yyy) instead of yyy.equals("xxx")
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 9244cd6
> security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java 924aaa9
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java cceb380
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 2a9c003
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java f2b8f99
> security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java 0122e6b
> security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 3542da2
> security-admin/src/main/java/org/apache/ranger/common/AppConstants.java 39d28a1
> security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java 22d4b89
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java c6be50e
> security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java 00935f3
> security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java 0723ee9
> security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 7f471b0
> security-admin/src/main/java/org/apache/ranger/common/StringUtil.java aab8669
> security-admin/src/main/java/org/apache/ranger/db/RangerDaoManager.java e3b878b
> security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java d718441
> security-admin/src/main/java/org/apache/ranger/entity/XXAccessAuditBase.java 8efcfc3
> security-admin/src/main/java/org/apache/ranger/entity/XXAsset.java 158c966
> security-admin/src/main/java/org/apache/ranger/entity/XXAuditMap.java 95c2bf6
> security-admin/src/main/java/org/apache/ranger/entity/XXAuthSession.java deedc87
> security-admin/src/main/java/org/apache/ranger/entity/XXGroup.java 04aedbd
> security-admin/src/main/java/org/apache/ranger/entity/XXPermMap.java 7c6b96c
> security-admin/src/main/java/org/apache/ranger/entity/XXPortalUser.java f7df09e
> security-admin/src/main/java/org/apache/ranger/entity/XXPortalUserRole.java 97f52c4
> security-admin/src/main/java/org/apache/ranger/entity/XXResource.java e571a4f
> security-admin/src/main/java/org/apache/ranger/entity/XXTrxLog.java ceea47b
> security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 512c567
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 1ddd367
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 3fe34be
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 6176319
> security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java 3fdd5c2
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 8d9363a
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java 948d328
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java e7e5f5d
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java c8d22aa
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java dbf6248
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java 7d8fdb2
> security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 9a4aa3b
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 00c08db
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java c666a1c
> security-admin/src/main/java/org/apache/ranger/service/XAssetService.java 81c720d
> security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java 1dfe19f
> security-admin/src/main/java/org/apache/ranger/service/XGroupService.java c478dbc
> security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 0d735da
> security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java bc335cc
> security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java bb12e3e
> security-admin/src/main/java/org/apache/ranger/service/XResourceService.java fee7101
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java e8fef7a
> security-admin/src/main/java/org/apache/ranger/service/filter/RangerRESTAPIFilter.java 5b78925
> security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java 3f7935e
> security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 85f420d
> security-admin/src/main/java/org/apache/ranger/util/RestUtil.java b50d161
>
>
> Diff: https://reviews.apache.org/r/56887/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zsombor Gegesy
>
>