You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/22 05:49:03 UTC

[GitHub] [shardingsphere] menghaoranss commented on a diff in pull request #18473: Add query route primary data source when replica all offline.

menghaoranss commented on code in PR #18473:
URL: https://github.com/apache/shardingsphere/pull/18473#discussion_r903305194


##########
shardingsphere-features/shardingsphere-readwrite-splitting/shardingsphere-readwrite-splitting-core/src/main/java/org/apache/shardingsphere/readwritesplitting/route/impl/ReadwriteSplittingDataSourceRouter.java:
##########
@@ -68,4 +69,9 @@ private boolean containsLastInsertIdProjection(final SQLStatementContext<?> sqlS
     private boolean isHintWriteRouteOnly(final SQLStatementContext<?> sqlStatementContext) {
         return HintManager.isWriteRouteOnly() || (sqlStatementContext instanceof CommonSQLStatementContext && ((CommonSQLStatementContext<?>) sqlStatementContext).isHintWriteRouteOnly());
     }
+    
+    private boolean isAllowWriteDatasourceQuery() {

Review Comment:
   Datasource should be DataSource



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org