[GitHub] [geode] albertogpz commented on pull request #7108: GEODE-9807: gfsh gateway sender stop in parallel (like start)

[GitBox <gi...@apache.org>]

albertogpz commented on pull request #7108:
URL: https://github.com/apache/geode/pull/7108#issuecomment-998973289


   > Normally the command classes are stateless, we don't usually have member variables for command classes. I guess I don't quite understand why you would want to have a delegate class to do all the work instead, why can't you just do all the work inside the command class, like every other command is doing? I hate to introduce another pattern for commands for no obvious reasons.
   
   @jinmeiliao I have removed the delegate class. I agree with you, it is not needed. Regarding member variables, the ones added correspond to the dependencies that can be passed in the constructor to be able to unit test the class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org