You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/02 02:56:34 UTC
[GitHub] [apisix-dashboard] Jaycean opened a new issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Jaycean opened a new issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415
# Feature request
## Please describe your feature
At present, the Dockfile and Dockerfile-apisix in the dashboard are maintained locally. Two days ago, the relevant dependencies of apimix were modified. The dashboard failed to synchronize in time, resulting in CI errors. So I think we have APISIXdocker project. Can we pull the Dockerfile from this project? This will not cause synchronization errors
## Describe the solution you'd like
Before executing the `docker-compose -d` command, CI uses `curl -o` to pull Dockerfile and Dockerfile-apisix files to the local dashboard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771430134
> docker-compose supports using context to load Dockerfile from remote git repository.
Good to know this tip!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771382631
@nic-chen
Thks.
Then I'll submit a PR to modify Dockerfile-apisix later.
Please assigne to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771370909
ping @nic-chen @starsz @imjoey
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771527302
> > @nic-chen
> > Thks.
> > Then I'll submit a PR to modify Dockerfile-apisix later.
> > Please assigne to me.
>
> @Jaycean Regarding to the implementation, AFAIK, docker-compose supports using `context` to load Dockerfile from remote git repository. Take apisix for example, you could try without pulling the Dockerfile to local.
>
> ```
> apisix:
> hostname: apisix_server1
> build:
> context: https://github.com/apache/apisix-docker.git#master:all-in-one/apisix/
> dockerfile: Dockerfile
> args:
> - APISIX_VERSION=master
> ```
Cool, it's a good way. I like it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771370909
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771377570
@imjoey
There are two Dockerfiles in `apisix-dashborad`. One is used to build the `manage-api`, and the other is used to build `apisix`.
`Apisix-docker` project includes the construction of `apisix` Dockerfile through various operating systems, and the construction of `manage-api` and `apisix` Dockerfile through `All-in-one`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771372034
@Jaycean thanks for reporting. It's reasonable for me. Could you please introduce us the differences of the two Dockerfiles in this project and apisix-docker project? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean closed issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
Jaycean closed issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771430134
> docker-compose supports using context to load Dockerfile from remote git repository.
Good to know this tip!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-772268595
PR has been merged. This issue is closed. If there is a problem, it will be reopened later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771527302
> > @nic-chen
> > Thks.
> > Then I'll submit a PR to modify Dockerfile-apisix later.
> > Please assigne to me.
>
> @Jaycean Regarding to the implementation, AFAIK, docker-compose supports using `context` to load Dockerfile from remote git repository. Take apisix for example, you could try without pulling the Dockerfile to local.
>
> ```
> apisix:
> hostname: apisix_server1
> build:
> context: https://github.com/apache/apisix-docker.git#master:all-in-one/apisix/
> dockerfile: Dockerfile
> args:
> - APISIX_VERSION=master
> ```
Cool, it's a good way. I like it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771372034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771414595
> @nic-chen
> Thks.
> Then I'll submit a PR to modify Dockerfile-apisix later.
> Please assigne to me.
@Jaycean Regarding to the implementation, AFAIK, docker-compose supports using `context` to load Dockerfile from remote git repository. Take apisix for example, you could try without pulling the Dockerfile to local.
```
apisix:
hostname: apisix_server1
build:
context: https://github.com/apache/apisix-docker.git#master:all-in-one/apisix/
dockerfile: Dockerfile
args:
- APISIX_VERSION=master
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771375501
hi @Jaycean
Thanks.
`Dockerfile-apisix` can be used directly in this way, but `Dockerfile-dashborad` requires an additional modification, which is to use the local source code instead of downloading it from github, because we need to run the latest code to verify the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1415: feat: Using Dockerfile of apisix-docker project to build E2E test image
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771375501
hi @Jaycean
Thanks.
`Dockerfile-apisix` can be used directly in this way, but `Dockerfile-dashborad` requires an additional modification, which is to use the local source code instead of downloading it from github, because we need to run the latest code to verify the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org