You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2022/07/04 12:03:09 UTC
[Bug 66157] New: Code Textbox Text Colour
https://bz.apache.org/bugzilla/show_bug.cgi?id=66157
Bug ID: 66157
Summary: Code Textbox Text Colour
Product: JMeter
Version: 5.5
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: Main
Assignee: issues@jmeter.apache.org
Reporter: nathan88wise@gmail.com
Target Milestone: JMETER_5.5
Created attachment 38333
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38333&action=edit
JSR223 Textbox input with Darcula
When you use any theme, the default text colour (black) is there no matter the
theme. If you use a dark theme - it becomes a nightmare to read the text. It's
also quite hard to read the other coloured text.
The current solution we're using it to downgrade all of the DarkLAF jars to
v2.4.8 as suggested by this Stack Overflow post:
https://stackoverflow.com/questions/67430501/jmeter-change-font-colour/68407296#68407296
It would be nice if we didn't have to do this.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 66157] Code Textbox Text Colour
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66157
--- Comment #7 from Brian Tully <br...@acquia.com> ---
I had posted several related bugs related to Darklaf and dark themes, where
textareas were unreadable due to the dark text against a dark background. In my
bug reports I was referring to the textareas within View Results Tree that use
syntax coloring (e.g., request headers, response headers, etc).
https://bz.apache.org/bugzilla/show_bug.cgi?id=64224
https://bz.apache.org/bugzilla/show_bug.cgi?id=65187
I also filed a bug within the Darkflaf project at
https://github.com/weisJ/darklaf/issues/328 where Jannis was kind enough to
point me to
https://github.com/apache/jmeter/commit/b914b713640ffd88b935786d13c0acce51b04259
which lead me to this bug report.
I am hoping that this really fixes the issue so that I can finally upgrade from
JMeter 5.2.1.
I will also try testing the trunk build to make sure it's also working for me
on my Mac. I know this bug is listed as resolved/closed, but I'll report back
with my results and reopen if needed.
Thanks!
Brian
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 66157] Code Textbox Text Colour
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66157
--- Comment #4 from Felix Schumacher <fe...@internetallee.de> ---
Created attachment 38336
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38336&action=edit
How it looks in my machine with current trunk
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 66157] Code Textbox Text Colour
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66157
Felix Schumacher <fe...@internetallee.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 66157] Code Textbox Text Colour
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66157
--- Comment #3 from nathan88wise@gmail.com ---
Just tried the latest one (r236-7548000b1f1dc6708e2186afa721df71057b8082) and
it looked the exact same to me - not sure if this one has your fix in it
though.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 66157] Code Textbox Text Colour
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66157
--- Comment #8 from Brian Tully <br...@acquia.com> ---
I'm confirming that it is fixed for me as well, on my Mac, with the latest
trunk build.
Is there any way to use the same rsyntaxtextarea class for the Response Body
textarea within View Results Tree? Right now it just shows as plain text in
sans-serif font, which is not exactly helpful when debugging.
I've updated my old bug at https://bz.apache.org/bugzilla/show_bug.cgi?id=65187
to see if that enhancement might be doable now that Darklaf and rsyntaxtextarea
is fixed in trunk :)
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 66157] Code Textbox Text Colour
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66157
--- Comment #5 from Felix Schumacher <fe...@internetallee.de> ---
Maybe the nightly has not catched up with trunk. Could you try the builds from
trunk:
https://ci-builds.apache.org/job/JMeter/job/JMeter-trunk/lastSuccessfulBuild/artifact/src/dist/build/distributions/
?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 66157] Code Textbox Text Colour
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66157
Felix Schumacher <fe...@internetallee.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
OS| |All
--- Comment #1 from Felix Schumacher <fe...@internetallee.de> ---
Thanks for the report. I opened https://github.com/apache/jmeter/pull/719 with
a fix.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 66157] Code Textbox Text Colour
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66157
--- Comment #6 from nathan88wise@gmail.com ---
Tried the trunk build and messed around with some other elements in a test
plan.
Looks good to me!
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 66157] Code Textbox Text Colour
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66157
Felix Schumacher <fe...@internetallee.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
Keywords| |FixedInTrunk
--- Comment #2 from Felix Schumacher <fe...@internetallee.de> ---
@Nathan, can you check next nightly and report back, if this is fixed?
commit b914b713640ffd88b935786d13c0acce51b04259
AuthorDate: Tue Jul 5 16:16:38 2022 +0200
Correct theme for darklaf on rsyntaxtextarea
The id of the theme has been changed to all lowercase
Bugzilla Id: 66517
Closes #719
---
.../src/main/java/org/apache/jmeter/gui/action/LookAndFeelCommand.java | 2 +-
xdocs/changes.xml | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--
You are receiving this mail because:
You are the assignee for the bug.