You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/22 11:40:25 UTC
[GitHub] [airflow] turbaszek opened a new pull request #13250: Fix link to Apache Airflow docs in webserver
turbaszek opened a new pull request #13250:
URL: https://github.com/apache/airflow/pull/13250
Current link returns 404
https://airflow.apache.org/docs/apache-airflow/2.0.0
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13250: Fix link to Apache Airflow docs in webserver
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13250:
URL: https://github.com/apache/airflow/pull/13250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13250: Fix link to Apache Airflow docs in webserver
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13250:
URL: https://github.com/apache/airflow/pull/13250#discussion_r547238129
##########
File path: tests/utils/test_docs.py
##########
@@ -34,14 +35,20 @@ class TestGetDocsUrl(unittest.TestCase):
),
(
'2.0.0.dev0',
- 'migration.html',
+ 'tutorial.html',
'http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/'
- 'apache-airflow/latest/migration.html',
+ 'apache-airflow/latest/tutorial.html',
+ ),
+ ('1.10.10', None, 'https://airflow.apache.org/docs/apache-airflow/1.10.10/'),
+ (
+ '1.10.10',
+ 'tutorial.html',
+ 'https://airflow.apache.org/docs/apache-airflow/1.10.10/tutorial.html',
),
- ('1.10.0', None, 'https://airflow.apache.org/docs/1.10.0/'),
- ('1.10.0', 'migration.html', 'https://airflow.apache.org/docs/1.10.0/migration.html'),
]
)
- def test_should_return_link(self, version, page, expected_urk):
+ def test_should_return_link(self, version, page, expected_url):
with mock.patch('airflow.version.version', version):
- self.assertEqual(expected_urk, get_docs_url(page))
+ self.assertEqual(expected_url, get_docs_url(page))
+ resp = requests.get(expected_url)
+ assert resp.status_code == 200
Review comment:
Not sure about sending requests (in general it's not best practice) but I don't know other way to make sure what we use works - without this the test gives false positives.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13250: Fix link to Apache Airflow docs in webserver
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13250:
URL: https://github.com/apache/airflow/pull/13250#discussion_r553842692
##########
File path: tests/utils/test_docs.py
##########
@@ -34,14 +35,20 @@ class TestGetDocsUrl(unittest.TestCase):
),
(
'2.0.0.dev0',
- 'migration.html',
+ 'tutorial.html',
'http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/'
- 'apache-airflow/latest/migration.html',
+ 'apache-airflow/latest/tutorial.html',
+ ),
+ ('1.10.10', None, 'https://airflow.apache.org/docs/apache-airflow/1.10.10/'),
+ (
+ '1.10.10',
+ 'tutorial.html',
+ 'https://airflow.apache.org/docs/apache-airflow/1.10.10/tutorial.html',
),
- ('1.10.0', None, 'https://airflow.apache.org/docs/1.10.0/'),
- ('1.10.0', 'migration.html', 'https://airflow.apache.org/docs/1.10.0/migration.html'),
]
)
- def test_should_return_link(self, version, page, expected_urk):
+ def test_should_return_link(self, version, page, expected_url):
with mock.patch('airflow.version.version', version):
- self.assertEqual(expected_urk, get_docs_url(page))
+ self.assertEqual(expected_url, get_docs_url(page))
+ resp = requests.get(expected_url)
+ assert resp.status_code == 200
Review comment:
It seems fine in this case, but we can speed up this code a bit if we use HEAD requests.
##########
File path: tests/utils/test_docs.py
##########
@@ -34,14 +35,20 @@ class TestGetDocsUrl(unittest.TestCase):
),
(
'2.0.0.dev0',
- 'migration.html',
+ 'tutorial.html',
'http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/'
- 'apache-airflow/latest/migration.html',
+ 'apache-airflow/latest/tutorial.html',
+ ),
+ ('1.10.10', None, 'https://airflow.apache.org/docs/apache-airflow/1.10.10/'),
+ (
+ '1.10.10',
+ 'tutorial.html',
+ 'https://airflow.apache.org/docs/apache-airflow/1.10.10/tutorial.html',
),
- ('1.10.0', None, 'https://airflow.apache.org/docs/1.10.0/'),
- ('1.10.0', 'migration.html', 'https://airflow.apache.org/docs/1.10.0/migration.html'),
]
)
- def test_should_return_link(self, version, page, expected_urk):
+ def test_should_return_link(self, version, page, expected_url):
with mock.patch('airflow.version.version', version):
- self.assertEqual(expected_urk, get_docs_url(page))
+ self.assertEqual(expected_url, get_docs_url(page))
+ resp = requests.get(expected_url)
Review comment:
```suggestion
resp = requests.head(expected_url)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13250: Fix link to Apache Airflow docs in webserver
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13250:
URL: https://github.com/apache/airflow/pull/13250#issuecomment-758732861
[The Workflow run](https://github.com/apache/airflow/actions/runs/480342026) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13250: Fix link to Apache Airflow docs in webserver
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13250:
URL: https://github.com/apache/airflow/pull/13250#issuecomment-763183551
Conflicting files here @turbaszek
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13250: Fix link to Apache Airflow docs in webserver
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13250:
URL: https://github.com/apache/airflow/pull/13250#discussion_r553842692
##########
File path: tests/utils/test_docs.py
##########
@@ -34,14 +35,20 @@ class TestGetDocsUrl(unittest.TestCase):
),
(
'2.0.0.dev0',
- 'migration.html',
+ 'tutorial.html',
'http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/'
- 'apache-airflow/latest/migration.html',
+ 'apache-airflow/latest/tutorial.html',
+ ),
+ ('1.10.10', None, 'https://airflow.apache.org/docs/apache-airflow/1.10.10/'),
+ (
+ '1.10.10',
+ 'tutorial.html',
+ 'https://airflow.apache.org/docs/apache-airflow/1.10.10/tutorial.html',
),
- ('1.10.0', None, 'https://airflow.apache.org/docs/1.10.0/'),
- ('1.10.0', 'migration.html', 'https://airflow.apache.org/docs/1.10.0/migration.html'),
]
)
- def test_should_return_link(self, version, page, expected_urk):
+ def test_should_return_link(self, version, page, expected_url):
with mock.patch('airflow.version.version', version):
- self.assertEqual(expected_urk, get_docs_url(page))
+ self.assertEqual(expected_url, get_docs_url(page))
+ resp = requests.get(expected_url)
+ assert resp.status_code == 200
Review comment:
It seems fine in this case, but we can speed up this code a bit if we use HEAD requests.
##########
File path: tests/utils/test_docs.py
##########
@@ -34,14 +35,20 @@ class TestGetDocsUrl(unittest.TestCase):
),
(
'2.0.0.dev0',
- 'migration.html',
+ 'tutorial.html',
'http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/'
- 'apache-airflow/latest/migration.html',
+ 'apache-airflow/latest/tutorial.html',
+ ),
+ ('1.10.10', None, 'https://airflow.apache.org/docs/apache-airflow/1.10.10/'),
+ (
+ '1.10.10',
+ 'tutorial.html',
+ 'https://airflow.apache.org/docs/apache-airflow/1.10.10/tutorial.html',
),
- ('1.10.0', None, 'https://airflow.apache.org/docs/1.10.0/'),
- ('1.10.0', 'migration.html', 'https://airflow.apache.org/docs/1.10.0/migration.html'),
]
)
- def test_should_return_link(self, version, page, expected_urk):
+ def test_should_return_link(self, version, page, expected_url):
with mock.patch('airflow.version.version', version):
- self.assertEqual(expected_urk, get_docs_url(page))
+ self.assertEqual(expected_url, get_docs_url(page))
+ resp = requests.get(expected_url)
Review comment:
```suggestion
resp = requests.head(expected_url)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13250: Fix link to Apache Airflow docs in webserver
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13250:
URL: https://github.com/apache/airflow/pull/13250#issuecomment-755731218
> @kaxil should we mark it as 2.0.1?
Yup, just marked
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13250: Fix link to Apache Airflow docs in webserver
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13250:
URL: https://github.com/apache/airflow/pull/13250#issuecomment-765921818
[The Workflow run](https://github.com/apache/airflow/actions/runs/505711712) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #13250: Fix link to Apache Airflow docs in webserver
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #13250:
URL: https://github.com/apache/airflow/pull/13250#issuecomment-755588920
@kaxil should we mark it as 2.0.1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13250: Fix link to Apache Airflow docs in webserver
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13250:
URL: https://github.com/apache/airflow/pull/13250#issuecomment-749538850
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13250: Fix link to Apache Airflow docs in webserver
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13250:
URL: https://github.com/apache/airflow/pull/13250#issuecomment-766289651
The problems were temporary due to wrongly generated constraints (they were there generated from python3.8 in python 3.6 for about an hour by my mistake)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13250: Fix link to Apache Airflow docs in webserver
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13250:
URL: https://github.com/apache/airflow/pull/13250#discussion_r547238129
##########
File path: tests/utils/test_docs.py
##########
@@ -34,14 +35,20 @@ class TestGetDocsUrl(unittest.TestCase):
),
(
'2.0.0.dev0',
- 'migration.html',
+ 'tutorial.html',
'http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/'
- 'apache-airflow/latest/migration.html',
+ 'apache-airflow/latest/tutorial.html',
+ ),
+ ('1.10.10', None, 'https://airflow.apache.org/docs/apache-airflow/1.10.10/'),
+ (
+ '1.10.10',
+ 'tutorial.html',
+ 'https://airflow.apache.org/docs/apache-airflow/1.10.10/tutorial.html',
),
- ('1.10.0', None, 'https://airflow.apache.org/docs/1.10.0/'),
- ('1.10.0', 'migration.html', 'https://airflow.apache.org/docs/1.10.0/migration.html'),
]
)
- def test_should_return_link(self, version, page, expected_urk):
+ def test_should_return_link(self, version, page, expected_url):
with mock.patch('airflow.version.version', version):
- self.assertEqual(expected_urk, get_docs_url(page))
+ self.assertEqual(expected_url, get_docs_url(page))
+ resp = requests.get(expected_url)
+ assert resp.status_code == 200
Review comment:
Not sure about sending requests (in general it's not best practice) but I don't know other way to make usre what we use works - without this the test gives false positives.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13250: Fix link to Apache Airflow docs in webserver
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13250:
URL: https://github.com/apache/airflow/pull/13250#issuecomment-758626409
[The Workflow run](https://github.com/apache/airflow/actions/runs/479894368) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org