[jira] [Updated] (CASSANDRA-21626) CEP-45: Migration repair streams can write live SSTables into pending// and lose them silently on restart

["Francisco Guerrero (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-21626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francisco Guerrero updated CASSANDRA-21626:
-------------------------------------------
     Bug Category: Parent values: Correctness(12982)Level 1 values: Unrecoverable Corruption / Loss(13161)
       Complexity: Normal
    Discovered By: User Report
         Severity: Normal
           Status: Open  (was: Triage Needed)

> CEP-45: Migration repair streams can write live SSTables into pending/<planId>/ and lose them silently on restart
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-21626
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21626
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Legacy/Streaming and Messaging
>            Reporter: Francisco Guerrero
>            Assignee: Francisco Guerrero
>            Priority: Normal
>
> During a mutation-tracking migration, some token ranges have already completed migration while others are still pending. {{KeyspaceMigrationInfo.shouldUseTrackedTransfers()}} is the single source of truth for which path a given set of ranges should use, and {{CassandraStreamReceiver.useTrackedTransferPath()}} wraps it correctly for the registration decision made in {{finished()}} (whether to hand received SSTables to {{MutationTrackingService.received()}} for coordinated activation, or add them directly via {{cfs.addSSTables()}}).
> However, we are not always using {{KeyspaceMigrationInfo.shouldUseTrackedTransfers()}} to determine the streaming write path on disk for the SSTable.
> Today, all streams for a keyspace that is migrating, get routed to the {{pending/<planId>/}} directory, even though {{finished()}} already correctly classified the stream as untracked, and it never registered a {{PendingLocalTransfer}} for it.
> Now, the issue is that the SSTable lands on the {{pending/<planId>}} directory without a durable pending-transfer record. The data is visible immediately after repair, so repair reports success and the migration appears complete. However, on node restart the pending directory recovery logic will discard the orphaned (untracked) pending directory, and the data silently disappears with no indication of what caused the data loss.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org