You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "uchenily (via GitHub)" <gi...@apache.org> on 2025/11/13 10:57:00 UTC
[PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
uchenily opened a new pull request, #57996:
URL: https://github.com/apache/doris/pull/57996
### What problem does this PR solve?
1. set eof flag based on _line_reader_eof rather than rows=0, to prevent unnecessary extra one call when reaching end of file during batch reading
2. refactor CsvReader::get_next_block extract _process_one_line method to reduce code duplication
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3540788743
<details>
<summary>TPC-H: <b>Total hot run time: 34699 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6f1008150c83d86de4c3e162abb4c622feff6249, data reload: false
------ Round 1 ----------------------------------
q1 17609 5157 5039 5039
q2 2037 316 209 209
q3 10220 1261 716 716
q4 10239 883 375 375
q5 7480 2490 2308 2308
q6 187 168 135 135
q7 939 744 630 630
q8 9364 1395 1162 1162
q9 6926 5063 5104 5063
q10 6821 2217 1816 1816
q11 512 297 280 280
q12 337 372 230 230
q13 17775 3668 3054 3054
q14 237 233 220 220
q15 567 511 507 507
q16 1002 1018 959 959
q17 590 870 361 361
q18 7695 7363 8116 7363
q19 1275 989 567 567
q20 363 364 237 237
q21 4418 3383 2414 2414
q22 1105 1085 1054 1054
Total cold run time: 107698 ms
Total hot run time: 34699 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5293 5322 5410 5322
q2 257 330 233 233
q3 2401 2901 2496 2496
q4 1476 1927 1445 1445
q5 4515 4441 4375 4375
q6 222 175 126 126
q7 2012 1852 1843 1843
q8 2618 2497 2520 2497
q9 7285 7356 7177 7177
q10 2997 3274 2888 2888
q11 568 540 481 481
q12 656 737 571 571
q13 3264 3646 3024 3024
q14 275 290 264 264
q15 531 494 473 473
q16 991 1042 1017 1017
q17 1102 1423 1356 1356
q18 7532 7084 7074 7074
q19 759 718 781 718
q20 1897 1944 1829 1829
q21 4892 4343 4253 4253
q22 1094 1047 992 992
Total cold run time: 52637 ms
Total hot run time: 50454 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3530598529
<details>
<summary>TPC-H: <b>Total hot run time: 33996 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fc4fb368cfc29609f330792732b61550c3c95bc7, data reload: false
------ Round 1 ----------------------------------
q1 17689 5168 4970 4970
q2 2351 300 201 201
q3 10138 1271 717 717
q4 10257 904 376 376
q5 7455 2299 2320 2299
q6 183 169 135 135
q7 893 761 627 627
q8 9333 1306 1020 1020
q9 6964 5121 5223 5121
q10 7118 2220 1837 1837
q11 515 307 296 296
q12 338 366 232 232
q13 17869 3640 3033 3033
q14 227 233 209 209
q15 595 510 507 507
q16 1019 991 948 948
q17 617 859 361 361
q18 7509 7072 7144 7072
q19 1226 927 555 555
q20 341 333 233 233
q21 3625 2553 2242 2242
q22 1078 1012 1005 1005
Total cold run time: 107340 ms
Total hot run time: 33996 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5107 5128 5071 5071
q2 251 328 237 237
q3 2159 2660 2352 2352
q4 1346 1758 1327 1327
q5 4190 4426 4527 4426
q6 228 174 133 133
q7 1993 1943 1864 1864
q8 2636 2653 2543 2543
q9 7422 7389 7348 7348
q10 3040 3204 2789 2789
q11 593 553 524 524
q12 722 779 597 597
q13 3525 4063 3315 3315
q14 296 312 301 301
q15 559 512 505 505
q16 1062 1133 1048 1048
q17 1170 1509 1374 1374
q18 7984 7662 7557 7557
q19 790 807 792 792
q20 1918 1960 1839 1839
q21 4714 4411 4272 4272
q22 1103 1019 1017 1017
Total cold run time: 52808 ms
Total hot run time: 51231 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "uchenily (via GitHub)" <gi...@apache.org>.
uchenily commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3568808390
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-4526939859
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #57996: [refine](csv reader) Set eof flag based on _line_reader_eof
URL: https://github.com/apache/doris/pull/57996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3527335017
<details>
<summary>TPC-H: <b>Total hot run time: 34266 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 744050cdbf3292e7865395d0d6a29b745e210151, data reload: false
------ Round 1 ----------------------------------
q1 17618 5155 4964 4964
q2 2019 315 207 207
q3 10250 1289 743 743
q4 10236 914 369 369
q5 7567 2423 2320 2320
q6 186 176 141 141
q7 921 779 642 642
q8 9365 1320 1037 1037
q9 6961 5087 5222 5087
q10 6829 2221 1834 1834
q11 500 314 294 294
q12 332 364 224 224
q13 17767 3698 3079 3079
q14 243 231 217 217
q15 567 517 498 498
q16 1022 1002 950 950
q17 583 861 356 356
q18 7441 7216 7216 7216
q19 1078 973 556 556
q20 363 344 242 242
q21 4061 2552 2323 2323
q22 1065 1064 967 967
Total cold run time: 106974 ms
Total hot run time: 34266 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5117 5100 5078 5078
q2 253 325 242 242
q3 2209 2682 2324 2324
q4 1357 1765 1315 1315
q5 4201 4407 4541 4407
q6 216 174 134 134
q7 2060 1998 1864 1864
q8 2646 2567 2598 2567
q9 7398 7343 7560 7343
q10 2972 3227 2884 2884
q11 612 552 523 523
q12 730 784 665 665
q13 3546 4003 3243 3243
q14 307 309 282 282
q15 549 498 483 483
q16 1036 1145 1187 1145
q17 1182 1525 1443 1443
q18 7929 7856 7616 7616
q19 794 803 868 803
q20 2004 2141 1931 1931
q21 5096 4706 4470 4470
q22 1123 1046 1004 1004
Total cold run time: 53337 ms
Total hot run time: 51766 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3527400332
<details>
<summary>ClickBench: <b>Total hot run time: 27.77 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 744050cdbf3292e7865395d0d6a29b745e210151, data reload: false
query1 0.05 0.05 0.05
query2 0.09 0.05 0.05
query3 0.26 0.08 0.08
query4 1.60 0.11 0.11
query5 0.26 0.25 0.25
query6 1.19 0.65 0.63
query7 0.03 0.03 0.02
query8 0.06 0.04 0.04
query9 0.58 0.54 0.51
query10 0.58 0.57 0.57
query11 0.16 0.12 0.11
query12 0.15 0.12 0.12
query13 0.62 0.60 0.59
query14 1.00 1.00 1.01
query15 0.84 0.82 0.83
query16 0.40 0.39 0.40
query17 1.02 1.04 1.03
query18 0.22 0.20 0.20
query19 1.92 1.85 1.87
query20 0.02 0.01 0.02
query21 15.42 0.21 0.13
query22 4.97 0.07 0.05
query23 15.69 0.27 0.10
query24 2.74 0.52 0.50
query25 0.08 0.07 0.05
query26 0.14 0.13 0.15
query27 0.08 0.06 0.05
query28 4.46 1.13 0.94
query29 12.66 3.94 3.39
query30 0.28 0.14 0.11
query31 2.82 0.60 0.38
query32 3.23 0.55 0.46
query33 3.03 3.11 3.04
query34 15.71 5.15 4.55
query35 4.59 4.61 4.61
query36 0.69 0.51 0.49
query37 0.09 0.06 0.06
query38 0.06 0.04 0.04
query39 0.04 0.03 0.03
query40 0.19 0.14 0.14
query41 0.09 0.04 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 98.19 s
Total hot run time: 27.77 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3527755743
# BE Regression && UT Coverage Report
Increment line coverage `87.80% (36/41)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57996_744050cdbf3292e7865395d0d6a29b745e210151_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57996_744050cdbf3292e7865395d0d6a29b745e210151_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.55% (24340/34019) |
| Line Coverage | 58.01% (252970/436049) |
| Region Coverage | 53.38% (210880/395047) |
| Branch Coverage | 54.67% (89988/164616) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "uchenily (via GitHub)" <gi...@apache.org>.
uchenily commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3527232966
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3527381182
<details>
<summary>TPC-DS: <b>Total hot run time: 188089 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 744050cdbf3292e7865395d0d6a29b745e210151, data reload: false
query1 1021 399 419 399
query2 6557 1709 1721 1709
query3 6763 223 223 223
query4 26529 24155 23549 23549
query5 4978 618 477 477
query6 325 242 218 218
query7 4666 497 296 296
query8 308 253 255 253
query9 8746 2606 2561 2561
query10 533 337 289 289
query11 15543 15018 14786 14786
query12 180 123 116 116
query13 1698 571 449 449
query14 10805 9330 9238 9238
query15 225 198 174 174
query16 7583 708 575 575
query17 1189 758 600 600
query18 2025 423 318 318
query19 205 198 169 169
query20 128 122 125 122
query21 214 131 118 118
query22 4013 4082 4077 4077
query23 34038 33006 33034 33006
query24 8483 2395 2407 2395
query25 581 511 448 448
query26 1241 273 161 161
query27 2751 514 345 345
query28 4414 2231 2213 2213
query29 791 610 522 522
query30 309 230 198 198
query31 901 848 739 739
query32 84 74 69 69
query33 587 383 323 323
query34 790 852 527 527
query35 828 840 754 754
query36 942 999 909 909
query37 125 111 86 86
query38 3573 3489 3429 3429
query39 1465 1405 1395 1395
query40 218 128 116 116
query41 61 60 62 60
query42 126 120 121 120
query43 508 505 471 471
query44 1227 742 732 732
query45 192 188 172 172
query46 883 991 646 646
query47 1753 1761 1696 1696
query48 392 415 332 332
query49 794 498 421 421
query50 635 690 402 402
query51 3891 3977 3916 3916
query52 108 113 105 105
query53 244 265 205 205
query54 301 304 280 280
query55 85 86 86 86
query56 330 326 312 312
query57 1179 1182 1112 1112
query58 285 272 269 269
query59 2559 2680 2503 2503
query60 349 348 331 331
query61 161 153 160 153
query62 812 710 675 675
query63 231 196 197 196
query64 4435 1164 839 839
query65 4029 3939 3939 3939
query66 1136 438 332 332
query67 15164 15197 14855 14855
query68 4621 899 604 604
query69 506 337 300 300
query70 1338 1296 1280 1280
query71 429 347 322 322
query72 6065 5110 5117 5110
query73 621 591 366 366
query74 8910 9013 8649 8649
query75 3321 3343 2793 2793
query76 3275 1164 715 715
query77 523 405 318 318
query78 9600 9945 8935 8935
query79 2092 831 620 620
query80 1687 576 508 508
query81 591 273 237 237
query82 405 156 128 128
query83 367 268 251 251
query84 255 112 94 94
query85 932 485 438 438
query86 467 311 285 285
query87 3682 3743 3656 3656
query88 2903 2287 2265 2265
query89 389 330 291 291
query90 1932 222 218 218
query91 168 163 132 132
query92 80 71 64 64
query93 1844 1007 645 645
query94 774 456 356 356
query95 390 329 315 315
query96 493 583 287 287
query97 2907 2988 2863 2863
query98 232 221 213 213
query99 1314 1429 1320 1320
Total cold run time: 271338 ms
Total hot run time: 188089 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "uchenily (via GitHub)" <gi...@apache.org>.
uchenily commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3530374873
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3530627290
<details>
<summary>ClickBench: <b>Total hot run time: 27.17 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fc4fb368cfc29609f330792732b61550c3c95bc7, data reload: false
query1 0.06 0.04 0.05
query2 0.11 0.06 0.05
query3 0.26 0.08 0.08
query4 1.61 0.12 0.11
query5 0.28 0.24 0.24
query6 1.16 0.64 0.63
query7 0.03 0.02 0.03
query8 0.05 0.05 0.05
query9 0.61 0.51 0.50
query10 0.58 0.57 0.56
query11 0.17 0.12 0.11
query12 0.16 0.12 0.12
query13 0.63 0.60 0.61
query14 1.02 1.01 1.01
query15 0.85 0.83 0.82
query16 0.39 0.40 0.39
query17 1.00 1.01 1.03
query18 0.22 0.20 0.19
query19 1.88 1.83 1.75
query20 0.02 0.01 0.01
query21 15.48 0.19 0.12
query22 4.98 0.07 0.04
query23 15.68 0.25 0.10
query24 3.10 0.99 0.26
query25 0.08 0.07 0.05
query26 0.14 0.13 0.14
query27 0.06 0.05 0.04
query28 3.99 1.14 0.93
query29 12.58 3.99 3.26
query30 0.29 0.14 0.12
query31 2.82 0.59 0.38
query32 3.24 0.55 0.46
query33 2.99 3.10 3.12
query34 15.81 5.16 4.49
query35 4.55 4.52 4.55
query36 0.70 0.51 0.51
query37 0.10 0.07 0.07
query38 0.07 0.04 0.04
query39 0.03 0.03 0.03
query40 0.18 0.14 0.14
query41 0.09 0.03 0.03
query42 0.04 0.03 0.03
query43 0.05 0.04 0.03
Total cold run time: 98.14 s
Total hot run time: 27.17 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3540832585
<details>
<summary>TPC-DS: <b>Total hot run time: 190654 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6f1008150c83d86de4c3e162abb4c622feff6249, data reload: false
query1 1059 428 416 416
query2 6599 1727 1694 1694
query3 6755 233 231 231
query4 26936 23719 23337 23337
query5 4444 707 538 538
query6 361 242 221 221
query7 4645 529 333 333
query8 307 259 245 245
query9 8673 2982 2962 2962
query10 504 365 314 314
query11 16271 15244 15017 15017
query12 215 144 124 124
query13 1685 571 452 452
query14 11325 9409 9429 9409
query15 206 206 182 182
query16 7693 694 480 480
query17 1230 812 624 624
query18 2050 450 354 354
query19 215 208 193 193
query20 137 131 134 131
query21 223 139 124 124
query22 3960 4178 4045 4045
query23 34539 32766 32928 32766
query24 8326 2411 2440 2411
query25 624 542 470 470
query26 1241 286 178 178
query27 2741 521 386 386
query28 4374 2292 2258 2258
query29 797 648 510 510
query30 361 235 224 224
query31 930 799 709 709
query32 93 81 82 81
query33 600 421 368 368
query34 826 863 544 544
query35 873 881 767 767
query36 968 1002 914 914
query37 138 126 103 103
query38 3681 3714 3616 3616
query39 1492 1438 1431 1431
query40 236 145 129 129
query41 66 61 61 61
query42 137 121 121 121
query43 472 507 482 482
query44 1299 803 809 803
query45 197 190 181 181
query46 919 1021 672 672
query47 1788 1793 1724 1724
query48 401 446 332 332
query49 792 559 425 425
query50 676 688 421 421
query51 4103 4013 4010 4010
query52 118 127 111 111
query53 248 286 204 204
query54 338 323 308 308
query55 100 103 96 96
query56 381 359 371 359
query57 1206 1191 1133 1133
query58 323 301 303 301
query59 2512 2660 2565 2565
query60 400 398 378 378
query61 197 193 192 192
query62 805 766 694 694
query63 242 206 206 206
query64 4609 1313 1011 1011
query65 4143 4070 3994 3994
query66 1146 486 377 377
query67 15190 15073 15002 15002
query68 8191 957 639 639
query69 524 365 324 324
query70 1351 1285 1342 1285
query71 456 369 349 349
query72 6099 4855 4827 4827
query73 637 588 373 373
query74 8989 8997 8837 8837
query75 3354 3384 2834 2834
query76 3310 1178 796 796
query77 498 427 347 347
query78 9864 9936 9169 9169
query79 2653 938 640 640
query80 732 611 553 553
query81 535 285 253 253
query82 240 173 142 142
query83 278 281 264 264
query84 263 126 96 96
query85 898 500 473 473
query86 378 336 290 290
query87 3807 3827 3636 3636
query88 3841 2272 2249 2249
query89 408 336 303 303
query90 2018 245 232 232
query91 169 171 135 135
query92 94 81 79 79
query93 2258 1015 681 681
query94 705 454 323 323
query95 431 357 332 332
query96 495 627 285 285
query97 2952 3007 2922 2922
query98 271 228 226 226
query99 1336 1408 1306 1306
Total cold run time: 279176 ms
Total hot run time: 190654 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "uchenily (via GitHub)" <gi...@apache.org>.
uchenily commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3530531010
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3530618992
<details>
<summary>TPC-DS: <b>Total hot run time: 188561 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fc4fb368cfc29609f330792732b61550c3c95bc7, data reload: false
query1 1127 421 387 387
query2 6640 1671 1704 1671
query3 6827 224 227 224
query4 26265 23292 23495 23292
query5 4398 623 458 458
query6 333 238 231 231
query7 4670 505 293 293
query8 316 284 260 260
query9 8683 2591 2600 2591
query10 485 339 297 297
query11 15746 15155 14944 14944
query12 174 128 114 114
query13 1691 590 453 453
query14 10558 9345 9281 9281
query15 198 189 172 172
query16 7224 679 512 512
query17 1296 799 653 653
query18 2002 432 336 336
query19 217 212 200 200
query20 146 137 129 129
query21 269 133 118 118
query22 3994 4173 4026 4026
query23 33624 32937 33138 32937
query24 8536 2425 2478 2425
query25 609 546 488 488
query26 1280 282 170 170
query27 2699 496 366 366
query28 4467 2208 2203 2203
query29 877 644 507 507
query30 373 224 196 196
query31 881 817 724 724
query32 81 73 75 73
query33 654 369 336 336
query34 811 856 535 535
query35 808 849 766 766
query36 917 985 903 903
query37 147 110 86 86
query38 3461 3550 3460 3460
query39 1462 1415 1431 1415
query40 230 136 121 121
query41 67 60 60 60
query42 123 109 113 109
query43 499 515 478 478
query44 1244 746 743 743
query45 200 196 175 175
query46 894 1002 659 659
query47 1755 1806 1768 1768
query48 391 446 321 321
query49 798 520 428 428
query50 645 682 397 397
query51 3913 3955 3945 3945
query52 110 120 105 105
query53 252 270 189 189
query54 310 300 278 278
query55 89 85 88 85
query56 325 324 314 314
query57 1166 1197 1102 1102
query58 293 275 270 270
query59 2593 2641 2561 2561
query60 338 357 334 334
query61 167 165 202 165
query62 797 723 664 664
query63 232 198 195 195
query64 4472 1150 863 863
query65 4065 3921 3961 3921
query66 1181 438 338 338
query67 15364 15031 15024 15024
query68 8267 936 599 599
query69 482 337 295 295
query70 1367 1270 1314 1270
query71 649 337 331 331
query72 6044 5017 5038 5017
query73 698 629 363 363
query74 9043 9206 8865 8865
query75 3958 3333 2866 2866
query76 3608 1150 725 725
query77 815 421 323 323
query78 9516 9760 8898 8898
query79 2629 845 613 613
query80 702 574 550 550
query81 516 273 232 232
query82 219 164 133 133
query83 258 261 248 248
query84 257 116 100 100
query85 982 499 447 447
query86 390 307 313 307
query87 3778 3740 3630 3630
query88 3858 2298 2211 2211
query89 444 333 296 296
query90 1932 225 224 224
query91 167 169 140 140
query92 85 72 69 69
query93 2222 979 638 638
query94 647 452 350 350
query95 422 331 323 323
query96 490 571 284 284
query97 2888 2999 2865 2865
query98 301 224 205 205
query99 1335 1411 1300 1300
Total cold run time: 276428 ms
Total hot run time: 188561 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "uchenily (via GitHub)" <gi...@apache.org>.
uchenily commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3531272719
run check_coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "uchenily (via GitHub)" <gi...@apache.org>.
uchenily commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3531270612
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3527219270
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3527514992
# BE UT Coverage Report
Increment line coverage `0.00% (0/41)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/744050cdbf3292e7865395d0d6a29b745e210151_744050cdbf3292e7865395d0d6a29b745e210151/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/744050cdbf3292e7865395d0d6a29b745e210151_744050cdbf3292e7865395d0d6a29b745e210151/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.80% (18280/34619) |
| Line Coverage | 38.17% (166198/435373) |
| Region Coverage | 33.16% (129180/389536) |
| Branch Coverage | 33.90% (55439/163541) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3540853783
<details>
<summary>ClickBench: <b>Total hot run time: 27.54 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6f1008150c83d86de4c3e162abb4c622feff6249, data reload: false
query1 0.05 0.05 0.06
query2 0.09 0.05 0.05
query3 0.26 0.09 0.08
query4 1.61 0.11 0.11
query5 0.26 0.25 0.25
query6 1.16 0.65 0.65
query7 0.03 0.02 0.02
query8 0.06 0.05 0.06
query9 0.59 0.54 0.51
query10 0.57 0.58 0.58
query11 0.17 0.12 0.12
query12 0.15 0.11 0.13
query13 0.62 0.61 0.60
query14 1.00 1.01 1.00
query15 0.87 0.84 0.84
query16 0.39 0.41 0.40
query17 1.01 1.00 1.01
query18 0.22 0.20 0.21
query19 1.94 1.81 1.81
query20 0.02 0.01 0.02
query21 15.45 0.21 0.14
query22 4.97 0.08 0.05
query23 15.69 0.27 0.11
query24 2.81 1.15 0.30
query25 0.07 0.07 0.06
query26 0.15 0.13 0.13
query27 0.06 0.06 0.05
query28 4.31 1.21 0.96
query29 12.62 3.87 3.29
query30 0.29 0.16 0.11
query31 2.82 0.61 0.39
query32 3.24 0.56 0.47
query33 3.12 3.01 3.08
query34 15.84 5.16 4.59
query35 4.56 4.59 4.59
query36 0.69 0.50 0.49
query37 0.09 0.06 0.07
query38 0.07 0.04 0.04
query39 0.04 0.03 0.03
query40 0.18 0.14 0.14
query41 0.09 0.04 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 98.31 s
Total hot run time: 27.54 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3540932677
# BE UT Coverage Report
Increment line coverage `0.00% (0/41)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/6f1008150c83d86de4c3e162abb4c622feff6249_6f1008150c83d86de4c3e162abb4c622feff6249/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/6f1008150c83d86de4c3e162abb4c622feff6249_6f1008150c83d86de4c3e162abb4c622feff6249/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.75% (18274/34644) |
| Line Coverage | 38.13% (166122/435707) |
| Region Coverage | 33.09% (129149/390350) |
| Branch Coverage | 33.84% (55407/163742) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3541259442
# BE Regression && UT Coverage Report
Increment line coverage `87.80% (36/41)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57996_6f1008150c83d86de4c3e162abb4c622feff6249_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57996_6f1008150c83d86de4c3e162abb4c622feff6249_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.49% (24338/34044) |
| Line Coverage | 57.97% (252950/436381) |
| Region Coverage | 53.16% (210427/395854) |
| Branch Coverage | 54.55% (89910/164817) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "uchenily (via GitHub)" <gi...@apache.org>.
uchenily commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3540681286
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](csv reader) Set eof flag based on _line_reader_eof [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57996:
URL: https://github.com/apache/doris/pull/57996#issuecomment-3568953976
# BE Regression && UT Coverage Report
Increment line coverage `87.80% (36/41)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57996_6f1008150c83d86de4c3e162abb4c622feff6249_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57996_6f1008150c83d86de4c3e162abb4c622feff6249_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.48% (24335/34044) |
| Line Coverage | 57.96% (252928/436381) |
| Region Coverage | 53.15% (210396/395854) |
| Branch Coverage | 54.55% (89903/164817) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org