[GitHub] weijietong commented on a change in pull request #1600: DRILL-6947: fix RuntimeFilter memory leak

[GitBox <gi...@apache.org>]

weijietong commented on a change in pull request #1600: DRILL-6947: fix RuntimeFilter memory leak
URL: https://github.com/apache/drill/pull/1600#discussion_r250042732
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContextImpl.java
 ##########
 @@ -530,11 +530,11 @@ public void close() {
     // Close the buffers before closing the operators; this is needed as buffer ownership
     // is attached to the receive operators.
     suppressingClose(buffers);
-    closeNotConsumedRFWs();
     // close operator context
     for (OperatorContextImpl opContext : contexts) {
       suppressingClose(opContext);
     }
+    closeNotConsumedRFWs();
 
 Review comment:
   The order has no matters with the memory leak. I will revert that to the original position.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services