You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2017/11/01 19:14:00 UTC
[jira] [Updated] (SOLR-11507) simplify and extend
SolrTestCaseJ4.CloudSolrClientBuilder randomisation
[ https://issues.apache.org/jira/browse/SOLR-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley updated SOLR-11507:
--------------------------------
Attachment: SOLR-11507.patch
The attached patch does what we've said it should.
In addition, I've moved the parallelUpdates flag from being a mutable state member of CloudSolrClient to be a Builder setting like the other flags. I refactored callers of setParallelUpdates (which all randomly set it in tests) to not do so anymore, relying on this happening implicitly now. setParallelUpdates is still there but now marked deprecated and doesn't do anything (is this ok?). I should probably change the issue title accordingly as this change isn't just some little test change. I wonder why anyone would disable this setting? Seems unlikely to be useful, so I suspect the impact is low. Suggested new title: "move CloudSolrClient.setParallelUpdates to the Builder".
> simplify and extend SolrTestCaseJ4.CloudSolrClientBuilder randomisation
> -----------------------------------------------------------------------
>
> Key: SOLR-11507
> URL: https://issues.apache.org/jira/browse/SOLR-11507
> Project: Solr
> Issue Type: Test
> Reporter: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-11507.patch, SOLR-11507.patch
>
>
> [~dsmiley] wrote in SOLR-9090:
> bq. [~cpoerschke] I'm looking at {{SolrTestCaseJ4.CloudSolrClientBuilder}}. Instead of the somewhat complicated tracking using configuredDUTflag, couldn't you simply remove all that stuff and just modify the builder's constructor to randomize the settings?
> bq. Furthermore, shouldn't {{shardLeadersOnly}} be randomized as well?
> This ticket is to follow-up on that suggestion since SOLR-9090 is already closed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org