You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "fabriziofortino (via GitHub)" <gi...@apache.org> on 2023/07/19 08:46:25 UTC

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #1029: OAK-10353: Elastic custom analyzer should ignore unsupported properties

fabriziofortino commented on code in PR #1029:
URL: https://github.com/apache/jackrabbit-oak/pull/1029#discussion_r1267754756


##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticFullTextAnalyzerTest.java:
##########
@@ -104,8 +104,8 @@ public void fulltextSearchWithAdvancedLanguageBasedStemmer() throws Exception {
             anl.addChild(FulltextIndexConstants.ANL_TOKENIZER).setProperty(FulltextIndexConstants.ANL_NAME, "Standard");
 
             Tree filters = anl.addChild(FulltextIndexConstants.ANL_FILTERS);
-            filters.addChild("LowerCase");
-            Tree stemmer = filters.addChild("stemmer");
+            addFilter(filters, "Lowercase");

Review Comment:
   Good catch. It's not an issue since the filter names are lowercased when the config gets processed. I have changed it so the configuration is consistent with the rest.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org