You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/21 06:45:06 UTC

[GitHub] [spark] itholic commented on a diff in pull request #37916: [SPARK-40473][SQL] Migrate parsing errors onto error classes

itholic commented on code in PR #37916:
URL: https://github.com/apache/spark/pull/37916#discussion_r976096811


##########
core/src/main/resources/error/README.md:
##########
@@ -66,6 +66,8 @@ To access error fields, catch exceptions that extend `org.apache.spark.SparkThro
 
 Error classes are a succinct, human-readable representation of the error category.
 
+An uncategorized errors can be assigned to a legacy error class with the prefix _LEGACY_ERROR_TEMP_ and an unused sequential number, for instance _LEGACY_ERROR_TEMP_053.

Review Comment:
   nit: Maybe we should using `\` in front of `_LEGACY_ERROR_TEMP_` as an escape character ??
   
   Otherwise, maybe it should look something like: _LEGACY_ERROR_TEMP_ in the documents.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org