You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ozone.apache.org by Prashant Pogde <pp...@cloudera.com.INVALID> on 2023/01/10 22:54:39 UTC
[DISCUSS] Proposal to merge HDDS-6517 Ozone Snapshots
Dear Ozone Devs,
We would like to start this discussion thread for the proposal to merge
https://issues.apache.org/jira/browse/HDDS-6517 Ozone Snapshots.
Ozone Snapshot feature allows us to take a point in time frozen image of
the Ozone dataset. Initially this feature would allow snapshots to be taken
at bucket granularity. Subsequently the feature can support Snapshots
at Volume level as well as the whole Ozone Namespace level.
Note that HDDS-6517 is a new feature such that it is mainly adding new
code. Therefore, the risk is very low to the existing functionalities and
features in Ozone.
When the Snapshot feature is not used, it should cause no impact to the master.
For more information, please check out Ozone Snapshot feature Jira
(HDDS-6517) and feature wiki page here:
https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots
If there are no objections for the merge, we could start the official vote.
Thanks,
Ozone Snapshot Team
Re: [RESULT] [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Uma Maheswara Rao Gangumalla <um...@gmail.com>.
clap clap. Great job team!!!
Regards,
Uma
On Wed, Feb 1, 2023 at 9:21 PM Siyao Meng <si...@apache.org> wrote:
> Hi Ozone devs,
>
> Thanks everyone. Snapshot feature branch merge is now *complete*.
> Snapshot feature dev from Milestone 2 will continue on the master branch.
> The wiki page
> <
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240880760
> >
> has also been updated to reflect this.
>
> Previously mentioned flakiness has been addressed and remediated by
> HDDS-7845 <https://issues.apache.org/jira/browse/HDDS-7845> and HDDS-7861
> <https://issues.apache.org/jira/browse/HDDS-7861>. Big thanks to Hemant
> for
> working on them. A follow-up jira HDDS-7871
> <https://issues.apache.org/jira/browse/HDDS-7871> has been filed for
> discussion and a potential fix in KeyManagerImpl.
>
>
> To devs working on master branch:
>
> - This branch merge may lead to new conflicts in pending PRs targeting
> the master branch, as we *moved* read path implementations from
> OzoneManager
> to OmMetadataReader (as they are shared by active DB and snapshot
> checkpoint DB).
> - In that case, fetch the latest master branch (e.g. git fetch asf
> master), merge it into your dev branch (e.g. git merge asf/master), resolve
> the conflicts accordingly and commit. Please feel free to reach out if you
> need help.
> - Future new OM read path would need to be implemented in
> OmMetadataReader
> then called from OzoneManager. If that new OM read path is applicable to
> snapshots, it needs to be implemented in OmSnapshot as well.
>
>
> To devs that has open PRs against snapshot feature branch:
>
> - Please re-target your PRs' base branch by clicking "Edit" to the right
> of the PR title, select "base: master" then "Change base".
>
>
> Thanks,
> Siyao
>
> On Jan 27, 2023 at 10:03:16 AM, Uma Maheswara Rao Gangumalla <
> umagangumalla@gmail.com> wrote:
>
> > +1 Let's address the test failure before merge. It's a blocker for the
> > merge.
> >
> > Regards,
> > Uma
> >
> > On Fri, Jan 27, 2023 at 9:52 AM Prashant Pogde
> <ppogde@cloudera.com.invalid
> > >
> > wrote:
> >
> > Yup, we are on top of it.
> >
> >
> > Thanks,
> >
> > Prashant
> >
> >
> > > On Jan 27, 2023, at 12:34 AM, Attila Doroszlai <ad...@apache.org>
> >
> > wrote:
> >
> > >
> >
> > > Hi Prashant,
> >
> > >
> >
> > >> We will go ahead and merge the Snapshot branch into master.
> >
> > >
> >
> > > There is a new integration test that has been failing consistently
> >
> > > since it was introduced on the feature branch (last 3 commits and a
> >
> > > new PR). Please only merge to master after it is fixed.
> >
> > >
> >
> > > https://issues.apache.org/jira/browse/HDDS-7846
> >
> > >
> >
> > > -Attila
> >
> > >
> >
> > > ---------------------------------------------------------------------
> >
> > > To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> >
> > > For additional commands, e-mail: dev-help@ozone.apache.org
> >
> > >
> >
> >
> >
> > ---------------------------------------------------------------------
> >
> > To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> >
> > For additional commands, e-mail: dev-help@ozone.apache.org
> >
> >
> >
> >
>
Re: [RESULT] [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Siyao Meng <si...@apache.org>.
Hi Ozone devs,
Thanks everyone. Snapshot feature branch merge is now *complete*.
Snapshot feature dev from Milestone 2 will continue on the master branch.
The wiki page
<https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240880760>
has also been updated to reflect this.
Previously mentioned flakiness has been addressed and remediated by
HDDS-7845 <https://issues.apache.org/jira/browse/HDDS-7845> and HDDS-7861
<https://issues.apache.org/jira/browse/HDDS-7861>. Big thanks to Hemant for
working on them. A follow-up jira HDDS-7871
<https://issues.apache.org/jira/browse/HDDS-7871> has been filed for
discussion and a potential fix in KeyManagerImpl.
To devs working on master branch:
- This branch merge may lead to new conflicts in pending PRs targeting
the master branch, as we *moved* read path implementations from OzoneManager
to OmMetadataReader (as they are shared by active DB and snapshot
checkpoint DB).
- In that case, fetch the latest master branch (e.g. git fetch asf
master), merge it into your dev branch (e.g. git merge asf/master), resolve
the conflicts accordingly and commit. Please feel free to reach out if you
need help.
- Future new OM read path would need to be implemented in OmMetadataReader
then called from OzoneManager. If that new OM read path is applicable to
snapshots, it needs to be implemented in OmSnapshot as well.
To devs that has open PRs against snapshot feature branch:
- Please re-target your PRs' base branch by clicking "Edit" to the right
of the PR title, select "base: master" then "Change base".
Thanks,
Siyao
On Jan 27, 2023 at 10:03:16 AM, Uma Maheswara Rao Gangumalla <
umagangumalla@gmail.com> wrote:
> +1 Let's address the test failure before merge. It's a blocker for the
> merge.
>
> Regards,
> Uma
>
> On Fri, Jan 27, 2023 at 9:52 AM Prashant Pogde <ppogde@cloudera.com.invalid
> >
> wrote:
>
> Yup, we are on top of it.
>
>
> Thanks,
>
> Prashant
>
>
> > On Jan 27, 2023, at 12:34 AM, Attila Doroszlai <ad...@apache.org>
>
> wrote:
>
> >
>
> > Hi Prashant,
>
> >
>
> >> We will go ahead and merge the Snapshot branch into master.
>
> >
>
> > There is a new integration test that has been failing consistently
>
> > since it was introduced on the feature branch (last 3 commits and a
>
> > new PR). Please only merge to master after it is fixed.
>
> >
>
> > https://issues.apache.org/jira/browse/HDDS-7846
>
> >
>
> > -Attila
>
> >
>
> > ---------------------------------------------------------------------
>
> > To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
>
> > For additional commands, e-mail: dev-help@ozone.apache.org
>
> >
>
>
>
> ---------------------------------------------------------------------
>
> To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
>
> For additional commands, e-mail: dev-help@ozone.apache.org
>
>
>
>
Re: [RESULT] [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Uma Maheswara Rao Gangumalla <um...@gmail.com>.
+1 Let's address the test failure before merge. It's a blocker for the
merge.
Regards,
Uma
On Fri, Jan 27, 2023 at 9:52 AM Prashant Pogde <pp...@cloudera.com.invalid>
wrote:
> Yup, we are on top of it.
>
> Thanks,
> Prashant
>
> > On Jan 27, 2023, at 12:34 AM, Attila Doroszlai <ad...@apache.org>
> wrote:
> >
> > Hi Prashant,
> >
> >> We will go ahead and merge the Snapshot branch into master.
> >
> > There is a new integration test that has been failing consistently
> > since it was introduced on the feature branch (last 3 commits and a
> > new PR). Please only merge to master after it is fixed.
> >
> > https://issues.apache.org/jira/browse/HDDS-7846
> >
> > -Attila
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> > For additional commands, e-mail: dev-help@ozone.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> For additional commands, e-mail: dev-help@ozone.apache.org
>
>
Re: [RESULT] [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Prashant Pogde <pp...@cloudera.com.INVALID>.
Yup, we are on top of it.
Thanks,
Prashant
> On Jan 27, 2023, at 12:34 AM, Attila Doroszlai <ad...@apache.org> wrote:
>
> Hi Prashant,
>
>> We will go ahead and merge the Snapshot branch into master.
>
> There is a new integration test that has been failing consistently
> since it was introduced on the feature branch (last 3 commits and a
> new PR). Please only merge to master after it is fixed.
>
> https://issues.apache.org/jira/browse/HDDS-7846
>
> -Attila
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> For additional commands, e-mail: dev-help@ozone.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
For additional commands, e-mail: dev-help@ozone.apache.org
Re: [RESULT] [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Attila Doroszlai <ad...@apache.org>.
Hi Prashant,
> We will go ahead and merge the Snapshot branch into master.
There is a new integration test that has been failing consistently
since it was introduced on the feature branch (last 3 commits and a
new PR). Please only merge to master after it is fixed.
https://issues.apache.org/jira/browse/HDDS-7846
-Attila
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
For additional commands, e-mail: dev-help@ozone.apache.org
[RESULT] [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Prashant Pogde <pp...@cloudera.com.INVALID>.
We are concluding the vote thread with 7 +votes and 0 objections.
We will go ahead and merge the Snapshot branch into master.
Thank you
Prashant
> On Jan 24, 2023, at 7:07 PM, Neil Joshi <ne...@gmail.com> wrote:
>
> Hi guys,
>
> Great work. Thanks. +1 for merge.
>
> Regards,
> Neil
>
> On Mon, Jan 23, 2023 at 5:28 AM Ayush Saxena <ay...@gmail.com> wrote:
>
>> +1
>>
>> -Ayush
>>
>>> On 23-Jan-2023, at 3:27 PM, Sadanand Shenoy <ss...@apache.org> wrote:
>>>
>>> +1 for the merge.
>>>
>>> Thanks,
>>> Sadanand
>>>
>>>> On Mon, Jan 23, 2023 at 3:06 PM NILOTPAL NANDI <
>> nilotpal.apache@gmail.com>
>>>> wrote:
>>>>
>>>> +1 for the merge.
>>>>
>>>> Thanks,
>>>> Nilotpal Nandi
>>>>
>>>>> On Sat, Jan 21, 2023 at 6:08 AM Tsz Wo Sze <sz...@gmail.com> wrote:
>>>>>
>>>>> +1
>>>>> Tsz-Wo
>>>>>
>>>>> On Sat, Jan 21, 2023 at 3:26 AM Siddharth Wagle <sw...@apache.org>
>>>> wrote:
>>>>>
>>>>>> +1 for the merge.
>>>>>>
>>>>>> - Sid
>>>>>>
>>>>>> On Fri, Jan 20, 2023 at 11:21 AM Uma Maheswara Rao Gangumalla <
>>>>>> umagangumalla@gmail.com> wrote:
>>>>>>
>>>>>>> +1
>>>>>>>
>>>>>>> Regards,
>>>>>>> Uma
>>>>>>>
>>>>>>> On Wed, Jan 18, 2023 at 11:08 AM Prashant Pogde
>>>>>>> <pp...@cloudera.com.invalid>
>>>>>>> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>> We would like to start this Vote thread for the proposal to merge
>>>>>>>> https://issues.apache.org/jira/browse/HDDS-6517 <
>>>>>>>> https://issues.apache.org/jira/browse/HDDS-6517> Ozone Snapshots.
>>>>>>>>
>>>>>>>> Ozone Snapshot feature allows us to take a point in time frozen
>>>> image
>>>>>> of
>>>>>>>> the Ozone dataset. Initially this feature would allow snapshots to
>>>> be
>>>>>>> taken
>>>>>>>> at bucket granularity. Subsequently the feature can support
>>>> Snapshots
>>>>>>>> at Volume level as well as the whole Ozone Namespace level.
>>>>>>>>
>>>>>>>> Note that HDDS-6517 is a new feature such that it is mainly adding
>>>>> new
>>>>>>>> code. Therefore, the risk is very low to the existing
>>>>> functionalities
>>>>>>> and
>>>>>>>> features in Ozone.
>>>>>>>>
>>>>>>>> When the Snapshot feature is not used, it should cause no impact to
>>>>> the
>>>>>>>> master.
>>>>>>>> For more information, please check out Ozone Snapshot feature Jira
>>>>>>>> (HDDS-6517) and feature wiki page here:
>>>>>>>>
>>>>>>>> https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots
>>>> <
>>>>>>>> https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots>
>>>>>>>>
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Ozone Snapshot Team
>>>>>>>
>>>>>>
>>>>>
>>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
>> For additional commands, e-mail: dev-help@ozone.apache.org
>>
>>
>
> --
> NJ
Re: [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Neil Joshi <ne...@gmail.com>.
Hi guys,
Great work. Thanks. +1 for merge.
Regards,
Neil
On Mon, Jan 23, 2023 at 5:28 AM Ayush Saxena <ay...@gmail.com> wrote:
> +1
>
> -Ayush
>
> > On 23-Jan-2023, at 3:27 PM, Sadanand Shenoy <ss...@apache.org> wrote:
> >
> > +1 for the merge.
> >
> > Thanks,
> > Sadanand
> >
> >> On Mon, Jan 23, 2023 at 3:06 PM NILOTPAL NANDI <
> nilotpal.apache@gmail.com>
> >> wrote:
> >>
> >> +1 for the merge.
> >>
> >> Thanks,
> >> Nilotpal Nandi
> >>
> >>> On Sat, Jan 21, 2023 at 6:08 AM Tsz Wo Sze <sz...@gmail.com> wrote:
> >>>
> >>> +1
> >>> Tsz-Wo
> >>>
> >>> On Sat, Jan 21, 2023 at 3:26 AM Siddharth Wagle <sw...@apache.org>
> >> wrote:
> >>>
> >>>> +1 for the merge.
> >>>>
> >>>> - Sid
> >>>>
> >>>> On Fri, Jan 20, 2023 at 11:21 AM Uma Maheswara Rao Gangumalla <
> >>>> umagangumalla@gmail.com> wrote:
> >>>>
> >>>>> +1
> >>>>>
> >>>>> Regards,
> >>>>> Uma
> >>>>>
> >>>>> On Wed, Jan 18, 2023 at 11:08 AM Prashant Pogde
> >>>>> <pp...@cloudera.com.invalid>
> >>>>> wrote:
> >>>>>
> >>>>>>
> >>>>>> We would like to start this Vote thread for the proposal to merge
> >>>>>> https://issues.apache.org/jira/browse/HDDS-6517 <
> >>>>>> https://issues.apache.org/jira/browse/HDDS-6517> Ozone Snapshots.
> >>>>>>
> >>>>>> Ozone Snapshot feature allows us to take a point in time frozen
> >> image
> >>>> of
> >>>>>> the Ozone dataset. Initially this feature would allow snapshots to
> >> be
> >>>>> taken
> >>>>>> at bucket granularity. Subsequently the feature can support
> >> Snapshots
> >>>>>> at Volume level as well as the whole Ozone Namespace level.
> >>>>>>
> >>>>>> Note that HDDS-6517 is a new feature such that it is mainly adding
> >>> new
> >>>>>> code. Therefore, the risk is very low to the existing
> >>> functionalities
> >>>>> and
> >>>>>> features in Ozone.
> >>>>>>
> >>>>>> When the Snapshot feature is not used, it should cause no impact to
> >>> the
> >>>>>> master.
> >>>>>> For more information, please check out Ozone Snapshot feature Jira
> >>>>>> (HDDS-6517) and feature wiki page here:
> >>>>>>
> >>>>>> https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots
> >> <
> >>>>>> https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots>
> >>>>>>
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Ozone Snapshot Team
> >>>>>
> >>>>
> >>>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> For additional commands, e-mail: dev-help@ozone.apache.org
>
>
--
NJ
Re: [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Ayush Saxena <ay...@gmail.com>.
+1
-Ayush
> On 23-Jan-2023, at 3:27 PM, Sadanand Shenoy <ss...@apache.org> wrote:
>
> +1 for the merge.
>
> Thanks,
> Sadanand
>
>> On Mon, Jan 23, 2023 at 3:06 PM NILOTPAL NANDI <ni...@gmail.com>
>> wrote:
>>
>> +1 for the merge.
>>
>> Thanks,
>> Nilotpal Nandi
>>
>>> On Sat, Jan 21, 2023 at 6:08 AM Tsz Wo Sze <sz...@gmail.com> wrote:
>>>
>>> +1
>>> Tsz-Wo
>>>
>>> On Sat, Jan 21, 2023 at 3:26 AM Siddharth Wagle <sw...@apache.org>
>> wrote:
>>>
>>>> +1 for the merge.
>>>>
>>>> - Sid
>>>>
>>>> On Fri, Jan 20, 2023 at 11:21 AM Uma Maheswara Rao Gangumalla <
>>>> umagangumalla@gmail.com> wrote:
>>>>
>>>>> +1
>>>>>
>>>>> Regards,
>>>>> Uma
>>>>>
>>>>> On Wed, Jan 18, 2023 at 11:08 AM Prashant Pogde
>>>>> <pp...@cloudera.com.invalid>
>>>>> wrote:
>>>>>
>>>>>>
>>>>>> We would like to start this Vote thread for the proposal to merge
>>>>>> https://issues.apache.org/jira/browse/HDDS-6517 <
>>>>>> https://issues.apache.org/jira/browse/HDDS-6517> Ozone Snapshots.
>>>>>>
>>>>>> Ozone Snapshot feature allows us to take a point in time frozen
>> image
>>>> of
>>>>>> the Ozone dataset. Initially this feature would allow snapshots to
>> be
>>>>> taken
>>>>>> at bucket granularity. Subsequently the feature can support
>> Snapshots
>>>>>> at Volume level as well as the whole Ozone Namespace level.
>>>>>>
>>>>>> Note that HDDS-6517 is a new feature such that it is mainly adding
>>> new
>>>>>> code. Therefore, the risk is very low to the existing
>>> functionalities
>>>>> and
>>>>>> features in Ozone.
>>>>>>
>>>>>> When the Snapshot feature is not used, it should cause no impact to
>>> the
>>>>>> master.
>>>>>> For more information, please check out Ozone Snapshot feature Jira
>>>>>> (HDDS-6517) and feature wiki page here:
>>>>>>
>>>>>> https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots
>> <
>>>>>> https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots>
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Ozone Snapshot Team
>>>>>
>>>>
>>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
For additional commands, e-mail: dev-help@ozone.apache.org
Re: [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Sadanand Shenoy <ss...@apache.org>.
+1 for the merge.
Thanks,
Sadanand
On Mon, Jan 23, 2023 at 3:06 PM NILOTPAL NANDI <ni...@gmail.com>
wrote:
> +1 for the merge.
>
> Thanks,
> Nilotpal Nandi
>
> On Sat, Jan 21, 2023 at 6:08 AM Tsz Wo Sze <sz...@gmail.com> wrote:
>
> > +1
> > Tsz-Wo
> >
> > On Sat, Jan 21, 2023 at 3:26 AM Siddharth Wagle <sw...@apache.org>
> wrote:
> >
> > > +1 for the merge.
> > >
> > > - Sid
> > >
> > > On Fri, Jan 20, 2023 at 11:21 AM Uma Maheswara Rao Gangumalla <
> > > umagangumalla@gmail.com> wrote:
> > >
> > > > +1
> > > >
> > > > Regards,
> > > > Uma
> > > >
> > > > On Wed, Jan 18, 2023 at 11:08 AM Prashant Pogde
> > > > <pp...@cloudera.com.invalid>
> > > > wrote:
> > > >
> > > > >
> > > > > We would like to start this Vote thread for the proposal to merge
> > > > > https://issues.apache.org/jira/browse/HDDS-6517 <
> > > > > https://issues.apache.org/jira/browse/HDDS-6517> Ozone Snapshots.
> > > > >
> > > > > Ozone Snapshot feature allows us to take a point in time frozen
> image
> > > of
> > > > > the Ozone dataset. Initially this feature would allow snapshots to
> be
> > > > taken
> > > > > at bucket granularity. Subsequently the feature can support
> Snapshots
> > > > > at Volume level as well as the whole Ozone Namespace level.
> > > > >
> > > > > Note that HDDS-6517 is a new feature such that it is mainly adding
> > new
> > > > > code. Therefore, the risk is very low to the existing
> > functionalities
> > > > and
> > > > > features in Ozone.
> > > > >
> > > > > When the Snapshot feature is not used, it should cause no impact to
> > the
> > > > > master.
> > > > > For more information, please check out Ozone Snapshot feature Jira
> > > > > (HDDS-6517) and feature wiki page here:
> > > > >
> > > > > https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots
> <
> > > > > https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots>
> > > > >
> > > > >
> > > > > Thanks,
> > > > > Ozone Snapshot Team
> > > >
> > >
> >
>
Re: [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by NILOTPAL NANDI <ni...@gmail.com>.
+1 for the merge.
Thanks,
Nilotpal Nandi
On Sat, Jan 21, 2023 at 6:08 AM Tsz Wo Sze <sz...@gmail.com> wrote:
> +1
> Tsz-Wo
>
> On Sat, Jan 21, 2023 at 3:26 AM Siddharth Wagle <sw...@apache.org> wrote:
>
> > +1 for the merge.
> >
> > - Sid
> >
> > On Fri, Jan 20, 2023 at 11:21 AM Uma Maheswara Rao Gangumalla <
> > umagangumalla@gmail.com> wrote:
> >
> > > +1
> > >
> > > Regards,
> > > Uma
> > >
> > > On Wed, Jan 18, 2023 at 11:08 AM Prashant Pogde
> > > <pp...@cloudera.com.invalid>
> > > wrote:
> > >
> > > >
> > > > We would like to start this Vote thread for the proposal to merge
> > > > https://issues.apache.org/jira/browse/HDDS-6517 <
> > > > https://issues.apache.org/jira/browse/HDDS-6517> Ozone Snapshots.
> > > >
> > > > Ozone Snapshot feature allows us to take a point in time frozen image
> > of
> > > > the Ozone dataset. Initially this feature would allow snapshots to be
> > > taken
> > > > at bucket granularity. Subsequently the feature can support Snapshots
> > > > at Volume level as well as the whole Ozone Namespace level.
> > > >
> > > > Note that HDDS-6517 is a new feature such that it is mainly adding
> new
> > > > code. Therefore, the risk is very low to the existing
> functionalities
> > > and
> > > > features in Ozone.
> > > >
> > > > When the Snapshot feature is not used, it should cause no impact to
> the
> > > > master.
> > > > For more information, please check out Ozone Snapshot feature Jira
> > > > (HDDS-6517) and feature wiki page here:
> > > >
> > > > https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots <
> > > > https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots>
> > > >
> > > >
> > > > Thanks,
> > > > Ozone Snapshot Team
> > >
> >
>
Re: [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Tsz Wo Sze <sz...@gmail.com>.
+1
Tsz-Wo
On Sat, Jan 21, 2023 at 3:26 AM Siddharth Wagle <sw...@apache.org> wrote:
> +1 for the merge.
>
> - Sid
>
> On Fri, Jan 20, 2023 at 11:21 AM Uma Maheswara Rao Gangumalla <
> umagangumalla@gmail.com> wrote:
>
> > +1
> >
> > Regards,
> > Uma
> >
> > On Wed, Jan 18, 2023 at 11:08 AM Prashant Pogde
> > <pp...@cloudera.com.invalid>
> > wrote:
> >
> > >
> > > We would like to start this Vote thread for the proposal to merge
> > > https://issues.apache.org/jira/browse/HDDS-6517 <
> > > https://issues.apache.org/jira/browse/HDDS-6517> Ozone Snapshots.
> > >
> > > Ozone Snapshot feature allows us to take a point in time frozen image
> of
> > > the Ozone dataset. Initially this feature would allow snapshots to be
> > taken
> > > at bucket granularity. Subsequently the feature can support Snapshots
> > > at Volume level as well as the whole Ozone Namespace level.
> > >
> > > Note that HDDS-6517 is a new feature such that it is mainly adding new
> > > code. Therefore, the risk is very low to the existing functionalities
> > and
> > > features in Ozone.
> > >
> > > When the Snapshot feature is not used, it should cause no impact to the
> > > master.
> > > For more information, please check out Ozone Snapshot feature Jira
> > > (HDDS-6517) and feature wiki page here:
> > >
> > > https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots <
> > > https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots>
> > >
> > >
> > > Thanks,
> > > Ozone Snapshot Team
> >
>
Re: [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Siddharth Wagle <sw...@apache.org>.
+1 for the merge.
- Sid
On Fri, Jan 20, 2023 at 11:21 AM Uma Maheswara Rao Gangumalla <
umagangumalla@gmail.com> wrote:
> +1
>
> Regards,
> Uma
>
> On Wed, Jan 18, 2023 at 11:08 AM Prashant Pogde
> <pp...@cloudera.com.invalid>
> wrote:
>
> >
> > We would like to start this Vote thread for the proposal to merge
> > https://issues.apache.org/jira/browse/HDDS-6517 <
> > https://issues.apache.org/jira/browse/HDDS-6517> Ozone Snapshots.
> >
> > Ozone Snapshot feature allows us to take a point in time frozen image of
> > the Ozone dataset. Initially this feature would allow snapshots to be
> taken
> > at bucket granularity. Subsequently the feature can support Snapshots
> > at Volume level as well as the whole Ozone Namespace level.
> >
> > Note that HDDS-6517 is a new feature such that it is mainly adding new
> > code. Therefore, the risk is very low to the existing functionalities
> and
> > features in Ozone.
> >
> > When the Snapshot feature is not used, it should cause no impact to the
> > master.
> > For more information, please check out Ozone Snapshot feature Jira
> > (HDDS-6517) and feature wiki page here:
> >
> > https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots <
> > https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots>
> >
> >
> > Thanks,
> > Ozone Snapshot Team
>
Re: [VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Uma Maheswara Rao Gangumalla <um...@gmail.com>.
+1
Regards,
Uma
On Wed, Jan 18, 2023 at 11:08 AM Prashant Pogde <pp...@cloudera.com.invalid>
wrote:
>
> We would like to start this Vote thread for the proposal to merge
> https://issues.apache.org/jira/browse/HDDS-6517 <
> https://issues.apache.org/jira/browse/HDDS-6517> Ozone Snapshots.
>
> Ozone Snapshot feature allows us to take a point in time frozen image of
> the Ozone dataset. Initially this feature would allow snapshots to be taken
> at bucket granularity. Subsequently the feature can support Snapshots
> at Volume level as well as the whole Ozone Namespace level.
>
> Note that HDDS-6517 is a new feature such that it is mainly adding new
> code. Therefore, the risk is very low to the existing functionalities and
> features in Ozone.
>
> When the Snapshot feature is not used, it should cause no impact to the
> master.
> For more information, please check out Ozone Snapshot feature Jira
> (HDDS-6517) and feature wiki page here:
>
> https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots <
> https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots>
>
>
> Thanks,
> Ozone Snapshot Team
[VOTE] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Prashant Pogde <pp...@cloudera.com.INVALID>.
We would like to start this Vote thread for the proposal to merge
https://issues.apache.org/jira/browse/HDDS-6517 <https://issues.apache.org/jira/browse/HDDS-6517> Ozone Snapshots.
Ozone Snapshot feature allows us to take a point in time frozen image of
the Ozone dataset. Initially this feature would allow snapshots to be taken
at bucket granularity. Subsequently the feature can support Snapshots
at Volume level as well as the whole Ozone Namespace level.
Note that HDDS-6517 is a new feature such that it is mainly adding new
code. Therefore, the risk is very low to the existing functionalities and
features in Ozone.
When the Snapshot feature is not used, it should cause no impact to the master.
For more information, please check out Ozone Snapshot feature Jira
(HDDS-6517) and feature wiki page here:
https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots <https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots>
Thanks,
Ozone Snapshot Team
Re: [DISCUSS] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Ethan Rose <er...@cloudera.com.INVALID>.
Thanks for the updates Prashant. The wiki LGTM so I am +1 to proceed with a
vote.
On Wed, Jan 11, 2023 at 12:49 PM Prashant Pogde <pp...@cloudera.com.invalid>
wrote:
> Thanks for the feedback Ethan, Uma and Sid. I have updated the template on
> the wiki with Jira tickets to address these concerns.
>
> > On Jan 11, 2023, at 11:23 AM, Uma Maheswara Rao Gangumalla <
> umagangumalla@gmail.com> wrote:
> >
> > https://issues.apache.org/jira/browse/HDDS-6851 <
> https://issues.apache.org/jira/browse/HDDS-6851>
>
Re: [DISCUSS] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Uma Maheswara Rao Gangumalla <um...@gmail.com>.
Thank you Prashant for driving this feature! Great work.
Regards,
Uma
On Tue, Jan 17, 2023 at 11:21 AM Uma Maheswara Rao Gangumalla <
umagangumalla@gmail.com> wrote:
> Thank you for the Edits Preshant. Proposal looks good to me.
>
> I am +1 on this Snapshots feature branch merge. It is really a great
> addition to Ozone.
> This will keep Ozone at a great position with respective key features
> available in the system. I am super excited to see this feature in one of
> our upcoming releases.
>
> Great work by the entire Snapshots team and community !
>
> Regards,
> Uma
>
> On Wed, Jan 11, 2023 at 12:49 PM Prashant Pogde
> <pp...@cloudera.com.invalid> wrote:
>
>> Thanks for the feedback Ethan, Uma and Sid. I have updated the template
>> on the wiki with Jira tickets to address these concerns.
>>
>> > On Jan 11, 2023, at 11:23 AM, Uma Maheswara Rao Gangumalla <
>> umagangumalla@gmail.com> wrote:
>> >
>> > https://issues.apache.org/jira/browse/HDDS-6851 <
>> https://issues.apache.org/jira/browse/HDDS-6851>
>>
>
Re: [DISCUSS] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Uma Maheswara Rao Gangumalla <um...@gmail.com>.
Thank you for the Edits Preshant. Proposal looks good to me.
I am +1 on this Snapshots feature branch merge. It is really a great
addition to Ozone.
This will keep Ozone at a great position with respective key features
available in the system. I am super excited to see this feature in one of
our upcoming releases.
Great work by the entire Snapshots team and community !
Regards,
Uma
On Wed, Jan 11, 2023 at 12:49 PM Prashant Pogde <pp...@cloudera.com.invalid>
wrote:
> Thanks for the feedback Ethan, Uma and Sid. I have updated the template on
> the wiki with Jira tickets to address these concerns.
>
> > On Jan 11, 2023, at 11:23 AM, Uma Maheswara Rao Gangumalla <
> umagangumalla@gmail.com> wrote:
> >
> > https://issues.apache.org/jira/browse/HDDS-6851 <
> https://issues.apache.org/jira/browse/HDDS-6851>
>
Re: [DISCUSS] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Prashant Pogde <pp...@cloudera.com.INVALID>.
Thanks for the feedback Ethan, Uma and Sid. I have updated the template on the wiki with Jira tickets to address these concerns.
> On Jan 11, 2023, at 11:23 AM, Uma Maheswara Rao Gangumalla <um...@gmail.com> wrote:
>
> https://issues.apache.org/jira/browse/HDDS-6851 <https://issues.apache.org/jira/browse/HDDS-6851>
Re: [DISCUSS] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Uma Maheswara Rao Gangumalla <um...@gmail.com>.
Hi Prashant,
Thanks for proposing Snapshots feature merge.
Here few minors from me regarding the Wiki:
*>5. docker-compose / acceptance tests*
>This is work in progress.
Do we have open JIRA for this to track? Could you please point here?
*>2. documentation*
>Documentaion can be found under the Attachments section in the umbrella
jira: HDDS-6517 <https://issues.apache.org/jira/browse/HDDS-6517> - Snapshot
support for Ozone OPEN
Nit: Could you please give a specific JIRA link, rather than an umbrella.
Regarding the security: I see this access model JIRA(HDDS-6851
<https://issues.apache.org/jira/browse/HDDS-6851>) . This JIRA can be
linked to the *security considerations* section and provide the plan for
this.
Regards,
Uma
On Wed, Jan 11, 2023 at 10:07 AM Siddharth Wagle <sw...@apache.org> wrote:
> +1 on the need to address upgrade concerns in the wiki. Snapshots should be
> usable only after finalization.
>
> Whether a layout feature is needed or not, IMO if no current on-disk layout
> has changed we should not need it. Ethan?
>
> Best,
> Sid
>
> On Wed, Jan 11, 2023 at 9:53 AM Ethan Rose <er...@cloudera.com.invalid>
> wrote:
>
> > Hey Prashant, thanks for all the work on this feature. I think the
> > confluence page needs a few updates for completeness.
> > >
> > > *2. documentation*
> > >
> > > Documentaion can be found under the Attachments section in the umbrella
> > > jira: HDDS-6517 <https://issues.apache.org/jira/browse/HDDS-6517> -
> > Snapshot
> > > support for Ozone OPEN
> > >
> >
> > This bullet refers to user facing documentation to be added to
> > https://ozone.apache.org/docs/current/. It is not the same as "3.
> design,
> > attached the docs". If the docs are not done yet, I think a link to an
> open
> > jira would be sufficient.
> >
> > > *9. possible incompatible changes/used feature flag: *
> > >
> > > There should not be any incompatible changes introduced with this
> > feature.
> > >
> > > An enable/disable switch is not required. Snapshot feature has its
> > > independent se of CLIs that need not be exercised.
> > >
> >
> > I'm not sure what the merge template intends for the difference between 9
> > and 4 is. Anyways, it looks like snapshots will need a layout feature to
> > make sure it is not used before Ozone has been finalized. Again, I think
> > linking to an open jira would be sufficient here. If it can be done
> without
> > a layout feature somehow, an explanation in this part of the page would
> be
> > good.
> >
> > With these minor updates I think the merge would be good to go.
> >
> > Ethan
> >
> >
> > On Tue, Jan 10, 2023 at 2:56 PM Prashant Pogde
> <ppogde@cloudera.com.invalid
> > >
> > wrote:
> >
> > > Dear Ozone Devs,
> > >
> > > We would like to start this discussion thread for the proposal to merge
> > > https://issues.apache.org/jira/browse/HDDS-6517 Ozone Snapshots.
> > >
> > > Ozone Snapshot feature allows us to take a point in time frozen image
> of
> > > the Ozone dataset. Initially this feature would allow snapshots to be
> > taken
> > > at bucket granularity. Subsequently the feature can support Snapshots
> > > at Volume level as well as the whole Ozone Namespace level.
> > >
> > > Note that HDDS-6517 is a new feature such that it is mainly adding new
> > > code. Therefore, the risk is very low to the existing functionalities
> > and
> > > features in Ozone.
> > >
> > > When the Snapshot feature is not used, it should cause no impact to the
> > > master.
> > > For more information, please check out Ozone Snapshot feature Jira
> > > (HDDS-6517) and feature wiki page here:
> > >
> > > https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots
> > >
> > > If there are no objections for the merge, we could start the official
> > vote.
> > >
> > > Thanks,
> > > Ozone Snapshot Team
> >
>
Re: [DISCUSS] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Siddharth Wagle <sw...@apache.org>.
+1 on the need to address upgrade concerns in the wiki. Snapshots should be
usable only after finalization.
Whether a layout feature is needed or not, IMO if no current on-disk layout
has changed we should not need it. Ethan?
Best,
Sid
On Wed, Jan 11, 2023 at 9:53 AM Ethan Rose <er...@cloudera.com.invalid>
wrote:
> Hey Prashant, thanks for all the work on this feature. I think the
> confluence page needs a few updates for completeness.
> >
> > *2. documentation*
> >
> > Documentaion can be found under the Attachments section in the umbrella
> > jira: HDDS-6517 <https://issues.apache.org/jira/browse/HDDS-6517> -
> Snapshot
> > support for Ozone OPEN
> >
>
> This bullet refers to user facing documentation to be added to
> https://ozone.apache.org/docs/current/. It is not the same as "3. design,
> attached the docs". If the docs are not done yet, I think a link to an open
> jira would be sufficient.
>
> > *9. possible incompatible changes/used feature flag: *
> >
> > There should not be any incompatible changes introduced with this
> feature.
> >
> > An enable/disable switch is not required. Snapshot feature has its
> > independent se of CLIs that need not be exercised.
> >
>
> I'm not sure what the merge template intends for the difference between 9
> and 4 is. Anyways, it looks like snapshots will need a layout feature to
> make sure it is not used before Ozone has been finalized. Again, I think
> linking to an open jira would be sufficient here. If it can be done without
> a layout feature somehow, an explanation in this part of the page would be
> good.
>
> With these minor updates I think the merge would be good to go.
>
> Ethan
>
>
> On Tue, Jan 10, 2023 at 2:56 PM Prashant Pogde <ppogde@cloudera.com.invalid
> >
> wrote:
>
> > Dear Ozone Devs,
> >
> > We would like to start this discussion thread for the proposal to merge
> > https://issues.apache.org/jira/browse/HDDS-6517 Ozone Snapshots.
> >
> > Ozone Snapshot feature allows us to take a point in time frozen image of
> > the Ozone dataset. Initially this feature would allow snapshots to be
> taken
> > at bucket granularity. Subsequently the feature can support Snapshots
> > at Volume level as well as the whole Ozone Namespace level.
> >
> > Note that HDDS-6517 is a new feature such that it is mainly adding new
> > code. Therefore, the risk is very low to the existing functionalities
> and
> > features in Ozone.
> >
> > When the Snapshot feature is not used, it should cause no impact to the
> > master.
> > For more information, please check out Ozone Snapshot feature Jira
> > (HDDS-6517) and feature wiki page here:
> >
> > https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots
> >
> > If there are no objections for the merge, we could start the official
> vote.
> >
> > Thanks,
> > Ozone Snapshot Team
>
Re: [DISCUSS] Proposal to merge HDDS-6517 Ozone Snapshots
Posted by Ethan Rose <er...@cloudera.com.INVALID>.
Hey Prashant, thanks for all the work on this feature. I think the
confluence page needs a few updates for completeness.
>
> *2. documentation*
>
> Documentaion can be found under the Attachments section in the umbrella
> jira: HDDS-6517 <https://issues.apache.org/jira/browse/HDDS-6517> - Snapshot
> support for Ozone OPEN
>
This bullet refers to user facing documentation to be added to
https://ozone.apache.org/docs/current/. It is not the same as "3. design,
attached the docs". If the docs are not done yet, I think a link to an open
jira would be sufficient.
> *9. possible incompatible changes/used feature flag: *
>
> There should not be any incompatible changes introduced with this feature.
>
> An enable/disable switch is not required. Snapshot feature has its
> independent se of CLIs that need not be exercised.
>
I'm not sure what the merge template intends for the difference between 9
and 4 is. Anyways, it looks like snapshots will need a layout feature to
make sure it is not used before Ozone has been finalized. Again, I think
linking to an open jira would be sufficient here. If it can be done without
a layout feature somehow, an explanation in this part of the page would be
good.
With these minor updates I think the merge would be good to go.
Ethan
On Tue, Jan 10, 2023 at 2:56 PM Prashant Pogde <pp...@cloudera.com.invalid>
wrote:
> Dear Ozone Devs,
>
> We would like to start this discussion thread for the proposal to merge
> https://issues.apache.org/jira/browse/HDDS-6517 Ozone Snapshots.
>
> Ozone Snapshot feature allows us to take a point in time frozen image of
> the Ozone dataset. Initially this feature would allow snapshots to be taken
> at bucket granularity. Subsequently the feature can support Snapshots
> at Volume level as well as the whole Ozone Namespace level.
>
> Note that HDDS-6517 is a new feature such that it is mainly adding new
> code. Therefore, the risk is very low to the existing functionalities and
> features in Ozone.
>
> When the Snapshot feature is not used, it should cause no impact to the
> master.
> For more information, please check out Ozone Snapshot feature Jira
> (HDDS-6517) and feature wiki page here:
>
> https://cwiki.apache.org/confluence/display/OZONE/Ozone+Snapshots
>
> If there are no objections for the merge, we could start the official vote.
>
> Thanks,
> Ozone Snapshot Team