You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2018/03/28 10:25:22 UTC
Review Request 66330: Added 'OPENSSL_INCLUDE_DIR' to forwarded
arguments.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66330/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
Repository: mesos
Description
-------
To help third-party dependencies find and build with OpenSSL, certain
options are forwarded to them. Dependencies using the 'FindOpenSSL'
module need either 'OPENSSL_ROOT_DIR' or 'OPENSSL_INCLUDE_DIR' to figure
out the location of OpenSSL. In the module 'OPENSSL_ROOT_DIR' acts as a
hint for 'OPENSSL_INCLUDE_DIR'. I.e., 'OPENSSL_INCLUDE_DIR' will be set
by the module. As a consequence, if 'OPENSSL_ROOT_DIR' is not configured
in 'ccmake', users will only be prompted to provide
'OPENSSL_INCLUDE_DIR'. By forwarding 'OPENSSL_INCLUDE_DIR' we cover this
case for third-party dependencies, thus allowing users to configure the
project in 'ccmake' without having to explicitly set 'OPENSSL_ROOT_DIR'.
Diffs
-----
3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270
Diff: https://reviews.apache.org/r/66330/diff/1/
Testing
-------
On macOS 10.13.3 with OpenSSL installed via Homebrew:
$ mkdir build && cd build
$ ccmake -GNinja ..
* Press "c" to configure.
* Switch on "ENABLE_LIBEVENT" and "ENABLE_SSL".
* Press "c" to configure. There will be an error explaining that 'OPENSSL_ROOT_DIR' or 'OPENSSL_INCLUDE_DIR' is missing.
* `ccmake` will ask for "OPENSSL_INCLUDE_DIR", set it to `/usr/local/opt/openssl/include` (assuming `$(brew --prefix) == /usr/local`)
* Press "c" to configure again. There shouldn't be an error now.
* Press "g" to generate the configuration.
$ ninja
Thanks,
Jan Schlicht
Re: Review Request 66330: Added 'OPENSSL_INCLUDE_DIR' to forwarded
arguments.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66330/#review200103
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66330']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66330
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66330/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (106 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1032 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (34 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (73 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (729 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (749 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (738 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (759 ms total)
[----------] Global test environment tear-down
[==========] 949 tests from 94 test cases ran. (432065 ms total)
[ PASSED ] 948 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 214 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66330/logs/mesos-tests-stderr.log):
```
I0328 11:26:06.442183 6340 master.cpp:10446] Updating the state of task 8c06a3ee-f4e1-4a99-9fdd-cc47139d860a of framework b2e9d685-31a1-47a6-9ff6-2dd902f1eca1-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0328 11:26:06.442183 5784 slave.cpp:3873] Shutting down framework b2e9d685-31a1-47a6-9ff6-2dd902f1eca1-0000
I0328 11:26:06.442183 5784 slave.cpp:6566] Shutting down executor '8c06a3ee-f4e1-4a99-9fdd-cc47139d860a' of framework b2e9d685-31a1-47a6-9ff6-2dd902f1eca1-0000 at executor(1)@10.3.1.5:53147
I0328 11:26:06.443179 5784 slave.cpp:919] Agent terminating
W0328 11:26:06.443179 5784 slave.cpp:3869] Ignoring shutdown framework b2e9d685-I0328 11:26:06.261209 5788 exec.cpp:162] Version: 1.6.0
I0328 11:26:06.290184 1524 exec.cpp:236] Executor registered on agent b2e9d685-31a1-47a6-9ff6-2dd902f1eca1-S0
I0328 11:26:06.295212 7020 executor.cpp:176] Received SUBSCRIBED event
I0328 11:26:06.299214 7020 executor.cpp:180] Subscribed executor on winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0328 11:26:06.300212 7020 executor.cpp:176] Received LAUNCH event
I0328 11:26:06.304214 7020 executor.cpp:648] Starting task 8c06a3ee-f4e1-4a99-9fdd-cc47139d860a
I0328 11:26:06.387215 7020 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0328 11:26:06.415185 7020 executor.cpp:661] Forked command at 1264
I0328 11:26:06.444386 7332 exec.cpp:445] Executor asked to shutdown
I0328 11:26:06.445185 6840 executor.cpp:176] Received SHUTDOWN event
I0328 11:26:06.445185 6840 executor.cpp:758] Shutting down
I0328 11:26:06.445185 6840 executor.cpp:868] Sending SIGTERM to process tree at pid 131a1-47a6-9ff6-2dd902f1eca1-0000 because it is terminating
I0328 11:26:06.445185 6340 master.cpp:10545] Removing task 8c06a3ee-f4e1-4a99-9fdd-cc47139d860a with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework b2e9d685-31a1-47a6-9ff6-2dd902f1eca1-0000 on agent b2e9d685-31a1-47a6-9ff6-2dd902f1eca1-S0 at slave(418)@10.3.1.5:53126 (winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0328 11:26:06.447180 7492 containerizer.cpp:2338] Destroying container 530b8daa-5bc1-4b99-8b07-4ad3f1332471 in RUNNING state
I0328 11:26:06.447180 7492 containerizer.cpp:2952] Transitioning the state of container 530b8daa-5bc1-4b99-8b07-4ad3f1332471 from RUNNING to DESTROYING
I0328 11:26:06.448185 7492 launcher.cpp:156] Asked to destroy container 530b8daa-5bc1-4b99-8b07-4ad3f1332471
I0328 11:26:06.448185 6340 master.cpp:1295] Agent b2e9d685-31a1-47a6-9ff6-2dd902f1eca1-S0 at slave(418)@10.3.1.5:53126 (winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0328 11:26:06.448185 6376 hierarchical.cpp:344] Removed framework b2e9d685-31a1-47a6-9ff6-2dd902f1eca1-0000
I0328 11:26:06.449183 6340 master.cpp:3283] Disconnecting agent b2e9d685-31a1-47a6-9ff6-2dd902f1eca1-S0 at slave(418)@10.3.1.5:53126 (winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0328 11:26:06.449183 6340 master.cpp:3302] Deactivating agent b2e9d685-31a1-47a6-9ff6-2dd902f1eca1-S0 at slave(418)@10.3.1.5:53126 (winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0328 11:26:06.449183 4480 hierarchical.cpp:766] Agent b2e9d685-31a1-47a6-9ff6-2dd902f1eca1-S0 deactivated
I0328 11:26:06.474201 2340 containerizer.cpp:2791] Container 530b8daa-5bc1-4b99-8b07-4ad3f1332471 has exited
I0328 11:26:06.505228 5416 master.cpp:1137] Master terminating
I0328 11:26:06.507186 5784 hierarchical.cpp:609] Removed agent b2e9d685-31a1-47a6-9ff6-2dd902f1eca1-S0
I0328 11:26:06.918210 5228 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 28, 2018, 6:25 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66330/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 6:25 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To help third-party dependencies find and build with OpenSSL, certain
> options are forwarded to them. Dependencies using the 'FindOpenSSL'
> module need either 'OPENSSL_ROOT_DIR' or 'OPENSSL_INCLUDE_DIR' to figure
> out the location of OpenSSL. In the module 'OPENSSL_ROOT_DIR' acts as a
> hint for 'OPENSSL_INCLUDE_DIR'. I.e., 'OPENSSL_INCLUDE_DIR' will be set
> by the module. As a consequence, if 'OPENSSL_ROOT_DIR' is not configured
> in 'ccmake', users will only be prompted to provide
> 'OPENSSL_INCLUDE_DIR'. By forwarding 'OPENSSL_INCLUDE_DIR' we cover this
> case for third-party dependencies, thus allowing users to configure the
> project in 'ccmake' without having to explicitly set 'OPENSSL_ROOT_DIR'.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270
>
>
> Diff: https://reviews.apache.org/r/66330/diff/1/
>
>
> Testing
> -------
>
> On macOS 10.13.3 with OpenSSL installed via Homebrew:
>
> $ mkdir build && cd build
> $ ccmake -GNinja ..
>
> * Press "c" to configure.
> * Switch on "ENABLE_LIBEVENT" and "ENABLE_SSL".
> * Press "c" to configure. There will be an error explaining that 'OPENSSL_ROOT_DIR' or 'OPENSSL_INCLUDE_DIR' is missing.
> * `ccmake` will ask for "OPENSSL_INCLUDE_DIR", set it to `/usr/local/opt/openssl/include` (assuming `$(brew --prefix) == /usr/local`)
> * Press "c" to configure again. There shouldn't be an error now.
> * Press "g" to generate the configuration.
>
> $ ninja
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 66330: Added 'OPENSSL_INCLUDE_DIR' to forwarded
arguments.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66330/#review200106
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66330]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 28, 2018, 2:01 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66330/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 2:01 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To help third-party dependencies find and build with OpenSSL, certain
> options are forwarded to them. Dependencies using the 'FindOpenSSL'
> module need either 'OPENSSL_ROOT_DIR' or 'OPENSSL_INCLUDE_DIR' to figure
> out the location of OpenSSL. In the module 'OPENSSL_ROOT_DIR' acts as a
> hint for 'OPENSSL_INCLUDE_DIR'. I.e., 'OPENSSL_INCLUDE_DIR' will be set
> by the module. As a consequence, if 'OPENSSL_ROOT_DIR' is not configured
> in 'ccmake', users will only be prompted to provide
> 'OPENSSL_INCLUDE_DIR'. By forwarding 'OPENSSL_INCLUDE_DIR' we cover this
> case for third-party dependencies, thus allowing users to configure the
> project in 'ccmake' without having to explicitly set 'OPENSSL_ROOT_DIR'.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270
>
>
> Diff: https://reviews.apache.org/r/66330/diff/2/
>
>
> Testing
> -------
>
> On macOS 10.13.3 with OpenSSL installed via Homebrew:
>
> $ mkdir build && cd build
> $ ccmake -GNinja ..
>
> * Press "c" to configure.
> * Switch on "ENABLE_LIBEVENT" and "ENABLE_SSL".
> * Press "c" to configure. There will be an error explaining that 'OPENSSL_ROOT_DIR' or 'OPENSSL_INCLUDE_DIR' is missing.
> * `ccmake` will ask for "OPENSSL_INCLUDE_DIR", set it to `/usr/local/opt/openssl/include` (assuming `$(brew --prefix) == /usr/local`)
> * Press "c" to configure again. There shouldn't be an error now.
> * Press "g" to generate the configuration.
>
> $ ninja
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 66330: Added 'OPENSSL_INCLUDE_DIR' to forwarded
arguments.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66330/#review200107
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66330']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66330
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66330/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (111 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1042 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (74 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (821 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (844 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (841 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (868 ms total)
[----------] Global test environment tear-down
[==========] 949 tests from 94 test cases ran. (446888 ms total)
[ PASSED ] 948 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 214 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66330/logs/mesos-tests-stderr.log):
```
I0328 13:09:00.105005 7800 slave.cpp:3873] Shutting down framework 455c7620-eeb9-43ae-acf0-a11bb2beb09a-0000
I0328 13:09:00.105005 9184 master.cpp:10446] Updating the state of task 7d6e0af3-5187-4b61-b278-365dfd6ed40e of framework 455c7620-eeb9-43ae-acf0-a11bI0328 13:08:59.923991 5256 exec.cpp:162] Version: 1.6.0
I0328 13:08:59.950994 7400 exec.cpp:236] Executor registered on agent 455c7620-eeb9-43ae-acf0-a11bb2beb09a-S0
I0328 13:08:59.954962 7660 executor.cpp:176] Received SUBSCRIBED event
I0328 13:08:59.959987 7660 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0328 13:08:59.960988 7660 executor.cpp:176] Received LAUNCH event
I0328 13:08:59.965994 7660 executor.cpp:648] Starting task 7d6e0af3-5187-4b61-b278-365dfd6ed40e
I0328 13:09:00.044960 7660 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0328 13:09:00.075968 7660 executor.cpp:661] Forked command at 2340
I0328 13:09:00.106968 10068 exec.cpp:445] Executor asked to shutdown
I0328 13:09:00.107987 9452 executor.cpp:176] Received SHUTDOWN event
I0328 13:09:00.107987 9452 executor.cpp:758] Shutting down
I0328 13:09:00.107987 9452 executor.cpp:868] Sending SIGTERM to process tree at pid 2b2beb09a-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0328 13:09:00.105005 7800 slave.cpp:6566] Shutting down executor '7d6e0af3-5187-4b61-b278-365dfd6ed40e' of framework 455c7620-eeb9-43ae-acf0-a11bb2beb09a-0000 at executor(1)@10.3.1.8:55309
I0328 13:09:00.106007 7800 slave.cpp:919] Agent terminating
W0328 13:09:00.106007 7800 slave.cpp:3869] Ignoring shutdown framework 455c7620-eeb9-43ae-acf0-a11bb2beb09a-0000 because it is terminating
I0328 13:09:00.108968 9184 master.cpp:10545] Removing task 7d6e0af3-5187-4b61-b278-365dfd6ed40e with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 455c7620-eeb9-43ae-acf0-a11bb2beb09a-0000 on agent 455c7620-eeb9-43ae-acf0-a11bb2beb09a-S0 at slave(418)@10.3.1.8:55288 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0328 13:09:00.110967 7852 containerizer.cpp:2338] Destroying container 6713fbe2-c330-42f4-9d84-8cbb0cd132ab in RUNNING state
I0328 13:09:00.110967 7852 containerizer.cpp:2952] Transitioning the state of container 6713fbe2-c330-42f4-9d84-8cbb0cd132ab from RUNNING to DESTROYING
I0328 13:09:00.111968 9184 master.cpp:1295] Agent 455c7620-eeb9-43ae-acf0-a11bb2beb09a-S0 at slave(418)@10.3.1.8:55288 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0328 13:09:00.111968 9184 master.cpp:3283] Disconnecting agent 455c7620-eeb9-43ae-acf0-a11bb2beb09a-S0 at slave(418)@10.3.1.8:55288 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0328 13:09:00.111968 9184 master.cpp:3302] Deactivating agent 455c7620-eeb9-43ae-acf0-a11bb2beb09a-S0 at slave(418)@10.3.1.8:55288 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0328 13:09:00.111968 8564 hierarchical.cpp:344] Removed framework 455c7620-eeb9-43ae-acf0-a11bb2beb09a-0000
I0328 13:09:00.111968 7852 launcher.cpp:156] Asked to destroy container 6713fbe2-c330-42f4-9d84-8cbb0cd132ab
I0328 13:09:00.111968 8516 hierarchical.cpp:766] Agent 455c7620-eeb9-43ae-acf0-a11bb2beb09a-S0 deactivated
I0328 13:09:00.192462 4324 containerizer.cpp:2791] Container 6713fbe2-c330-42f4-9d84-8cbb0cd132ab has exited
I0328 13:09:00.225419 264 master.cpp:1137] Master terminating
I0328 13:09:00.227445 6324 hierarchical.cpp:609] Removed agent 455c7620-eeb9-43ae-acf0-a11bb2beb09a-S0
I0328 13:09:00.601459 4664 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 28, 2018, 12:01 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66330/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 12:01 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To help third-party dependencies find and build with OpenSSL, certain
> options are forwarded to them. Dependencies using the 'FindOpenSSL'
> module need either 'OPENSSL_ROOT_DIR' or 'OPENSSL_INCLUDE_DIR' to figure
> out the location of OpenSSL. In the module 'OPENSSL_ROOT_DIR' acts as a
> hint for 'OPENSSL_INCLUDE_DIR'. I.e., 'OPENSSL_INCLUDE_DIR' will be set
> by the module. As a consequence, if 'OPENSSL_ROOT_DIR' is not configured
> in 'ccmake', users will only be prompted to provide
> 'OPENSSL_INCLUDE_DIR'. By forwarding 'OPENSSL_INCLUDE_DIR' we cover this
> case for third-party dependencies, thus allowing users to configure the
> project in 'ccmake' without having to explicitly set 'OPENSSL_ROOT_DIR'.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270
>
>
> Diff: https://reviews.apache.org/r/66330/diff/2/
>
>
> Testing
> -------
>
> On macOS 10.13.3 with OpenSSL installed via Homebrew:
>
> $ mkdir build && cd build
> $ ccmake -GNinja ..
>
> * Press "c" to configure.
> * Switch on "ENABLE_LIBEVENT" and "ENABLE_SSL".
> * Press "c" to configure. There will be an error explaining that 'OPENSSL_ROOT_DIR' or 'OPENSSL_INCLUDE_DIR' is missing.
> * `ccmake` will ask for "OPENSSL_INCLUDE_DIR", set it to `/usr/local/opt/openssl/include` (assuming `$(brew --prefix) == /usr/local`)
> * Press "c" to configure again. There shouldn't be an error now.
> * Press "g" to generate the configuration.
>
> $ ninja
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 66330: Added 'OPENSSL_INCLUDE_DIR' to forwarded
arguments.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66330/#review200111
-----------------------------------------------------------
Ship it!
- Benjamin Bannier
On March 28, 2018, 2:01 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66330/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 2:01 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To help third-party dependencies find and build with OpenSSL, certain
> options are forwarded to them. Dependencies using the 'FindOpenSSL'
> module need either 'OPENSSL_ROOT_DIR' or 'OPENSSL_INCLUDE_DIR' to figure
> out the location of OpenSSL. In the module 'OPENSSL_ROOT_DIR' acts as a
> hint for 'OPENSSL_INCLUDE_DIR'. I.e., 'OPENSSL_INCLUDE_DIR' will be set
> by the module. As a consequence, if 'OPENSSL_ROOT_DIR' is not configured
> in 'ccmake', users will only be prompted to provide
> 'OPENSSL_INCLUDE_DIR'. By forwarding 'OPENSSL_INCLUDE_DIR' we cover this
> case for third-party dependencies, thus allowing users to configure the
> project in 'ccmake' without having to explicitly set 'OPENSSL_ROOT_DIR'.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270
>
>
> Diff: https://reviews.apache.org/r/66330/diff/2/
>
>
> Testing
> -------
>
> On macOS 10.13.3 with OpenSSL installed via Homebrew:
>
> $ mkdir build && cd build
> $ ccmake -GNinja ..
>
> * Press "c" to configure.
> * Switch on "ENABLE_LIBEVENT" and "ENABLE_SSL".
> * Press "c" to configure. There will be an error explaining that 'OPENSSL_ROOT_DIR' or 'OPENSSL_INCLUDE_DIR' is missing.
> * `ccmake` will ask for "OPENSSL_INCLUDE_DIR", set it to `/usr/local/opt/openssl/include` (assuming `$(brew --prefix) == /usr/local`)
> * Press "c" to configure again. There shouldn't be an error now.
> * Press "g" to generate the configuration.
>
> $ ninja
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 66330: Added 'OPENSSL_INCLUDE_DIR' to forwarded
arguments.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66330/
-----------------------------------------------------------
(Updated March 28, 2018, 2:01 p.m.)
Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
Changes
-------
Added a comment.
Repository: mesos
Description
-------
To help third-party dependencies find and build with OpenSSL, certain
options are forwarded to them. Dependencies using the 'FindOpenSSL'
module need either 'OPENSSL_ROOT_DIR' or 'OPENSSL_INCLUDE_DIR' to figure
out the location of OpenSSL. In the module 'OPENSSL_ROOT_DIR' acts as a
hint for 'OPENSSL_INCLUDE_DIR'. I.e., 'OPENSSL_INCLUDE_DIR' will be set
by the module. As a consequence, if 'OPENSSL_ROOT_DIR' is not configured
in 'ccmake', users will only be prompted to provide
'OPENSSL_INCLUDE_DIR'. By forwarding 'OPENSSL_INCLUDE_DIR' we cover this
case for third-party dependencies, thus allowing users to configure the
project in 'ccmake' without having to explicitly set 'OPENSSL_ROOT_DIR'.
Diffs (updated)
-----
3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270
Diff: https://reviews.apache.org/r/66330/diff/2/
Changes: https://reviews.apache.org/r/66330/diff/1-2/
Testing
-------
On macOS 10.13.3 with OpenSSL installed via Homebrew:
$ mkdir build && cd build
$ ccmake -GNinja ..
* Press "c" to configure.
* Switch on "ENABLE_LIBEVENT" and "ENABLE_SSL".
* Press "c" to configure. There will be an error explaining that 'OPENSSL_ROOT_DIR' or 'OPENSSL_INCLUDE_DIR' is missing.
* `ccmake` will ask for "OPENSSL_INCLUDE_DIR", set it to `/usr/local/opt/openssl/include` (assuming `$(brew --prefix) == /usr/local`)
* Press "c" to configure again. There shouldn't be an error now.
* Press "g" to generate the configuration.
$ ninja
Thanks,
Jan Schlicht