You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/06 06:17:41 UTC

[GitHub] [kafka] chia7712 opened a new pull request #10637: MINOR: remove storage/src/generated from tracked files

chia7712 opened a new pull request #10637:
URL: https://github.com/apache/kafka/pull/10637


   related to #10271
   
   The generated code from other modules have beed excluded from tracked files.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 merged pull request #10637: MINOR: remove storage/src/generated from tracked files

Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #10637:
URL: https://github.com/apache/kafka/pull/10637


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #10637: MINOR: remove storage/src/generated from tracked files

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10637:
URL: https://github.com/apache/kafka/pull/10637#issuecomment-837691327


   Is it possible to set up the gitignore to automatically ignore anything under a `generated/` subdirectory?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kowshik commented on pull request #10637: MINOR: remove storage/src/generated from tracked files

Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #10637:
URL: https://github.com/apache/kafka/pull/10637#issuecomment-833982538


   @chia7712 Thanks for the PR. LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #10637: MINOR: remove storage/src/generated from tracked files

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10637:
URL: https://github.com/apache/kafka/pull/10637#issuecomment-837994346


   > Is it possible to set up the gitignore to automatically ignore anything under a generated/ subdirectory?
   
   please take a look at #10671


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #10637: MINOR: remove storage/src/generated from tracked files

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10637:
URL: https://github.com/apache/kafka/pull/10637#issuecomment-833258233


   @satishd @kowshik FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org