You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/23 10:07:45 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1106: build: Remve the unnecessary .gitignore
xiaoxiang781216 opened a new pull request #1106:
URL: https://github.com/apache/incubator-nuttx/pull/1106
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
## Summary
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #1106: build: Remve the unnecessary .gitignore
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1106:
URL: https://github.com/apache/incubator-nuttx/pull/1106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1106: build: Remve the unnecessary .gitignore
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1106:
URL: https://github.com/apache/incubator-nuttx/pull/1106#issuecomment-633080975
Don, you are right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1106: build: Remve the unnecessary .gitignore
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1106:
URL: https://github.com/apache/incubator-nuttx/pull/1106#issuecomment-633074089
*.exe was removed from the sub-directories and is not present in the top-level, I think it should be there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1106: build: Remve the unnecessary .gitignore
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1106:
URL: https://github.com/apache/incubator-nuttx/pull/1106#discussion_r429564780
##########
File path: libs/libnx/nxfonts/.gitignore
##########
@@ -1,3 +1,2 @@
nxfonts_convert_*bpp.c
nxfonts_bitmaps_*.c
-nxfonts_tom-thumb-4x6.c
Review comment:
The file was renamed. (See #1109 )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1106: build: Remve the unnecessary .gitignore
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #1106:
URL: https://github.com/apache/incubator-nuttx/pull/1106#issuecomment-633043724
The following items exist in many .gitignore files, I move them to the lop level:
*.adb
*.dSYM
*.lib
*.lod
*.lst
*.obj
*.rel
*.src
*.swp
*.sym
*.wsp
If some file use these suffix in a particular folder, we can still use ! to negative .gitignored in that folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1106: build: Remve the unnecessary .gitignore
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1106:
URL: https://github.com/apache/incubator-nuttx/pull/1106#issuecomment-633043724
The following items exist in many .gitignore file, I move them to the lop level:
*.adb
*.dSYM
*.lib
*.lod
*.lst
*.obj
*.rel
*.src
*.swp
*.sym
*.wsp
If some file use these suffix in a particular folder, we can still use ! to negative .gitignored in that folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1106: build: Remve the unnecessary .gitignore
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1106:
URL: https://github.com/apache/incubator-nuttx/pull/1106#issuecomment-633036103
@xiaoxiang781216 just to make sure, nothing has changed from the top level .gitignore? You just re-organized it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1106: build: Remve the unnecessary .gitignore
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1106:
URL: https://github.com/apache/incubator-nuttx/pull/1106#discussion_r429562107
##########
File path: libs/libnx/nxfonts/.gitignore
##########
@@ -1,3 +1,2 @@
nxfonts_convert_*bpp.c
nxfonts_bitmaps_*.c
-nxfonts_tom-thumb-4x6.c
Review comment:
@xiaoxiang781216 Do we need to add this file or re-ignore it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1106: build: Remve the unnecessary .gitignore
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1106:
URL: https://github.com/apache/incubator-nuttx/pull/1106#discussion_r429562328
##########
File path: libs/libnx/nxfonts/.gitignore
##########
@@ -1,3 +1,2 @@
nxfonts_convert_*bpp.c
nxfonts_bitmaps_*.c
-nxfonts_tom-thumb-4x6.c
Review comment:
It's auto-generated, I think it should be ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1106: build: Remve the unnecessary .gitignore
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1106:
URL: https://github.com/apache/incubator-nuttx/pull/1106#discussion_r429562107
##########
File path: libs/libnx/nxfonts/.gitignore
##########
@@ -1,3 +1,2 @@
nxfonts_convert_*bpp.c
nxfonts_bitmaps_*.c
-nxfonts_tom-thumb-4x6.c
Review comment:
@xiaoxiang781216 Do we need to add this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #1106: build: Remve the unnecessary .gitignore
Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on pull request #1106:
URL: https://github.com/apache/incubator-nuttx/pull/1106#issuecomment-633036103
@xiaoxiang781216 just to make sure, nothing was removed from the top level .gitignore? You just re-organized it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org