You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@groovy.apache.org by Guillaume Laforge <gl...@gmail.com> on 2019/10/31 09:06:53 UTC

Re: [apache/groovy] GROOVY-9296: [GEP] Import `TypeChecked`, `CompileStatic` and `Compile… (#1056)

Hmm, I wouldn't commit that straight away, Daniel.
I'd also like to have Paul's thoughts on this.
There's also some past conversations on this topic, existing issues (like
GROOVY-5503 <https://issues.apache.org/jira/browse/GROOVY-5503>).
It's already to set flags in different ways to enable that (config script,
compiler customizers, etc), so it's not like we can't do it already in a
way or another.

Guillaume


On Thu, Oct 31, 2019 at 4:39 AM Daniel.Sun <no...@github.com> wrote:

> …Dynamic` by default
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/apache/groovy/pull/1056
> Commit Summary
>
>    - GROOVY-9296: [GEP] Import `TypeChecked`, `CompileStatic` and
>    `CompileDynamic` by default
>
> File Changes
>
>    - *M*
>    src/main/java/org/codehaus/groovy/control/CompilerConfiguration.java
>    <https://github.com/apache/groovy/pull/1056/files#diff-0> (19)
>    - *A* src/test/groovy/bugs/Groovy9296.groovy
>    <https://github.com/apache/groovy/pull/1056/files#diff-1> (55)
>
> Patch Links:
>
>    - https://github.com/apache/groovy/pull/1056.patch
>    - https://github.com/apache/groovy/pull/1056.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/groovy/pull/1056?email_source=notifications&email_token=AAALWI4EPASTXJNYGF3QCNTQRJHPVA5CNFSM4JHDX4GKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HVUMFHA>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAALWI2YND2PKQQDG4NJYMDQRJHPVANCNFSM4JHDX4GA>
> .
>


-- 
Guillaume Laforge
Apache Groovy committer
Developer Advocate @ Google Cloud Platform

Blog: http://glaforge.appspot.com/
Twitter: @glaforge <http://twitter.com/glaforge>

Re: [apache/groovy] GROOVY-9296: [GEP] Import `TypeChecked`, `CompileStatic` and `Compile… (#1056)

Posted by "Daniel.Sun" <su...@apache.org>.

Hi all,

    I've given up the proposal. Maybe slowing down the steps and fixing
existing bugs can please most of users and devs. 

Cheers,
Daniel.Sun



-----
Apache Groovy committer & PMC member 
Blog: http://blog.sunlan.me 
Twitter: @daniel_sun 

--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Re: [apache/groovy] GROOVY-9296: [GEP] Import `TypeChecked`, `CompileStatic` and `Compile… (#1056)

Posted by "Daniel.Sun" <su...@apache.org>.

Hi Guillaume,

The proposal is to use `@TypeChecked`, `@CompileStatic` and
`@CompileDynamic` conveniently. Though we can enable STC via config script
or flags, the solutions can not 100% cover the use cases of the proposal.

Anyway, no worries. It's just a proposal. If the proposal can not get +1 PMC
votes, the feature will not be added to Groovy 4 ;-)

Cheers,
Daniel.Sun




-----
Apache Groovy committer & PMC member 
Blog: http://blog.sunlan.me 
Twitter: @daniel_sun 

--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Re: [apache/groovy] GROOVY-9296: [GEP] Import `TypeChecked`, `CompileStatic` and `Compile… (#1056)

Posted by Guillaume Laforge <gl...@gmail.com>.

It's certainly a common request, that said, for example I just found a
question on Stackoverflow here:
https://stackoverflow.com/questions/11866901/is-there-any-global-flag-for-groovy-static-compilation
This one shows how to do that with Gradle.

Guillaume

On Thu, Oct 31, 2019 at 10:06 AM Guillaume Laforge <gl...@gmail.com>
wrote:

> Hmm, I wouldn't commit that straight away, Daniel.
> I'd also like to have Paul's thoughts on this.
> There's also some past conversations on this topic, existing issues (like
> GROOVY-5503 <https://issues.apache.org/jira/browse/GROOVY-5503>).
> It's already to set flags in different ways to enable that (config script,
> compiler customizers, etc), so it's not like we can't do it already in a
> way or another.
>
> Guillaume
>
>
> On Thu, Oct 31, 2019 at 4:39 AM Daniel.Sun <no...@github.com>
> wrote:
>
>> …Dynamic` by default
>> ------------------------------
>> You can view, comment on, or merge this pull request online at:
>>
>>   https://github.com/apache/groovy/pull/1056
>> Commit Summary
>>
>>    - GROOVY-9296: [GEP] Import `TypeChecked`, `CompileStatic` and
>>    `CompileDynamic` by default
>>
>> File Changes
>>
>>    - *M*
>>    src/main/java/org/codehaus/groovy/control/CompilerConfiguration.java
>>    <https://github.com/apache/groovy/pull/1056/files#diff-0> (19)
>>    - *A* src/test/groovy/bugs/Groovy9296.groovy
>>    <https://github.com/apache/groovy/pull/1056/files#diff-1> (55)
>>
>> Patch Links:
>>
>>    - https://github.com/apache/groovy/pull/1056.patch
>>    - https://github.com/apache/groovy/pull/1056.diff
>>
>> —
>> You are receiving this because you are subscribed to this thread.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/groovy/pull/1056?email_source=notifications&email_token=AAALWI4EPASTXJNYGF3QCNTQRJHPVA5CNFSM4JHDX4GKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HVUMFHA>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AAALWI2YND2PKQQDG4NJYMDQRJHPVANCNFSM4JHDX4GA>
>> .
>>
>
>
> --
> Guillaume Laforge
> Apache Groovy committer
> Developer Advocate @ Google Cloud Platform
>
> Blog: http://glaforge.appspot.com/
> Twitter: @glaforge <http://twitter.com/glaforge>
>


-- 
Guillaume Laforge
Apache Groovy committer
Developer Advocate @ Google Cloud Platform

Blog: http://glaforge.appspot.com/
Twitter: @glaforge <http://twitter.com/glaforge>