You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by remibergsma <gi...@git.apache.org> on 2015/08/17 16:29:48 UTC
[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/706
Closing PRs older than 1 month and without activity
As proposed here: http://cloudstack.markmail.org/search/?q=#query:+page:1+mid:rkptskqvajs7n7zj+state:results
This will close these PRs:
https://github.com/apache/cloudstack/pull/577
https://github.com/apache/cloudstack/pull/566
https://github.com/apache/cloudstack/pull/562
https://github.com/apache/cloudstack/pull/561
https://github.com/apache/cloudstack/pull/556
https://github.com/apache/cloudstack/pull/555
https://github.com/apache/cloudstack/pull/554
https://github.com/apache/cloudstack/pull/548
https://github.com/apache/cloudstack/pull/544
https://github.com/apache/cloudstack/pull/540
https://github.com/apache/cloudstack/pull/508
https://github.com/apache/cloudstack/pull/384
https://github.com/apache/cloudstack/pull/372
If you want a PR to stay open, comment to the PR and let me know.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/remibergsma/cloudstack close-old-PRs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/706.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #706
----
commit 8ade5dcf474843857ed46ca224afcefa4196c309
Author: Remi Bergsma <gi...@remi.nl>
Date: 2015-08-17T13:54:37Z
Closing PRs older than a month without activity
This closes #577
This closes #566
This closes #562
This closes #561
This closes #556
This closes #555
This closes #554
This closes #548
This closes #544
This closes #540
This closes #508
This closes #384
This closes #372
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/706#issuecomment-134964553
@bhaisaab @remibergsma : Rohit has some good points there and some that can be avoided. Noticably a PR that hasn't gotten any attention from the community should not be closed. But when several people have given feedback and the author does not respond it is of a different case. Let's revisit if the present backlog groth continues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/706#issuecomment-134915109
All, let's not do this for multiple reasons;
- by closing a PR which has not got attention we risk forgetting about it and losing the contribution
- generally those of us who have worked for long in the community or have dayjob colleagues working in the community, have better chances in getting their PRs merged; for new contributors this pattern is not encouraging and certainly not welcoming if their PRs get closed just because it did not caught any attention in one month's time
- our community works on the premise that everyone is a contributor working as per their convenience, interest and time, on top of this the developer community is not very large to ensure that all PRs will get attention or review within a months time of its arrival
- the requirement of 2 LGTM on each review makes it too much process-oriented that costs time and efforts, sometimes fixes are small but getting them merged has taken more time
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/706#issuecomment-131860676
https://github.com/apache/cloudstack/pull/508 was worked on 14 days ago by @resmo and @wilderrodrigues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/706#issuecomment-134919031
@bhaisaab OK, let's leave it for now and discuss later. I will close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/706
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/706#issuecomment-131866061
I did not send a :-1: to dev@. I did not omit that mail by mistake (sorry for the double negative). the proposal seems radical (17 july is phased out on 17 August) but house cleaning is needed. let's make a PR like this on a weekly basis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/706#issuecomment-131868071
@DaanHoogland Weekly basis is OK with me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/706#issuecomment-131864636
@DaanHoogland That's true. Although @wilderrodrigues will take over the PR and needs to create a new one. But let's stick to the proposal indeed. I'll remove #508 from the list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---