You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by wuchong <gi...@git.apache.org> on 2016/09/01 08:36:02 UTC
[GitHub] flink pull request #2454: [FLINK-4546] [table] Remove STREAM keyword in Stre...
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2454
[FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
This PR remove STREAM keyword in Stream SQL and update the documentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink remove-stream
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2454.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2454
----
commit c1b0179876a94482211aadc079c4ec4f7dbf07d1
Author: Jark Wu <wu...@alibaba-inc.com>
Date: 2016-08-29T03:35:43Z
[table] remove STREAM keyword in StreamSQL, i.e. use batch sql parser for stream job
commit b5ba0ddc6ba80f4dfacc4a8c711f8f391c3e64ab
Author: Jark Wu <wu...@alibaba-inc.com>
Date: 2016-09-01T08:33:26Z
update docs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2454
Hi @fhueske @twalthr , do you have time to have a look again? Any advices are welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2454
Thank @wuchong. Looks good to merge. @fhueske do you also want to have a look at it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2454: [FLINK-4546] [table] Remove STREAM keyword in Stre...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2454#discussion_r77494182
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/FlinkRuleSets.scala ---
@@ -112,7 +112,7 @@ object FlinkRuleSets {
*/
val DATASTREAM_OPT_RULES: RuleSet = RuleSets.ofList(
- RemoveDeltaRule.INSTANCE,
--- End diff --
The `RemoveDeltaRule` class can be removed as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2454: [FLINK-4546] [table] Remove STREAM keyword in Stre...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2454#discussion_r77507678
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/DataStreamTable.scala ---
@@ -18,22 +18,11 @@
package org.apache.flink.api.table.plan.schema
-import org.apache.calcite.rel.`type`.{RelDataType, RelDataTypeFactory}
-import org.apache.flink.api.table.FlinkTypeFactory
import org.apache.flink.streaming.api.datastream.DataStream
class DataStreamTable[T](
val dataStream: DataStream[T],
override val fieldIndexes: Array[Int],
override val fieldNames: Array[String])
extends FlinkTable[T](dataStream.getType, fieldIndexes, fieldNames) {
-
- override def getRowType(typeFactory: RelDataTypeFactory): RelDataType = {
--- End diff --
Because this override method is almost the same with super method. I remove it to keep consistent with `DataSetTable` which do not override the `getRowType` method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2454
Hi @fhueske , thanks for reviewing, I updated this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2454
Hi @wuchong, thanks for the PR. Just had two minor comments. Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2454: [FLINK-4546] [table] Remove STREAM keyword in Stre...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2454#discussion_r77494279
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/DataStreamTable.scala ---
@@ -18,22 +18,11 @@
package org.apache.flink.api.table.plan.schema
-import org.apache.calcite.rel.`type`.{RelDataType, RelDataTypeFactory}
-import org.apache.flink.api.table.FlinkTypeFactory
import org.apache.flink.streaming.api.datastream.DataStream
class DataStreamTable[T](
val dataStream: DataStream[T],
override val fieldIndexes: Array[Int],
override val fieldNames: Array[String])
extends FlinkTable[T](dataStream.getType, fieldIndexes, fieldNames) {
-
- override def getRowType(typeFactory: RelDataTypeFactory): RelDataType = {
--- End diff --
Why did you remove this method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2454
It seems that Calcite is planning to add additional clauses to the SQL statement. Like `SELECT STREAM x FROM y EMIT xyz`. If we really remove the keyword we have to make sure that Calcite's parser will also parse `EMIT` without the `STREAM` keyword.
@fhueske what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2454: [FLINK-4546] [table] Remove STREAM keyword in Stre...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2454
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2454: [FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2454
Thanks @wuchong. Will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---