[GitHub] [druid] suneet-s commented on a change in pull request #10743: fix limited queries with subtotals

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #10743:
URL: https://github.com/apache/druid/pull/10743#discussion_r556004791



##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -16281,6 +16281,71 @@ public void testTimeStampAddConversion() throws Exception
     );
   }
 
+  @Test
+  public void testGroupingSetsWithLimit() throws Exception

Review comment:
       Skimming through the code - I think we should add some tests to test the iterators built for a query with an `ORDER BY` on dimensions that are part of the grouping sets (like `dim2`) and for something that isn't (like `SUM(cnt)` or another dimension) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org