[Impala-ASF-CR] IMPALA-12356: Fix first ALTER PARTITION event from Hive could be treated as self event

["Anonymous Coward (Code Review)" <ge...@cloudera.org>]

Hello Quanlong Huang, Sai Hemanth Gantasala, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20486

to look at the new patch set (#12).

Change subject: IMPALA-12356: Fix first ALTER_PARTITION event from Hive could be treated as self event
......................................................................

IMPALA-12356: Fix first ALTER_PARTITION event from Hive could be
treated as self event

Self event check for add partition event is done only for the
transactional tables with IMPALA-10502 (commit id: 7f7a631). But
during addition of new partition(with insert statement), catalog
service id and version number are added to partition params of the
parition irrespective of whether the table is transactional or not.
Thus the version number is added to partition's inFlightEvents_ and
remained in it until the next alter partition event from hive. Thus
led to detection of the alter partition event as self event.

This commit ensures the catalog service id and version number are not
added to partition params if the partition is added to a
non-transactinal table.

Also fixed another bug in reload event. Reload event self check
fails due to the above fix as it expects catalog service id and
version number in the partition params. Fixed to use last refreshed
event id to skip the self reload events.

Testing:
- Manually tested in cluster and added testcases

Change-Id: I23c2affa3fe32c0b3843bff5e4c0018dce9060d3
---
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_events_custom_configs.py
M tests/metadata/test_event_processing.py
6 files changed, 102 insertions(+), 62 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/20486/12
-- 
To view, visit http://gerrit.cloudera.org:8080/20486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I23c2affa3fe32c0b3843bff5e4c0018dce9060d3
Gerrit-Change-Number: 20486
Gerrit-PatchSet: 12
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>