[GitHub] [inlong] leosanqing commented on a diff in pull request #4869: [INLONG-4867][Manager] Add restrictions to the naming of some key fields

[GitBox <gi...@apache.org>]

leosanqing commented on code in PR #4869:
URL: https://github.com/apache/inlong/pull/4869#discussion_r913410073


##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/InlongGroupRequest.java:
##########
@@ -46,10 +46,9 @@
 public class InlongGroupRequest {
 
     @ApiModelProperty(value = "Inlong group id", required = true)
-    @Length(min = 4, max = 200)
-    @Pattern(regexp = "^(?![0-9]+$)[a-z][a-z0-9_-]{1,200}$",
-            message = "inlongGroupId must starts with a lowercase letter "
-                    + "and contains only lowercase letters, digits, `-` or `_`")
+    @Length(min = 4, max = 100, message = "inlongGroupId length must be between 4 and 100")

Review Comment:
   Please add @NotBlank，Otherwise, if null, the length check will be bypassed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org