You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "mridulpathak (via GitHub)" <gi...@apache.org> on 2026/09/13 16:39:43 UTC

[PR] Fixed: Mini-lang to Groovy regressions in ProductStoreServices (OFBIZ-13576) [ofbiz-framework]

mridulpathak opened a new pull request, #1974:
URL: https://github.com/apache/ofbiz-framework/pull/1974

   - createProductStore: check parameters.showPricesWithVatTax (matching the
     entity field name) instead of the nonexistent showPriceWithVatTax, so the
     VAT tax authority validation actually runs.
   - reserveStoreInventory: guard the no-facility-has-enough-inventory fallback
     against a null productStore.inventoryFacilityId, which threw an NPE
     whenever the store had no configured default facility; still prefer the
     store's own configured facility per OFBIZ-12264's intent, now falling
     back further to the first configured ProductStoreFacility only when no
     default facility is set.
   - checkProductStoreRelatedPermission: resolve productStoreIdToCheck via the
     dynamic productStoreIdName key instead of a literal, misspelled
     inputParameter.productstoreIdName, restoring the CATALOG_ROLE-based
     override to actually receive a productStoreId.
   - checkProductStoreRelatedPermission: drop the redundant second
     EntityUtil.filterByDate() call, which used field names ("roleFromDate"/
     "roleThruDate") that don't exist on ProductStoreRole and crashed with an
     IllegalArgumentException whenever a role match was found; the preceding
     query already filters by the entity's real fromDate/thruDate fields.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fixed: Mini-lang to Groovy regressions in ProductStoreServices (OFBIZ-13576) [ofbiz-framework]

Posted by "mridulpathak (via GitHub)" <gi...@apache.org>.
mridulpathak merged PR #1974:
URL: https://github.com/apache/ofbiz-framework/pull/1974


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org