You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/09 18:31:10 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request #986: Rename NthValue::{first_value,last_value,nth_value} to satisfy clippy in Rust 1.55
alamb opened a new pull request #986:
URL: https://github.com/apache/arrow-datafusion/pull/986
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/985
# Rationale for this change
CI should be clean
# What changes are included in this PR?
I tried to port the changes from @Igosuki in #910 to minimize merge conflicts
# Are there any user-facing changes?
function names change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #986: Rename NthValue::{first_value,last_value,nth_value} to satisfy clippy in Rust 1.55
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #986:
URL: https://github.com/apache/arrow-datafusion/pull/986#issuecomment-916430726
I am going to merge this in to get CI green on master again; The actual change has already been discussed in the context of https://github.com/apache/arrow-datafusion/pull/910#discussion_r697964506 so I think there is consensus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #986: Rename NthValue::{first_value,last_value,nth_value} to satisfy clippy in Rust 1.55
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #986:
URL: https://github.com/apache/arrow-datafusion/pull/986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org