You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/11/21 02:47:19 UTC

[GitHub] spark pull request #22149: [SPARK-25158][SQL]Executor accidentally exit beca...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22149#discussion_r235238304
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala ---
    @@ -308,6 +308,12 @@ private class ScriptTransformationWriterThread(
           }
           threwException = false
         } catch {
    +      // TaskKilledException should not be thrown again, otherwise it will be captured by
    +      // SparkUncaughtExceptionHandler, then Executor will exit because of TaskKilledException.
    +      case e: TaskKilledException =>
    --- End diff --
    
    which line of code may throw this exception? and how is this exception handled in other operators?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org