You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "zouyx (GitHub)" <gi...@apache.org> on 2020/02/29 15:21:20 UTC
[GitHub] [dubbo-go] zouyx opened pull request #382: Add: optimize
load config file
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/382 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #382: Add: optimize
load config file
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/382?src=pr&el=h1) Report
> Merging [#382](https://codecov.io/gh/apache/dubbo-go/pull/382?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/af5510b434e47b6be3a80daa3478c6668f320d27?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `61.53%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/382?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #382 +/- ##
===========================================
- Coverage 66.81% 66.78% -0.04%
===========================================
Files 157 157
Lines 8242 8237 -5
===========================================
- Hits 5507 5501 -6
- Misses 2209 2212 +3
+ Partials 526 524 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/382?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/condition\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/382/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmRpdGlvbl9yb3V0ZXJfY29uZmlnLmdv) | `84.61% <100%> (ø)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/382/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `58.06% <100%> (+5.28%)` | :arrow_up: |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/382/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `55.31% <100%> (+3.39%)` | :arrow_up: |
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/382/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `63.15% <50%> (-0.08%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/382/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `64.7% <0%> (-8.83%)` | :arrow_down: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/382/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0%> (-3.39%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/382?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/382?src=pr&el=footer). Last update [af5510b...3964718](https://codecov.io/gh/apache/dubbo-go/pull/382?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/382 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #382: Add: optimize
load config file
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
LGTM
[ Full content available at: https://github.com/apache/dubbo-go/pull/382 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed pull request #382: Add:
optimize load config file
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
[ pull request closed by AlexStocks ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/382 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org