You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2020/08/05 10:10:15 UTC

[GitHub] [syncope] DimaAy opened a new pull request #210: [SYNCOPE-1584] WA events management

DimaAy opened a new pull request #210:
URL: https://github.com/apache/syncope/pull/210


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [syncope] ilgrosso commented on a change in pull request #210: [SYNCOPE-1584] WA events management

Posted by GitBox <gi...@apache.org>.
ilgrosso commented on a change in pull request #210:
URL: https://github.com/apache/syncope/pull/210#discussion_r465686359



##########
File path: wa/starter/src/main/java/org/apache/syncope/wa/starter/config/SyncopeWAConfiguration.java
##########
@@ -196,6 +200,19 @@ public AuditTrailExecutionPlanConfigurer auditConfigurer(final WARestClient rest
         return plan -> plan.registerAuditTrailManager(new SyncopeWAAuditTrailManager(restClient));
     }
 
+    @ConditionalOnMissingBean(name = "syncopWaEventRepositoryFilter")
+    @Bean
+    public CasEventRepositoryFilter syncopWaEventRepositoryFilter() {

Review comment:
       just rename this method as `syncopeWAEventRepositoryFilter()`

##########
File path: wa/starter/src/main/java/org/apache/syncope/wa/starter/events/SyncopeWAEventsRepository.java
##########
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.wa.starter.events;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import java.util.Collection;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.syncope.client.lib.SyncopeClient;
+import org.apache.syncope.common.lib.log.AuditEntry;
+import org.apache.syncope.common.lib.types.AuditElements;
+import org.apache.syncope.common.lib.types.AuditLoggerName;
+import org.apache.syncope.common.rest.api.service.LoggerService;
+import org.apache.syncope.wa.bootstrap.WARestClient;
+import org.apereo.cas.support.events.CasEventRepositoryFilter;
+import org.apereo.cas.support.events.dao.AbstractCasEventRepository;
+import org.apereo.cas.support.events.dao.CasEvent;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class SyncopeWAEventsRepository extends AbstractCasEventRepository {

Review comment:
       Please rename this class as `SyncopeWAEventRepository`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [syncope] DimaAy merged pull request #210: [SYNCOPE-1584] WA events management

Posted by GitBox <gi...@apache.org>.
DimaAy merged pull request #210:
URL: https://github.com/apache/syncope/pull/210


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org