You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2021/11/05 16:01:00 UTC
[jira] [Comment Edited] (MRELEASE-1053) scm element removed during
release:prepare when leveraging custom inheritance rules
[ https://issues.apache.org/jira/browse/MRELEASE-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17439347#comment-17439347 ]
Konrad Windszus edited comment on MRELEASE-1053 at 11/5/21, 4:00 PM:
---------------------------------------------------------------------
I debugged a bit further and in this case indeed https://github.com/apache/maven-release/blob/44ff401499713c981732f3379de2cf6693e0fdef/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForDevelopmentPhase.java#L61 returned {{null}}.
This is caused by {{buildScm}} returning {{null}} for every project in the reactor in https://github.com/apache/maven-release/blob/a9e30c63ea8071234e9a7bb1f433178963ecf93c/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/AbstractScmReleaseMojo.java#L178 due to https://github.com/apache/maven-release/blob/a9e30c63ea8071234e9a7bb1f433178963ecf93c/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/AbstractScmReleaseMojo.java#L188 being always true (i.e. project.getOriginalModel().getScm() returning {{null}} for all reactor modules including the parent module itself)
was (Author: kwin):
I debugged a bit further and in this case indeed https://github.com/apache/maven-release/blob/44ff401499713c981732f3379de2cf6693e0fdef/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForDevelopmentPhase.java#L61 returned {{null}}.
> scm element removed during release:prepare when leveraging custom inheritance rules
> -----------------------------------------------------------------------------------
>
> Key: MRELEASE-1053
> URL: https://issues.apache.org/jira/browse/MRELEASE-1053
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 3.0.0-M1
> Reporter: Konrad Windszus
> Priority: Major
>
> When leveraging the custom inheritance rules being introduced with MNG-6059 the m-release-p removes the {{scm}} element from the pom.xml during {{release:prepare}}.
> You find an example for that behaviour at https://github.com/apache/jackrabbit-filevault/commit/3a175724d8d3608bc96e92ed7fd9154fd56d1e30#diff-04dc5d029560773ac79faaf3da0fbb22L68
--
This message was sent by Atlassian Jira
(v8.3.4#803005)