You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/08/07 21:26:16 UTC

[GitHub] [openwhisk-wskdeploy] huydoan2 opened a new pull request #1100: Added interpolation to docker option in manifest.yaml

huydoan2 opened a new pull request #1100:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1100


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1100: Added interpolation to docker option in manifest.yaml

Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1100:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1100#issuecomment-675666477


   @huydoan2 Could you please update the docs to indicate this value can now be interpolated? Here is the file I was thinking of:
   https://github.com/apache/openwhisk-wskdeploy/blob/master/docs/wskdeploy_interpolation.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-wskdeploy] mrutkows commented on a change in pull request #1100: Added interpolation to docker option in manifest.yaml

Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #1100:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1100#discussion_r472423913



##########
File path: parsers/manifest_parser.go
##########
@@ -29,6 +29,8 @@ import (
 
 	"gopkg.in/yaml.v2"
 
+	"net/url"

Review comment:
       better ordering of dependencies

##########
File path: parsers/manifest_parser.go
##########
@@ -796,7 +797,7 @@ func (dm *YAMLParser) composeActionExec(manifestFilePath string, manifestFileNam
 		if action.Native {
 			exec.Image = NATIVE_DOCKER_IMAGE
 		} else {
-			exec.Image = action.Docker
+			exec.Image = wskenv.InterpolateStringWithEnvVar(action.Docker).(string)

Review comment:
       Interpolation feature in 1 line!  Nice!

##########
File path: parsers/manifest_parser_test.go
##########
@@ -960,8 +960,15 @@ func TestComposeActionsForDocker(t *testing.T) {
 			assert.NotNil(t, action.Action.Exec.Code, TEST_MSG_ACTION_CODE_MISSING)
 			assert.Equal(t, runtimes.BLACKBOX, action.Action.Exec.Kind, fmt.Sprintf(TEST_MSG_ACTION_DOCKER_KIND_MISMATCH, action.Action.Exec.Kind))
 			assert.Equal(t, "mydockerhub/myimage", action.Action.Exec.Image, TEST_MSG_ACTION_DOCKER_IMAGE_MISMATCH)
+		case "CustomDockerAction6":

Review comment:
       Thanks for adding a unit test




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1100: Added interpolation to docker option in manifest.yaml

Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1100:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1100#issuecomment-671404594


   @huydoan2 It appears that one of the go libs. has updated its dependencies and now only works with go 1.13:
   https://github.com/stretchr/testify/issues/991


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1100: Added interpolation to docker option in manifest.yaml

Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1100:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1100#issuecomment-675658873


   @huydoan2 It looks like the commit includes files from your other PR... it seems like you need to push from a rebased branch...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-wskdeploy] mrutkows edited a comment on pull request #1100: Added interpolation to docker option in manifest.yaml

Posted by GitBox <gi...@apache.org>.
mrutkows edited a comment on pull request #1100:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1100#issuecomment-671404594


   @huydoan2 It appears that one of the go libs. wskdeploy uses has updated its dependencies and now only works with go 1.13:
   https://github.com/stretchr/testify/issues/991


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-wskdeploy] mrutkows merged pull request #1100: Added interpolation to docker option in manifest.yaml

Posted by GitBox <gi...@apache.org>.
mrutkows merged pull request #1100:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1100


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org