You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/06 23:39:16 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4795:
Enhance RoutingTable to use ServerInstance
codecov-io edited a comment on issue #4795: Enhance RoutingTable to use ServerInstance
URL: https://github.com/apache/incubator-pinot/pull/4795#issuecomment-550550755
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4795?src=pr&el=h1) Report
> Merging [#4795](https://codecov.io/gh/apache/incubator-pinot/pull/4795?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/4445fdcc465a481e25cd8e25257f6bc7d7d184e5?src=pr&el=desc) will **decrease** coverage by `7.96%`.
> The diff coverage is `81.73%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4795?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4795 +/- ##
============================================
- Coverage 57.81% 49.84% -7.97%
Complexity 4 4
============================================
Files 1209 1211 +2
Lines 64965 65590 +625
Branches 9460 9560 +100
============================================
- Hits 37558 32694 -4864
- Misses 24554 30323 +5769
+ Partials 2853 2573 -280
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4795?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...esthandler/ConnectionPoolBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4795/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQ29ubmVjdGlvblBvb2xCcm9rZXJSZXF1ZXN0SGFuZGxlci5qYXZh) | `0% <ø> (-88.2%)` | `0 <0> (ø)` | |
| [...thandler/SingleConnectionBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4795/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvU2luZ2xlQ29ubmVjdGlvbkJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `13.63% <ø> (-75%)` | `0 <0> (ø)` | |
| [...ing/builder/DefaultOfflineRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4795/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL0RlZmF1bHRPZmZsaW5lUm91dGluZ1RhYmxlQnVpbGRlci5qYXZh) | `45.09% <ø> (-1.97%)` | `0 <0> (ø)` | |
| [...ng/builder/DefaultRealtimeRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4795/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL0RlZmF1bHRSZWFsdGltZVJvdXRpbmdUYWJsZUJ1aWxkZXIuamF2YQ==) | `30.95% <ø> (-35.72%)` | `0 <0> (ø)` | |
| [.../pinot/transport/config/PerTableRoutingConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4795/diff?src=pr&el=tree#diff-cGlub3QtdHJhbnNwb3J0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90cmFuc3BvcnQvY29uZmlnL1BlclRhYmxlUm91dGluZ0NvbmZpZy5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...c/main/java/org/apache/pinot/tools/Quickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4795/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1F1aWNrc3RhcnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4795/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `14.61% <0%> (-62.7%)` | `0 <0> (ø)` | |
| [.../broker/routing/HelixExternalViewBasedRouting.java](https://codecov.io/gh/apache/incubator-pinot/pull/4795/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUm91dGluZy5qYXZh) | `46.66% <0%> (-43.22%)` | `0 <0> (ø)` | |
| [...der/PartitionAwareRealtimeRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4795/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL1BhcnRpdGlvbkF3YXJlUmVhbHRpbWVSb3V0aW5nVGFibGVCdWlsZGVyLmphdmE=) | `85.18% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/pinot/core/transport/QueryRouter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4795/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvUXVlcnlSb3V0ZXIuamF2YQ==) | `93.44% <100%> (+0.22%)` | `0 <0> (ø)` | :arrow_down: |
| ... and [305 more](https://codecov.io/gh/apache/incubator-pinot/pull/4795/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4795?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4795?src=pr&el=footer). Last update [4445fdc...affd850](https://codecov.io/gh/apache/incubator-pinot/pull/4795?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org