You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/03/24 01:05:26 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #4790: [AIRFLOW-3968][2/3] Refactor base GCP hook

mik-laj commented on a change in pull request #4790: [AIRFLOW-3968][2/3] Refactor base GCP hook
URL: https://github.com/apache/airflow/pull/4790#discussion_r268414576
 
 

 ##########
 File path: airflow/contrib/hooks/gcp_api_base_hook.py
 ##########
 @@ -27,6 +27,8 @@
 import os
 import tempfile
 
+from oauth2client.client import GOOGLE_APPLICATION_CREDENTIALS
 
 Review comment:
   I updated a PR. 
   In addition, I added a new point to the list of changes:
   > some tests were dependent on the database. I added a mock. In the future I will try to fix the constructor. It should not connect to the database

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services