You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "rickyma (via GitHub)" <gi...@apache.org> on 2024/05/09 11:50:37 UTC
[PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
rickyma opened a new pull request, #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687
### What changes were proposed in this pull request?
Support pending tasks number metrics for Netty EventLoopGroup.
### Why are the changes needed?
For https://github.com/apache/incubator-uniffle/issues/1686.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manually in my env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on code in PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#discussion_r1595463308
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -89,6 +89,13 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(10 * 1000L)
.withDescription("Direct memory usage tracker interval to MetricSystem (ms)");
+ public static final ConfigOption<Long> SERVER_NETTY_PENDING_TASKS_NUM_TRACKER_INTERVAL =
+ ConfigOptions.key("rss.server.netty.pending.tasks.num.updateMetricsIntervalMs")
Review Comment:
I followed the naming of `rss.server.netty.directMemoryTracker.memoryUsage.updateMetricsIntervalMs`.
Maybe `rss.server.netty.pending.tasks.num.polling.interval`? If we continue to simplify the naming of this variable, I'm afraid it might become difficult to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#discussion_r1596172386
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -89,6 +89,13 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(10 * 1000L)
.withDescription("Direct memory usage tracker interval to MetricSystem (ms)");
+ public static final ConfigOption<Long> SERVER_NETTY_PENDING_TASKS_NUM_TRACKER_INTERVAL =
+ ConfigOptions.key("rss.server.netty.pending.tasks.num.updateMetricsIntervalMs")
Review Comment:
How about `rss.server.netty.metrics.pendingTaskNumPollingIntervalMs`? Only the last name is camel. The former name segments can use more common word.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#issuecomment-2103789894
> LGTM, Do you think we should include this in the branch 0.9?
Either is fine. Of course it will be nice to have this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on code in PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#discussion_r1595463308
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -89,6 +89,13 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(10 * 1000L)
.withDescription("Direct memory usage tracker interval to MetricSystem (ms)");
+ public static final ConfigOption<Long> SERVER_NETTY_PENDING_TASKS_NUM_TRACKER_INTERVAL =
+ ConfigOptions.key("rss.server.netty.pending.tasks.num.updateMetricsIntervalMs")
Review Comment:
I followed the name `rss.server.netty.directMemoryTracker.memoryUsage.updateMetricsIntervalMs`.
Maybe `rss.server.netty.pending.tasks.num.polling.interval`? If we continue to simplify the naming of this variable, I'm afraid it might become difficult to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on code in PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#discussion_r1596189601
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -89,6 +89,13 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(10 * 1000L)
.withDescription("Direct memory usage tracker interval to MetricSystem (ms)");
+ public static final ConfigOption<Long> SERVER_NETTY_PENDING_TASKS_NUM_TRACKER_INTERVAL =
+ ConfigOptions.key("rss.server.netty.pending.tasks.num.updateMetricsIntervalMs")
Review Comment:
OK. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#issuecomment-2102567375
## Test Results
2 391 files ±0 2 391 suites ±0 4h 41m 33s :stopwatch: +37s
925 tests ±0 923 :white_check_mark: - 1 1 :zzz: ±0 1 :x: + 1
10 712 runs ±0 10 684 :white_check_mark: - 14 14 :zzz: ±0 14 :x: +14
For more details on these failures, see [this check](https://github.com/apache/incubator-uniffle/runs/24775388586).
Results for commit c11dee70. ± Comparison against base commit 30bf8dcc.
[test-results]:data:application/gzip;base64,H4sIACbBPGYC/1XMyQ7CIBSF4VdpWLvgMhV8GVMvkBA7GIaV8d2lpmBdno/L/yI+zC6R68C4gctAUgn5vG2JUw7bWgWUNrxSfc/7hWGyrVsqiF/iP3qE5/6rg5/C/Acuxi1WoVViWfcm0BHYMVsUqNKi21Ht0KodzlXcliXkOggCWOdGqi0zVKOwyou7mZxlHgRyOqL2QkpB3h8MHAw+EwEAAA==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#issuecomment-2104000729
> Could you add the document for this config option?
We missed docs for `rss.server.netty.directMemoryTracker.memoryUsage.initialFetchDelayMs` and `rss.server.netty.directMemoryTracker.memoryUsage.updateMetricsIntervalMs` too. Is this doc for interval configurations necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#issuecomment-2103972986
Could you add the document for this config option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#issuecomment-2104131314
> > Could you add the document for this config option?
>
> We missed docs for `rss.server.netty.directMemoryTracker.memoryUsage.initialFetchDelayMs` and `rss.server.netty.directMemoryTracker.memoryUsage.updateMetricsIntervalMs` too. Is this doc for interval configurations necessary?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#discussion_r1595364661
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -89,6 +89,13 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(10 * 1000L)
.withDescription("Direct memory usage tracker interval to MetricSystem (ms)");
+ public static final ConfigOption<Long> SERVER_NETTY_PENDING_TASKS_NUM_TRACKER_INTERVAL =
+ ConfigOptions.key("rss.server.netty.pending.tasks.num.updateMetricsIntervalMs")
Review Comment:
Could you use a more brief name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on code in PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#discussion_r1595386493
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -89,6 +89,13 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(10 * 1000L)
.withDescription("Direct memory usage tracker interval to MetricSystem (ms)");
+ public static final ConfigOption<Long> SERVER_NETTY_PENDING_TASKS_NUM_TRACKER_INTERVAL =
+ ConfigOptions.key("rss.server.netty.pending.tasks.num.updateMetricsIntervalMs")
Review Comment:
Maybe `NETTY_PENDING_TASKS_NUM_TRACKER_INTERVAL`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#discussion_r1596172386
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -89,6 +89,13 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(10 * 1000L)
.withDescription("Direct memory usage tracker interval to MetricSystem (ms)");
+ public static final ConfigOption<Long> SERVER_NETTY_PENDING_TASKS_NUM_TRACKER_INTERVAL =
+ ConfigOptions.key("rss.server.netty.pending.tasks.num.updateMetricsIntervalMs")
Review Comment:
How about `rss.server.netty.metrics.pendingTaskNumPollingInterval`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#issuecomment-2105505224
Merged to master & branch 0.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#issuecomment-2104184359
Added. But only for my new added configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#discussion_r1595399475
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -89,6 +89,13 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(10 * 1000L)
.withDescription("Direct memory usage tracker interval to MetricSystem (ms)");
+ public static final ConfigOption<Long> SERVER_NETTY_PENDING_TASKS_NUM_TRACKER_INTERVAL =
+ ConfigOptions.key("rss.server.netty.pending.tasks.num.updateMetricsIntervalMs")
Review Comment:
Actually I means `rss.server.netty.pending.tasks.num.updateMetricsIntervalMs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#issuecomment-2103894777
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1687?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `81.08108%` with `7 lines` in your changes are missing coverage. Please review.
> Project coverage is 54.55%. Comparing base [(`6f6d35a`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/6f6d35aab8e9fe7002de3768e6d5a30cad2d4cb7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`2ccf5b3`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1687?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 9 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1687?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...rg/apache/uniffle/common/metrics/NettyMetrics.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1687?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Funiffle%2Fcommon%2Fmetrics%2FNettyMetrics.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9tZXRyaWNzL05ldHR5TWV0cmljcy5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/uniffle/server/netty/StreamServer.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1687?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Funiffle%2Fserver%2Fnetty%2FStreamServer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9uZXR0eS9TdHJlYW1TZXJ2ZXIuamF2YQ==) | 96.15% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1687 +/- ##
============================================
- Coverage 54.86% 54.55% -0.32%
- Complexity 2358 2749 +391
============================================
Files 368 411 +43
Lines 16379 21483 +5104
Branches 1504 2031 +527
============================================
+ Hits 8986 11719 +2733
- Misses 6862 9019 +2157
- Partials 531 745 +214
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1687?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1686] feat(netty): Support pending tasks number metrics for Netty EventLoopGroup [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1687:
URL: https://github.com/apache/incubator-uniffle/pull/1687#issuecomment-2104186732
If you want to add other configs in this PR. I'll be OK with that. Or use a new issue to track configs without docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org