You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/05 13:31:46 UTC
[GitHub] [incubator-doris] imay opened a new pull request #2837: Make cmake
and maven configurable
imay opened a new pull request #2837: Make cmake and maven configurable
URL: https://github.com/apache/incubator-doris/pull/2837
#2835
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #2837: Make cmake and
maven configurable
Posted by GitBox <gi...@apache.org>.
imay merged pull request #2837: Make cmake and maven configurable
URL: https://github.com/apache/incubator-doris/pull/2837
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request
#2837: Make cmake and maven configurable
Posted by GitBox <gi...@apache.org>.
HangyuanLiu commented on a change in pull request #2837: Make cmake and maven configurable
URL: https://github.com/apache/incubator-doris/pull/2837#discussion_r375280321
##########
File path: env.sh
##########
@@ -80,9 +80,23 @@ if [[ $JAVA_VER -lt 18 ]]; then
fi
# check maven
-export MVN=mvn
+MVN_CMD=mvn
+if [[ ! -z ${CUSTOM_MVN} ]]; then
+ MVN=${CUSTOM_MVN}
Review comment:
```suggestion
MVN_CMD=${CUSTOM_MVN}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org