You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/18 09:53:34 UTC
[GitHub] [incubator-seatunnel] Emor-nj opened a new pull request, #1911: [Feature] [spark-clickhouse]ClickhouseFile support ReplicatedMergeTree
Emor-nj opened a new pull request, #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911
## Purpose of this pull request
ClickhouseFile support ReplicatedMergeTree
fixes https://github.com/apache/incubator-seatunnel/issues/1910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1911: [Feature] [clickhouse| ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r881158598
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-clickhouse/src/main/java/org/apache/seatunnel/flink/clickhouse/sink/client/ClickhouseClient.java:
##########
@@ -212,4 +221,21 @@ public ClickhouseTable getClickhouseTable(String database, String table) {
}
+ /**
+ * Localization the engine in clickhouse local table's createTableDDL to support specific engine.
+ * For example: change ReplicatedMergeTree to MergeTree.
+ *
+ * @param engine original engine of clickhouse local table
+ * @param ddl createTableDDL of clickhouse local table
+ * @return createTableDDL of clickhouse local table which can support specific engine
+ * TODO: support more engine
+ */
+ public static String localizationEngine(String engine, String ddl) {
Review Comment:
Please remove the static, this is not a good practice, if you only want to call this method in UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan merged pull request #1911: [Feature] [clickhouse| ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
BenJFan merged PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Emor-nj commented on a diff in pull request #1911: [Feature] [spark-clickhouse||flink-clickhouse]ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
Emor-nj commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r879147091
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-clickhouse/src/main/java/org/apache/seatunnel/flink/clickhouse/sink/client/ClickhouseClient.java:
##########
@@ -212,4 +212,28 @@ public ClickhouseTable getClickhouseTable(String database, String table) {
}
+ public String getLocalTableCreateDDL(String localDatabase, String localTable) {
+ try (ClickHouseConnection connection = balancedClickhouseDataSource.getConnection();
+ ClickHouseStatement statement = connection.createStatement()) {
+ String sql = String.format("select engine,create_table_query from system.tables where database = '%s' and name = '%s'", localDatabase, localTable);
+ ResultSet resultSet = statement.executeQuery(sql);
+ if (!resultSet.next()) {
+ throw new RuntimeException("Cannot get table from clickhouse, resultSet is empty");
+ }
+ String localEngine = resultSet.getString(1);
+ String createLocalTableDDL = resultSet.getString(2);
+ return localizationEngine(createLocalTableDDL, localEngine);
+ } catch (SQLException e) {
+ throw new RuntimeException("Cannot get clickhouse table", e);
+ }
+ }
Review Comment:
Beacuse in line 107, if the parameter(config.getString(TABLE)) is DistributedTable, the createTableDDL(line 192 get) will be the ddl for DistributedTable but not LocalTable. So i get the localDatabase and localTable from the variable ‘clickhouseTable’ which get in line 107, and use them to get LocalTableCreateDDL from getLocalTableCreateDDL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1911: [Feature] [spark-clickhouse||flink-clickhouse]ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r879111348
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-clickhouse/src/main/java/org/apache/seatunnel/flink/clickhouse/sink/client/ClickhouseClient.java:
##########
@@ -212,4 +212,28 @@ public ClickhouseTable getClickhouseTable(String database, String table) {
}
+ public String getLocalTableCreateDDL(String localDatabase, String localTable) {
+ try (ClickHouseConnection connection = balancedClickhouseDataSource.getConnection();
+ ClickHouseStatement statement = connection.createStatement()) {
+ String sql = String.format("select engine,create_table_query from system.tables where database = '%s' and name = '%s'", localDatabase, localTable);
+ ResultSet resultSet = statement.executeQuery(sql);
+ if (!resultSet.next()) {
+ throw new RuntimeException("Cannot get table from clickhouse, resultSet is empty");
+ }
+ String localEngine = resultSet.getString(1);
+ String createLocalTableDDL = resultSet.getString(2);
+ return localizationEngine(createLocalTableDDL, localEngine);
+ } catch (SQLException e) {
+ throw new RuntimeException("Cannot get clickhouse table", e);
+ }
+ }
Review Comment:
It seems you don't need to add this method, the method defined at line 182 is used to get `ClickhouseTable`, in my view, you just need to change the `createTableDDL` in line 192.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Emor-nj commented on pull request #1911: [Feature] [spark-clickhouse]ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
Emor-nj commented on PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#issuecomment-1129959759
> Can you fix this on flink too?
sure,i would do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on a diff in pull request #1911: [Feature] [spark-clickhouse]ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
BenJFan commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r875725742
##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-clickhouse/src/main/scala/org/apache/seatunnel/spark/clickhouse/sink/Table.scala:
##########
@@ -102,4 +105,10 @@ class Table(val name: String, val database: String, val engine: String, val crea
CheckResult.success()
}
}
+
+ def supportReplicatedMergeTree(ddl: String): String = {
Review Comment:
`supportReplicatedMergeTree` replace to `localizationEngine` will be more clear. Other guys maybe can do more in this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1911: [Feature] [spark-clickhouse]ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#issuecomment-1129845503
Can you fix this on flink too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1911: [Feature] [spark-clickhouse||flink-clickhouse]ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r880124933
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-clickhouse/src/main/java/org/apache/seatunnel/flink/clickhouse/sink/client/ClickhouseClient.java:
##########
@@ -212,4 +221,12 @@ public ClickhouseTable getClickhouseTable(String database, String table) {
}
+ public String localizationEngine(String engine, String ddl) {
Review Comment:
NIT: It's better to add UT for this method, and add comment what this method does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Emor-nj commented on a diff in pull request #1911: [Feature] [spark-clickhouse||flink-clickhouse]ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
Emor-nj commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r879207947
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-clickhouse/src/main/java/org/apache/seatunnel/flink/clickhouse/sink/client/ClickhouseClient.java:
##########
@@ -212,4 +212,28 @@ public ClickhouseTable getClickhouseTable(String database, String table) {
}
+ public String getLocalTableCreateDDL(String localDatabase, String localTable) {
+ try (ClickHouseConnection connection = balancedClickhouseDataSource.getConnection();
+ ClickHouseStatement statement = connection.createStatement()) {
+ String sql = String.format("select engine,create_table_query from system.tables where database = '%s' and name = '%s'", localDatabase, localTable);
+ ResultSet resultSet = statement.executeQuery(sql);
+ if (!resultSet.next()) {
+ throw new RuntimeException("Cannot get table from clickhouse, resultSet is empty");
+ }
+ String localEngine = resultSet.getString(1);
+ String createLocalTableDDL = resultSet.getString(2);
+ return localizationEngine(createLocalTableDDL, localEngine);
+ } catch (SQLException e) {
+ throw new RuntimeException("Cannot get clickhouse table", e);
+ }
+ }
Review Comment:
Yes, this is a better way.I will recommit. Thank you for your advice a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Emor-nj commented on pull request #1911: [Feature] [spark-clickhouse]ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
Emor-nj commented on PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#issuecomment-1129810204
cc @CalvinKirs Pelase check and give me some advice. Thank you very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1911: [Feature] [spark-clickhouse]ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#issuecomment-1129812774
> cc @CalvinKirs Pelase check and give me some advice. Thank you very much.
Thanks for your contribution, @BenJFan can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Emor-nj commented on a diff in pull request #1911: [Feature] [spark-clickhouse]ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
Emor-nj commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r875845905
##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-clickhouse/src/main/scala/org/apache/seatunnel/spark/clickhouse/sink/Table.scala:
##########
@@ -102,4 +105,10 @@ class Table(val name: String, val database: String, val engine: String, val crea
CheckResult.success()
}
}
+
+ def supportReplicatedMergeTree(ddl: String): String = {
Review Comment:
ok,i understand what you mean.i will change it.thank you for your advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Emor-nj commented on a diff in pull request #1911: [Feature] [clickhouse| ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
Emor-nj commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r881176470
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-clickhouse/src/main/java/org/apache/seatunnel/flink/clickhouse/sink/client/ClickhouseClient.java:
##########
@@ -212,4 +221,21 @@ public ClickhouseTable getClickhouseTable(String database, String table) {
}
+ /**
+ * Localization the engine in clickhouse local table's createTableDDL to support specific engine.
+ * For example: change ReplicatedMergeTree to MergeTree.
+ *
+ * @param engine original engine of clickhouse local table
+ * @param ddl createTableDDL of clickhouse local table
+ * @return createTableDDL of clickhouse local table which can support specific engine
+ * TODO: support more engine
+ */
+ public static String localizationEngine(String engine, String ddl) {
Review Comment:
Thank you,I have updated, please have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1911: [Feature] [clickhouse| ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r881214077
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-clickhouse/src/main/java/org/apache/seatunnel/flink/clickhouse/sink/client/ClickhouseClient.java:
##########
@@ -212,4 +221,21 @@ public ClickhouseTable getClickhouseTable(String database, String table) {
}
+ /**
+ * Localization the engine in clickhouse local table's createTableDDL to support specific engine.
+ * For example: change ReplicatedMergeTree to MergeTree.
+ *
+ * @param engine original engine of clickhouse local table
+ * @param ddl createTableDDL of clickhouse local table
+ * @return createTableDDL of clickhouse local table which can support specific engine
+ * TODO: support more engine
+ */
+ public static String localizationEngine(String engine, String ddl) {
Review Comment:
OK, I see your updated code, you remove the static, it's OK to me. In fact, I perfer to change the public to default, this is not a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1911: [Feature] [clickhouse| ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r880477487
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-clickhouse/src/main/java/org/apache/seatunnel/flink/clickhouse/sink/client/ClickhouseClient.java:
##########
@@ -212,4 +221,12 @@ public ClickhouseTable getClickhouseTable(String database, String table) {
}
+ public String localizationEngine(String engine, String ddl) {
Review Comment:
Please resolve the code style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1911: [Feature] [spark-clickhouse||flink-clickhouse]ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r879194714
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-clickhouse/src/main/java/org/apache/seatunnel/flink/clickhouse/sink/client/ClickhouseClient.java:
##########
@@ -212,4 +212,28 @@ public ClickhouseTable getClickhouseTable(String database, String table) {
}
+ public String getLocalTableCreateDDL(String localDatabase, String localTable) {
+ try (ClickHouseConnection connection = balancedClickhouseDataSource.getConnection();
+ ClickHouseStatement statement = connection.createStatement()) {
+ String sql = String.format("select engine,create_table_query from system.tables where database = '%s' and name = '%s'", localDatabase, localTable);
+ ResultSet resultSet = statement.executeQuery(sql);
+ if (!resultSet.next()) {
+ throw new RuntimeException("Cannot get table from clickhouse, resultSet is empty");
+ }
+ String localEngine = resultSet.getString(1);
+ String createLocalTableDDL = resultSet.getString(2);
+ return localizationEngine(createLocalTableDDL, localEngine);
+ } catch (SQLException e) {
+ throw new RuntimeException("Cannot get clickhouse table", e);
+ }
+ }
Review Comment:
If so, you can still change in `getClickhouseTable` method, since the method `getLocalTableCreateDDL` you add will not check if the input table is LocalTable or DistributedTable. I suggest you can just add query in `getClickhouseTable` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Emor-nj commented on a diff in pull request #1911: [Feature] [clickhouse| ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
Emor-nj commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r881176470
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-clickhouse/src/main/java/org/apache/seatunnel/flink/clickhouse/sink/client/ClickhouseClient.java:
##########
@@ -212,4 +221,21 @@ public ClickhouseTable getClickhouseTable(String database, String table) {
}
+ /**
+ * Localization the engine in clickhouse local table's createTableDDL to support specific engine.
+ * For example: change ReplicatedMergeTree to MergeTree.
+ *
+ * @param engine original engine of clickhouse local table
+ * @param ddl createTableDDL of clickhouse local table
+ * @return createTableDDL of clickhouse local table which can support specific engine
+ * TODO: support more engine
+ */
+ public static String localizationEngine(String engine, String ddl) {
Review Comment:
I have updated, please have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Emor-nj commented on a diff in pull request #1911: [Feature] [clickhouse| ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
Emor-nj commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r880130424
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-clickhouse/src/main/java/org/apache/seatunnel/flink/clickhouse/sink/client/ClickhouseClient.java:
##########
@@ -212,4 +221,12 @@ public ClickhouseTable getClickhouseTable(String database, String table) {
}
+ public String localizationEngine(String engine, String ddl) {
Review Comment:
ok, i will add it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on a diff in pull request #1911: [Feature] [clickhouse| ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
BenJFan commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r882248721
##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-clickhouse/pom.xml:
##########
@@ -56,6 +56,13 @@
<artifactId>sshd-scp</artifactId>
</dependency>
+ <dependency>
Review Comment:
Please format this dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Emor-nj commented on a diff in pull request #1911: [Feature] [clickhouse| ClickhouseFile support ReplicatedMergeTree
Posted by GitBox <gi...@apache.org>.
Emor-nj commented on code in PR #1911:
URL: https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r882256272
##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-clickhouse/pom.xml:
##########
@@ -56,6 +56,13 @@
<artifactId>sshd-scp</artifactId>
</dependency>
+ <dependency>
Review Comment:
Thank you, i have updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org