You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2023/08/16 01:04:35 UTC
[GitHub] [doris] yiguolei commented on a diff in pull request #23019: [refactor](load) use smart pointers to manage writers in memtable memory limiter
yiguolei commented on code in PR #23019:
URL: https://github.com/apache/doris/pull/23019#discussion_r1295276808
##########
be/src/olap/memtable_memory_limiter.cpp:
##########
@@ -61,14 +54,9 @@ Status MemTableMemoryLimiter::init(int64_t process_mem_limit) {
return Status::OK();
}
-void MemTableMemoryLimiter::register_writer(MemTableWriter* writer) {
+void MemTableMemoryLimiter::register_writer(std::weak_ptr<MemTableWriter> writer) {
Review Comment:
very very great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org