You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2023/05/11 23:26:40 UTC

[GitHub] [airflow] jedcunningham opened a new pull request, #31233: Fix `url_for_asset` fallback and 404 on DAG Audit Log

jedcunningham opened a new pull request, #31233:
URL: https://github.com/apache/airflow/pull/31233

   There was a 404 on the DAG Audit Log for bootstrap toggle css, which as far as I can tell, we aren't even trying to use. So we will no longer try and add it to the page.
   
   This highlighted the fact that if we don't have an asset in the manifest, `url_for_asset` would just leave off the filename completely. This resulted in the href being just `/static/`, with no filename as a breadcrumb in the eventual 404. Now we will just use the filename as-is so the 404 is more meaningful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] jedcunningham merged pull request #31233: Fix `url_for_asset` fallback and 404 on DAG Audit Log

Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham merged PR #31233:
URL: https://github.com/apache/airflow/pull/31233


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org