You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/06 06:55:24 UTC
[GitHub] [hudi] nsivabalan opened a new pull request, #6878: [HUDI-3397] Guard repeated rdd triggers
nsivabalan opened a new pull request, #6878:
URL: https://github.com/apache/hudi/pull/6878
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
**Risk level: none | low | medium | high**
_Choose one. If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on a diff in pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on code in PR #6878:
URL: https://github.com/apache/hudi/pull/6878#discussion_r1127407107
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BaseSparkCommitActionExecutor.java:
##########
@@ -176,7 +177,10 @@ public HoodieWriteMetadata<HoodieData<WriteStatus>> execute(HoodieData<HoodieRec
context.setJobStatus(this.getClass().getSimpleName(), "Doing partition and writing data: " + config.getTableName());
HoodieData<WriteStatus> writeStatuses = mapPartitionsAsRDD(inputRecordsWithClusteringUpdate, partitioner);
HoodieWriteMetadata<HoodieData<WriteStatus>> result = new HoodieWriteMetadata<>();
- updateIndexAndCommitIfNeeded(writeStatuses, result);
+ // dereference rdd so that no double de-referencing can happen by mistake.
+ int numPartitions = Math.max(1, writeStatuses.getNumPartitions());
+ HoodieData<WriteStatus> computedWriteStatus = HoodieJavaRDD.of(writeStatuses.collectAsList(), (HoodieSparkEngineContext) context, numPartitions);
Review Comment:
+1 This may not work in case of large inserts with millions of inserts. Success record tracking will be enabled when certain indexes (e.g. record index) is enabled in the MDT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6878:
URL: https://github.com/apache/hudi/pull/6878#issuecomment-1269728821
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12025",
"triggerID" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ffb92d083f6327bf062112a13c74a46963e54d8b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12025)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6878:
URL: https://github.com/apache/hudi/pull/6878#issuecomment-1276827721
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12025",
"triggerID" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"triggerType" : "PUSH"
}, {
"hash" : "19d74d675489e9c1ebee07cb5263ef440040807f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "19d74d675489e9c1ebee07cb5263ef440040807f",
"triggerType" : "PUSH"
}, {
"hash" : "43193e532c2331e2aeda54f7d43e6ec9fc483eea",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12171",
"triggerID" : "43193e532c2331e2aeda54f7d43e6ec9fc483eea",
"triggerType" : "PUSH"
}, {
"hash" : "a4a7199e2193120336615d55842fd92cca00fe86",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a4a7199e2193120336615d55842fd92cca00fe86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ffb92d083f6327bf062112a13c74a46963e54d8b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12025)
* 19d74d675489e9c1ebee07cb5263ef440040807f UNKNOWN
* 43193e532c2331e2aeda54f7d43e6ec9fc483eea Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12171)
* a4a7199e2193120336615d55842fd92cca00fe86 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #6878:
URL: https://github.com/apache/hudi/pull/6878#discussion_r1003663490
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BaseSparkCommitActionExecutor.java:
##########
@@ -176,7 +177,10 @@ public HoodieWriteMetadata<HoodieData<WriteStatus>> execute(HoodieData<HoodieRec
context.setJobStatus(this.getClass().getSimpleName(), "Doing partition and writing data: " + config.getTableName());
HoodieData<WriteStatus> writeStatuses = mapPartitionsAsRDD(inputRecordsWithClusteringUpdate, partitioner);
HoodieWriteMetadata<HoodieData<WriteStatus>> result = new HoodieWriteMetadata<>();
- updateIndexAndCommitIfNeeded(writeStatuses, result);
+ // dereference rdd so that no double de-referencing can happen by mistake.
+ int numPartitions = Math.max(1, writeStatuses.getNumPartitions());
Review Comment:
@nsivabalan we just might need to guard against an empty RDD, but otherwise since we're working w/ an RDD in here i think we can assume that it shouldn't be returning an invalid value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6878:
URL: https://github.com/apache/hudi/pull/6878#issuecomment-1269497275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ffb92d083f6327bf062112a13c74a46963e54d8b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #6878:
URL: https://github.com/apache/hudi/pull/6878#discussion_r1002756379
##########
hudi-common/src/main/java/org/apache/hudi/common/data/HoodieListData.java:
##########
@@ -148,6 +148,11 @@ public <O> HoodieData<T> distinctWithKey(SerializableFunction<T, O> keyGetter, i
.values();
}
+ @Override
+ public int getNumPartitions() {
+ return 1;
Review Comment:
to revert unneeded change
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BaseSparkCommitActionExecutor.java:
##########
@@ -176,7 +177,10 @@ public HoodieWriteMetadata<HoodieData<WriteStatus>> execute(HoodieData<HoodieRec
context.setJobStatus(this.getClass().getSimpleName(), "Doing partition and writing data: " + config.getTableName());
HoodieData<WriteStatus> writeStatuses = mapPartitionsAsRDD(inputRecordsWithClusteringUpdate, partitioner);
HoodieWriteMetadata<HoodieData<WriteStatus>> result = new HoodieWriteMetadata<>();
- updateIndexAndCommitIfNeeded(writeStatuses, result);
+ // dereference rdd so that no double de-referencing can happen by mistake.
+ int numPartitions = Math.max(1, writeStatuses.getNumPartitions());
Review Comment:
don't think we need to guard it by min 1. the API getNumPartitions() should guarantee meaningful return value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6878:
URL: https://github.com/apache/hudi/pull/6878#issuecomment-1276823856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12025",
"triggerID" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"triggerType" : "PUSH"
}, {
"hash" : "19d74d675489e9c1ebee07cb5263ef440040807f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "19d74d675489e9c1ebee07cb5263ef440040807f",
"triggerType" : "PUSH"
}, {
"hash" : "43193e532c2331e2aeda54f7d43e6ec9fc483eea",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "43193e532c2331e2aeda54f7d43e6ec9fc483eea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ffb92d083f6327bf062112a13c74a46963e54d8b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12025)
* 19d74d675489e9c1ebee07cb5263ef440040807f UNKNOWN
* 43193e532c2331e2aeda54f7d43e6ec9fc483eea UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] guanziyue commented on a diff in pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by GitBox <gi...@apache.org>.
guanziyue commented on code in PR #6878:
URL: https://github.com/apache/hudi/pull/6878#discussion_r1037815520
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BaseSparkCommitActionExecutor.java:
##########
@@ -176,7 +177,10 @@ public HoodieWriteMetadata<HoodieData<WriteStatus>> execute(HoodieData<HoodieRec
context.setJobStatus(this.getClass().getSimpleName(), "Doing partition and writing data: " + config.getTableName());
HoodieData<WriteStatus> writeStatuses = mapPartitionsAsRDD(inputRecordsWithClusteringUpdate, partitioner);
HoodieWriteMetadata<HoodieData<WriteStatus>> result = new HoodieWriteMetadata<>();
- updateIndexAndCommitIfNeeded(writeStatuses, result);
+ // dereference rdd so that no double de-referencing can happen by mistake.
+ int numPartitions = Math.max(1, writeStatuses.getNumPartitions());
+ HoodieData<WriteStatus> computedWriteStatus = HoodieJavaRDD.of(writeStatuses.collectAsList(), (HoodieSparkEngineContext) context, numPartitions);
Review Comment:
If write status tracking success record, will collecting them in driver case pressure on driver memory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6878:
URL: https://github.com/apache/hudi/pull/6878#issuecomment-1276873619
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12025",
"triggerID" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"triggerType" : "PUSH"
}, {
"hash" : "19d74d675489e9c1ebee07cb5263ef440040807f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "19d74d675489e9c1ebee07cb5263ef440040807f",
"triggerType" : "PUSH"
}, {
"hash" : "43193e532c2331e2aeda54f7d43e6ec9fc483eea",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12171",
"triggerID" : "43193e532c2331e2aeda54f7d43e6ec9fc483eea",
"triggerType" : "PUSH"
}, {
"hash" : "a4a7199e2193120336615d55842fd92cca00fe86",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12173",
"triggerID" : "a4a7199e2193120336615d55842fd92cca00fe86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 19d74d675489e9c1ebee07cb5263ef440040807f UNKNOWN
* 43193e532c2331e2aeda54f7d43e6ec9fc483eea Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12171)
* a4a7199e2193120336615d55842fd92cca00fe86 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12173)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6878:
URL: https://github.com/apache/hudi/pull/6878#issuecomment-1269505316
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12025",
"triggerID" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ffb92d083f6327bf062112a13c74a46963e54d8b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12025)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6878:
URL: https://github.com/apache/hudi/pull/6878#issuecomment-1276957196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12025",
"triggerID" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"triggerType" : "PUSH"
}, {
"hash" : "19d74d675489e9c1ebee07cb5263ef440040807f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "19d74d675489e9c1ebee07cb5263ef440040807f",
"triggerType" : "PUSH"
}, {
"hash" : "43193e532c2331e2aeda54f7d43e6ec9fc483eea",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12171",
"triggerID" : "43193e532c2331e2aeda54f7d43e6ec9fc483eea",
"triggerType" : "PUSH"
}, {
"hash" : "a4a7199e2193120336615d55842fd92cca00fe86",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12173",
"triggerID" : "a4a7199e2193120336615d55842fd92cca00fe86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 19d74d675489e9c1ebee07cb5263ef440040807f UNKNOWN
* a4a7199e2193120336615d55842fd92cca00fe86 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12173)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6878:
URL: https://github.com/apache/hudi/pull/6878#issuecomment-1276820479
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12025",
"triggerID" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"triggerType" : "PUSH"
}, {
"hash" : "19d74d675489e9c1ebee07cb5263ef440040807f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "19d74d675489e9c1ebee07cb5263ef440040807f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ffb92d083f6327bf062112a13c74a46963e54d8b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12025)
* 19d74d675489e9c1ebee07cb5263ef440040807f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6878:
URL: https://github.com/apache/hudi/pull/6878#issuecomment-1276831686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12025",
"triggerID" : "ffb92d083f6327bf062112a13c74a46963e54d8b",
"triggerType" : "PUSH"
}, {
"hash" : "19d74d675489e9c1ebee07cb5263ef440040807f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "19d74d675489e9c1ebee07cb5263ef440040807f",
"triggerType" : "PUSH"
}, {
"hash" : "43193e532c2331e2aeda54f7d43e6ec9fc483eea",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12171",
"triggerID" : "43193e532c2331e2aeda54f7d43e6ec9fc483eea",
"triggerType" : "PUSH"
}, {
"hash" : "a4a7199e2193120336615d55842fd92cca00fe86",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a4a7199e2193120336615d55842fd92cca00fe86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 19d74d675489e9c1ebee07cb5263ef440040807f UNKNOWN
* 43193e532c2331e2aeda54f7d43e6ec9fc483eea Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12171)
* a4a7199e2193120336615d55842fd92cca00fe86 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] guanziyue commented on a diff in pull request #6878: [HUDI-3397] Guard repeated rdd triggers
Posted by GitBox <gi...@apache.org>.
guanziyue commented on code in PR #6878:
URL: https://github.com/apache/hudi/pull/6878#discussion_r1037815520
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BaseSparkCommitActionExecutor.java:
##########
@@ -176,7 +177,10 @@ public HoodieWriteMetadata<HoodieData<WriteStatus>> execute(HoodieData<HoodieRec
context.setJobStatus(this.getClass().getSimpleName(), "Doing partition and writing data: " + config.getTableName());
HoodieData<WriteStatus> writeStatuses = mapPartitionsAsRDD(inputRecordsWithClusteringUpdate, partitioner);
HoodieWriteMetadata<HoodieData<WriteStatus>> result = new HoodieWriteMetadata<>();
- updateIndexAndCommitIfNeeded(writeStatuses, result);
+ // dereference rdd so that no double de-referencing can happen by mistake.
+ int numPartitions = Math.max(1, writeStatuses.getNumPartitions());
+ HoodieData<WriteStatus> computedWriteStatus = HoodieJavaRDD.of(writeStatuses.collectAsList(), (HoodieSparkEngineContext) context, numPartitions);
Review Comment:
If write status tracking success record, will collecting them in driver bring pressure on driver memory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-3397] Guard repeated rdd triggers [hudi]
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #6878:
URL: https://github.com/apache/hudi/pull/6878#issuecomment-2028572932
@nsivabalan : Is this PR still relevant or can be closed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org