You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2026/01/29 10:56:30 UTC
Re: [PR] Improve PMC RC verification breeze command for Airflow distribution [airflow]
amoghrajesh commented on code in PR #60993:
URL: https://github.com/apache/airflow/pull/60993#discussion_r2741054320
##########
dev/breeze/doc/09_release_management_tasks.rst:
##########
@@ -98,27 +98,67 @@ Validating Release Candidate for PMC
"""""""""""""""""""""""""""""""""""""
PMC members can use Breeze to automate verification of release candidates instead of manually
-running multiple verification steps. This command validates SVN files, GPG signatures, SHA512
-checksums, Apache RAT licenses, and reproducible builds.
+running multiple verification steps.
+
+This command validates SVN files, GPG signatures, SHA512 checksums, Apache RAT licenses, and
+reproducible builds.
+
+.. note::
+
+ This command is **experimental** and can change without notice (breaking changes are possible).
+ It is recommended to also follow the manual verification steps in the release guides and compare results.
Review Comment:
Maybe we dont need to specify cos its for RM only
##########
dev/breeze/src/airflow_breeze/commands/release_management_validation.py:
##########
@@ -28,18 +28,28 @@
@release_management_group.command(
- name="validate-rc-by-pmc",
- help="Validate release candidate for PMC voting",
+ name="verify-rc-by-pmc",
+ help=(
+ "Verify a release candidate for PMC voting (EXPERIMENTAL).\n"
Review Comment:
```suggestion
"[EXPERIMENTAL] Verify a release candidate for PMC voting.\n"
```
##########
dev/breeze/doc/09_release_management_tasks.rst:
##########
@@ -98,27 +98,67 @@ Validating Release Candidate for PMC
"""""""""""""""""""""""""""""""""""""
PMC members can use Breeze to automate verification of release candidates instead of manually
-running multiple verification steps. This command validates SVN files, GPG signatures, SHA512
-checksums, Apache RAT licenses, and reproducible builds.
+running multiple verification steps.
+
+This command validates SVN files, GPG signatures, SHA512 checksums, Apache RAT licenses, and
+reproducible builds.
+
+.. note::
+
+ This command is **experimental** and can change without notice (breaking changes are possible).
+ It is recommended to also follow the manual verification steps in the release guides and compare results.
+
+.. warning::
+
+ **Deprecation notice:** All checks except ``reproducible-build`` will be deprecated upon full
+ migration to Apache Trusted Releases (ATR). After migration, only the reproducible build check
+ will remain as the primary automated verification.
+
+Implementation notes
+^^^^^^^^^^^^^^^^^^^^
+
+* Reproducible build verification checks out the release tag, builds packages using the same
+ breeze commands as documented in README_RELEASE_AIRFLOW.md, and compares with SVN artifacts.
+* The validator performs a fast check for **SVN working copy locks** and fails early rather than
+ hanging on an ``svn`` command.
+
+Supported distributions
+^^^^^^^^^^^^^^^^^^^^^^^
+
+Currently supported:
+
+* ``--distribution airflow``
+
+Other values (``providers``, ``airflowctl``, ``python-client``) exist for future expansion but are not yet implemented.
.. code-block:: bash
- breeze release-management validate-rc-by-pmc --distribution airflow --version 3.1.3rc1 --task-sdk-version 1.1.3rc1 --svn-path ~/asf-dist/dev/airflow
+ breeze release-management verify-rc-by-pmc \
+ --distribution airflow \
+ --version 3.1.3rc1 \
+ --task-sdk-version 1.1.3rc1 \
+ --path-to-airflow-svn ~/asf-dist/dev/airflow
Review Comment:
Woah good catch
##########
dev/breeze/doc/09_release_management_tasks.rst:
##########
@@ -98,27 +98,67 @@ Validating Release Candidate for PMC
"""""""""""""""""""""""""""""""""""""
PMC members can use Breeze to automate verification of release candidates instead of manually
-running multiple verification steps. This command validates SVN files, GPG signatures, SHA512
-checksums, Apache RAT licenses, and reproducible builds.
+running multiple verification steps.
+
+This command validates SVN files, GPG signatures, SHA512 checksums, Apache RAT licenses, and
+reproducible builds.
+
+.. note::
+
+ This command is **experimental** and can change without notice (breaking changes are possible).
+ It is recommended to also follow the manual verification steps in the release guides and compare results.
+
+.. warning::
+
+ **Deprecation notice:** All checks except ``reproducible-build`` will be deprecated upon full
+ migration to Apache Trusted Releases (ATR). After migration, only the reproducible build check
+ will remain as the primary automated verification.
+
+Implementation notes
+^^^^^^^^^^^^^^^^^^^^
+
+* Reproducible build verification checks out the release tag, builds packages using the same
+ breeze commands as documented in README_RELEASE_AIRFLOW.md, and compares with SVN artifacts.
+* The validator performs a fast check for **SVN working copy locks** and fails early rather than
+ hanging on an ``svn`` command.
+
+Supported distributions
+^^^^^^^^^^^^^^^^^^^^^^^
+
+Currently supported:
+
+* ``--distribution airflow``
+
+Other values (``providers``, ``airflowctl``, ``python-client``) exist for future expansion but are not yet implemented.
.. code-block:: bash
- breeze release-management validate-rc-by-pmc --distribution airflow --version 3.1.3rc1 --task-sdk-version 1.1.3rc1 --svn-path ~/asf-dist/dev/airflow
+ breeze release-management verify-rc-by-pmc \
+ --distribution airflow \
+ --version 3.1.3rc1 \
+ --task-sdk-version 1.1.3rc1 \
+ --path-to-airflow-svn ~/asf-dist/dev/airflow
You can run individual checks by specifying the ``--checks`` flag:
.. code-block:: bash
- breeze release-management validate-rc-by-pmc \
+ breeze release-management verify-rc-by-pmc \
--distribution airflow \
--version 3.1.3rc1 \
- --svn-path ~/asf-dist/dev/airflow \
- --checks svn,signatures,checksums,licenses
+ --task-sdk-version 1.1.3rc1 \
Review Comment:
```suggestion
--task-sdk-version 1.1.3rc1 \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org