You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Nicolas (Jira)" <ji...@apache.org> on 2020/01/31 12:29:00 UTC

[jira] [Commented] (AIRFLOW-3488) PostgresToGoogleCloudStorageOperator doesn't handle PostgreSQL ARRAYs properly

    [ https://issues.apache.org/jira/browse/AIRFLOW-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027445#comment-17027445 ] 

Nicolas commented on AIRFLOW-3488:
----------------------------------

I've done the fix on a local branch, how to push it and open a pull request on this issue?

> PostgresToGoogleCloudStorageOperator doesn't handle PostgreSQL ARRAYs properly 
> -------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-3488
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3488
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: contrib, gcp, operators
>    Affects Versions: 1.10.1
>            Reporter: Duan Shiqiang
>            Assignee: Nicolas
>            Priority: Major
>
> PostgresToGoogleCloudStorageOperator generates bigquery schema wrongly for postgres data type ARRAY (it generates bigquery schema with that filed as string).
> The generated bigquery schema set mode for one field to 'REPEATED' if the type_code of the postgres column is one of (1009, 1005, 1007, 1016). see: [https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/postgres_to_gcs_operator.py#L185] . This doesn't include all possible array types (see [https://github.com/psycopg/psycopg2/blob/master/psycopg/typecast_builtins.c)]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)