[GitHub] [rocketmq-apis] lizhanhui commented on a diff in pull request #33: [ISSUE #32] add check_message_type to publishing setting.

[GitBox <gi...@apache.org>]

lizhanhui commented on code in PR #33:
URL: https://github.com/apache/rocketmq-apis/pull/33#discussion_r875700546


##########
apache/rocketmq/v2/service.proto:
##########
@@ -193,6 +193,10 @@ message Publishing {
   // reject the request. As a result, it is advisable that Producer performs
   // client-side check validation.
   int32 max_body_size = 3;
+
+  // When `check_message_type` flag set `false`, no need to check message's type
+  // with messageQueue's `accept_message_types` before publising.
+  bool check_message_type = 4;

Review Comment:
   It's generally discouraged to use bool in the protocol definition. Prefer explicit enum.
   For example
   enum ValidateMessageTypeStrategy {
    UNSPECIFIED = 0,
   DISABLED = 1,
   PERMISSIVE = 2,
   ENFORCING = 3,
   }



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org