[jira] [Commented] (SCB-630) Active the -Pdocker profile if detect the docker installation

["Gao Xin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512081#comment-16512081 ] 

Gao Xin commented on SCB-630:
-----------------------------

With the newest offical docker CE, it does not need `DOCKER_HOST` any more。

There are other problems in keeping this configuration for compatibility. Unfortunately, maven `<activation>` block changed from a list of `OR` to 'AND' since 3.2.2. 

references:

[https://stackoverflow.com/questions/4629140/maven-profile-activation-with-multiple-conditions]

https://issues.apache.org/jira/browse/MNG-4565

 

> Active the -Pdocker profile if detect the docker installation 
> --------------------------------------------------------------
>
>                 Key: SCB-630
>                 URL: https://issues.apache.org/jira/browse/SCB-630
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Saga
>            Reporter: Willem Jiang
>            Assignee: Gao Xin
>            Priority: Major
>              Labels: easyfix, newbie
>             Fix For: saga-0.3.0
>
>
> Currently we use the -Pdocker to use the docker enabled feature to avoid the build failure if there is no docker installation.
> Now we can use the maven [profile with activation|https://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.html] to enable the docker profile automatically.
> {code}
>      <activation>
>         <file>
>           <exists>/var/run/docker.sock</exists>
>         </file>
>         <property>
>           <name>env.DOCKER_HOST</name>
>         </property>
>       </activation>
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)